[Bug 12753] New: Warnings in t/SIP_Sip.t could be tested
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12753 Bug ID: 12753 Summary: Warnings in t/SIP_Sip.t could be tested Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com Warnings are a feature some functions provide (i.e. expected behaviour) and can be tested. In this case, warnings raised by t/SIP_Sip.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12753 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12753 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 30748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30748&action=edit Bug 12753: Warnings in t/SIP_Sip.t could be tested A C4::SIP warning is expected and should be tested. To test: - Run $ prove -v t/SIP_Sip.t => FAIL: A warning is printed to STDOUT - Apply the patch - Run $ prove -v t/SIP_Sip.t => SUCCESS: No warnings on STDOUT, a new test verifying the warning is added. - It was an easy one, smile and sign off :-D -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12753 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30748|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 30749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30749&action=edit Bug 12753: Warnings in t/SIP_Sip.t could be tested A C4::SIP warning is expected and should be tested. To test: - Run $ prove -v t/SIP_Sip.t => FAIL: A warning is printed to STDOUT - Apply the patch - Run $ prove -v t/SIP_Sip.t => SUCCESS: No warnings on STDOUT, a new test verifying the warning is added. - It was an easy one, smile and sign off :-D Sponsored-by: The Will to Procrastinate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12753 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12753 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30749|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30888&action=edit Bug 12753: Warnings in t/SIP_Sip.t could be tested A C4::SIP warning is expected and should be tested. To test: - Run $ prove -v t/SIP_Sip.t => FAIL: A warning is printed to STDOUT - Apply the patch - Run $ prove -v t/SIP_Sip.t => SUCCESS: No warnings on STDOUT, a new test verifying the warning is added. - It was an easy one, smile and sign off :-D Sponsored-by: The Will to Procrastinate Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Sponsored-by: Sunday TV is boring -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12753 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12753 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30888|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30890&action=edit [PASSED QA] Bug 12753: Warnings in t/SIP_Sip.t could be tested A C4::SIP warning is expected and should be tested. To test: - Run $ prove -v t/SIP_Sip.t => FAIL: A warning is printed to STDOUT - Apply the patch - Run $ prove -v t/SIP_Sip.t => SUCCESS: No warnings on STDOUT, a new test verifying the warning is added. - It was an easy one, smile and sign off :-D Sponsored-by: The Will to Procrastinate Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Sponsored-by: Sunday TV is boring Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Sponsored-by: Avoiding distance study homework -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12753 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org