[Bug 33059] New: Capitalization: Fix sample authorised value descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 Bug ID: 33059 Summary: Capitalization: Fix sample authorised value descriptions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We still have "Staff Collection" and "Restricted Access" in the sample values for authorised values that don't follow capitalization rules. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147271&action=edit Bug 33059: Fix capitalizatoin of AV sample category descriptions * Fixes capitalization * Standardizes on e-book (see https://www.oxfordlearnersdictionaries.com/definition/english/e-book) * Standardizes on audiobook (see https://www.oxfordlearnersdictionaries.com/definition/english/audiobook) To test: * This is a little difficult to test. What you'd need to do: * Apply the patch * Drop your database, recreate it, run the web installer * Make sure to select the optional AV along with the mandatory to install * Log into Koha after finishing the installer and go to administration > authorised values * Review the existing sample values for incorrect capitalization in the different categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147271|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 148110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148110&action=edit Bug 33059: Fix capitalizatoin of AV sample category descriptions * Fixes capitalization * Standardizes on e-book (see https://www.oxfordlearnersdictionaries.com/definition/english/e-book) * Standardizes on audiobook (see https://www.oxfordlearnersdictionaries.com/definition/english/audiobook) To test: * This is a little difficult to test. What you'd need to do: * Apply the patch * Drop your database, recreate it, run the web installer * Make sure to select the optional AV along with the mandatory to install * Log into Koha after finishing the installer and go to administration > authorised values * Review the existing sample values for incorrect capitalization in the different categories Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes: 1. A reset_all updated all the updated values after applying the patch. 2. I also tested by using the web installer (see https://gitlab.com/-/snippets/1893788#user-content-start-the-web-installer) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148110|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148239&action=edit Bug 33059: Fix capitalizatoin of AV sample category descriptions * Fixes capitalization * Standardizes on e-book (see https://www.oxfordlearnersdictionaries.com/definition/english/e-book) * Standardizes on audiobook (see https://www.oxfordlearnersdictionaries.com/definition/english/audiobook) To test: * This is a little difficult to test. What you'd need to do: * Apply the patch * Drop your database, recreate it, run the web installer * Make sure to select the optional AV along with the mandatory to install * Log into Koha after finishing the installer and go to administration > authorised values * Review the existing sample values for incorrect capitalization in the different categories Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 148239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148239 Bug 33059: Fix capitalizatoin of AV sample category descriptions Review of attachment 148239: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=33059&attachment=148239) ----------------------------------------------------------------- ::: installer/data/mysql/en/mandatory/auth_values.yml @@ +4045,5 @@
- category: "qualif" authorised_value: "110" + lib: "Binder an agent who binds an item." + lib_opac: "Binder an agent who binds an item."
I'm not 100% sure about this one.. it doesn't read right to me. "Binder, the agent who binds an item." perhaps? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I find it interesting that Binder is the only relator term with an explanation of what it is... Are we afraid we're going to think that it is like a 3-ring binder type thing? The context of the authorised value list should make it obvious. I found the list in English here: https://cdn.ifla.org/wp-content/uploads/U_B_AppB_update2021_ONLINE_FINAL-1.p... The explanation is really "An agent who binds an item." Personally, I would either remove it to match all the other relator terms, or put the explanation in parentheses, but keep the "An agent". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Of course, I'm speaking without *any* UNIMARC experience... I can try to contact the French list and have one of them comment on this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I also stumbled on that one, but maybe we could solve separately? This one was only about cosmetics. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Katrin Fischer from comment #8)
I also stumbled on that one, but maybe we could solve separately? This one was only about cosmetics. :)
Good idea -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148239|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148333&action=edit Bug 33059: Fix capitalizatoin of AV sample category descriptions * Fixes capitalization * Standardizes on e-book (see https://www.oxfordlearnersdictionaries.com/definition/english/e-book) * Standardizes on audiobook (see https://www.oxfordlearnersdictionaries.com/definition/english/audiobook) To test: * This is a little difficult to test. What you'd need to do: * Apply the patch * Drop your database, recreate it, run the web installer * Make sure to select the optional AV along with the mandatory to install * Log into Koha after finishing the installer and go to administration > authorised values * Review the existing sample values for incorrect capitalization in the different categories Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33059 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33269 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org