https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 69193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69193&action=edit Bug 19646: fix value_builder marc21_linking_section template When using marc21_linking_section cataloging plugin, you get the error : Template process failed: undef error - The method selected is not covered by tests! at /home/koha/src/C4/Templates.pm line 122. It commes from [% IF ( itypeloo.selected ) %], selected is not defined in itypeloo. This patch removes this condition because all item types are fetched from database, there is not one selected. It sets "All item types" as selected. Also correctes two errors in HTML : ending form and div, "<a_class=" instead of "<a class=" Test plan : 1) Use a MARC21 database 2) Define marc21_linking_section cataloging plugin in framework, on 773$t for example 3) Create a new biblio record 4) Click on icon in 773$t 5) Check plugin works fine -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69193|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69194&action=edit Bug 19646: fix value_builder marc21_linking_section template When using marc21_linking_section cataloging plugin, you get the error : Template process failed: undef error - The method selected is not covered by tests! at /home/koha/src/C4/Templates.pm line 122. It commes from [% IF ( itypeloo.selected ) %], selected is not defined in itypeloo. This patch removes this condition because all item types are fetched from database, there is not one selected. It sets "All item types" as selected. Also correctes two errors in HTML : ending form and div, "<a_class=" instead of "<a class=" Test plan : 1) Use a MARC21 database 2) Define marc21_linking_section cataloging plugin in framework, on 773$t for example 3) Create a new biblio record 4) Click on icon in 773$t 5) Check plugin works fine Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69194|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69330&action=edit Bug 19646: fix value_builder marc21_linking_section template When using marc21_linking_section cataloging plugin, you get the error : Template process failed: undef error - The method selected is not covered by tests! at /home/koha/src/C4/Templates.pm line 122. It commes from [% IF ( itypeloo.selected ) %], selected is not defined in itypeloo. This patch removes this condition because all item types are fetched from database, there is not one selected. It sets "All item types" as selected. Also correctes two errors in HTML : ending form and div, "<a_class=" instead of "<a class=" Test plan : 1) Use a MARC21 database 2) Define marc21_linking_section cataloging plugin in framework, on 773$t for example 3) Create a new biblio record 4) Click on icon in 773$t 5) Check plugin works fine Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Changes do not seem to affect translation. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6)

Erk, I missed this one!

You missed much more. Too bad. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646 --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in v17.05.07 -- You are receiving this mail because: You are watching all bug changes.