[Bug 14571] New: using_https check for ssl connections doesn't work in some situations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Bug ID: 14571 Summary: using_https check for ssl connections doesn't work in some situations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org This is especially problematic for Amazon images, since if the check fails the normal images are used, causing mixed content warnings. I think we should remove the checks from Amazon images in the OPAC and just use the https Amazon url's for images. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 41100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41100&action=edit Bug 14571: using_https check for ssl connections doesn't work in some situations To test: * turn on Amazon images for result and detail in the OPAC * do a search that will result in an Amazon image being displayed on the result page * inspect the cover image that is returned on the result page, it should be using a https://images-na... Amazon URL. * click through to the detail for that item * inspect the cover image that is returned on the detail page, it should be using a https://images-na... Amazon URL. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 41101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41101&action=edit Bug 14571: HTTPS Amazon images [follow up] I found a couple more places where we should be using images-na, so I updated them * in the shelf browser * in XISBN related works (honestly not sure how to test this one, but changing from the http:// url won't hurt anything.) To test: * Turn on the shelf browser, and browse for an item that has an amazon image, * inspect it, it should be using https://images-na... url. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 41102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41102&action=edit Bug 14571 - More switching of Amazon image source URL to https modified: modules/opac-opensearch.tt modified: modules/opac-results-grouped.tt modified: modules/opac-shelves.tt modified: modules/opac-showreviews-rss.tt modified: modules/opac-showreviews.tt Basically, just inspect these places and make sure the Amazon images are using https://images-na instead of http://images -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli@cineca.it | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Can we get a sign off on this please, I can't sign it off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41100|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 46229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46229&action=edit [SIGNED-OFF] Bug 14571: using_https check for ssl connections doesn't work in some situations To test: * turn on Amazon images for result and detail in the OPAC * do a search that will result in an Amazon image being displayed on the result page * inspect the cover image that is returned on the result page, it should be using a https://images-na... Amazon URL. * click through to the detail for that item * inspect the cover image that is returned on the detail page, it should be using a https://images-na... Amazon URL. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41101|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 46230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46230&action=edit [SIGNED-OFF] Bug 14571: HTTPS Amazon images [follow up] I found a couple more places where we should be using images-na, so I updated them * in the shelf browser * in XISBN related works (honestly not sure how to test this one, but changing from the http:// url won't hurt anything.) To test: * Turn on the shelf browser, and browse for an item that has an amazon image, * inspect it, it should be using https://images-na... url. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 46231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46231&action=edit [SIGNED-OFF] Bug 14571 - More switching of Amazon image source URL to https modified: modules/opac-opensearch.tt modified: modules/opac-results-grouped.tt modified: modules/opac-shelves.tt modified: modules/opac-showreviews-rss.tt modified: modules/opac-showreviews.tt Basically, just inspect these places and make sure the Amazon images are using https://images-na instead of http://images Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41102|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There are 2 more left, is it expected? koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt: <img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt: <img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #9 from Liz Rea <liz@catalyst.net.nz> --- I didn't go after the intranet here, but I didn't specify so I'll add a followup. :) Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #10 from Liz Rea <liz@catalyst.net.nz> --- Can we get these ones through first though? I'll make a different bug for the intranet detail. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15518 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46229|0 |1 is obsolete| | Attachment #46230|0 |1 is obsolete| | Attachment #46231|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46418&action=edit Bug 14571: using_https check for ssl connections doesn't work in some situations To test: * turn on Amazon images for result and detail in the OPAC * do a search that will result in an Amazon image being displayed on the result page * inspect the cover image that is returned on the result page, it should be using a https://images-na... Amazon URL. * click through to the detail for that item * inspect the cover image that is returned on the detail page, it should be using a https://images-na... Amazon URL. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46419&action=edit Bug 14571: HTTPS Amazon images [follow up] I found a couple more places where we should be using images-na, so I updated them * in the shelf browser * in XISBN related works (honestly not sure how to test this one, but changing from the http:// url won't hurt anything.) To test: * Turn on the shelf browser, and browse for an item that has an amazon image, * inspect it, it should be using https://images-na... url. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46420&action=edit Bug 14571 - More switching of Amazon image source URL to https modified: modules/opac-opensearch.tt modified: modules/opac-results-grouped.tt modified: modules/opac-shelves.tt modified: modules/opac-showreviews-rss.tt modified: modules/opac-showreviews.tt Basically, just inspect these places and make sure the Amazon images are using https://images-na instead of http://images Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46421&action=edit Bug 14571 - Intranet detail needs ssl sources for Amazon images To test: Enable Amazon images for the staff client - syspref: AmazonCoverImages -> Show Go to a record detail in the intranet that has an Amazon image, inspect it, and make sure that it 1. Shows 2. has https://images-na. and not http://images. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Liz Rea from comment #10)
Can we get these ones through first though? I'll make a different bug for the intranet detail.
Cheers, Liz
I have embedded it in this patch set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 15518 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #17 from Liz Rea <liz@catalyst.net.nz> --- Sweet as, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org