[Bug 20323] New: Batch patron modification tool broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Bug ID: 20323 Summary: Batch patron modification tool broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org
From tools/modborrowers.pl
341 if ( $patron ) { 342 $patron = $patron->unblessed; 343 $patron->{category_description} = $patron->category->description; This was added by bug 18403 and leads (obviosly) to error: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | Depends on| |18403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72347&action=edit Bug 20323: Fix batch patron modification tool Test plan: 1) Go to Tools -> Batch patrons modification 2) Select some patrons and try to change any field --> without patch - it exploads with log: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl --> with patch - the modification is properly made -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72347|0 |1 is obsolete| | --- Comment #2 from Roch D'Amour <roch.damour@inlibro.com> --- Created attachment 72384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72384&action=edit Bug 20323: Fix batch patron modification tool Test plan: 1) Go to Tools -> Batch patrons modification 2) Select some patrons and try to change any field --> without patch - it exploads with log: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl --> with patch - the modification is properly made Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72384|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72541&action=edit Bug 20323: Fix batch patron modification tool Test plan: 1) Go to Tools -> Batch patrons modification 2) Select some patrons and try to change any field --> without patch - it exploads with log: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl --> with patch - the modification is properly made Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to master for 18.05, thanks to all for your hard work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Depends on 18403 which is not in stable, not backporting for 17.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org