https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056 --- Comment #1 from Andrew Nugged <nugged@gmail.com> --- also to note maybe for separate tickets later (needs to be analyzed): this `unless ( C4::Context->config('demo') ) { ... ` it's never failed because it returns _REFERENCE_TO_HASH_, even the hash is empty: ``` sub set_preferences { warn C4::Context->config( 'demo' ); warn C4::Context->config( 'demo' ) ? 'TRUTH' : 'FALSE'; warn Dumper(C4::Context->config( 'demo' )); unless ( C4::Context->config('demo') ) { ... ``` Gives: [2021/09/20 10:42:56] [WARN] HASH(0x5646ead56e00) [2021/09/20 10:42:56] [WARN] TRUTH [2021/09/20 10:42:56] [WARN] $VAR1 = {}; We might have other "if/unless ->config" usages not even for the "demo" key in our code which might be degraded with this "always true" trick. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125051|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125255&action=edit Bug 29056: Remove the demo functionality leftovers Remove forgotten code of the old legacy demo functionality that was removed from elsewhere except systempreferences, this code not only serves no purpose but also is causing some troubles for our customers. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi --- Comment #5 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Passing QA. @nugged: I wonder how you were able to get C4::Context->config return an empty hash, it seems like somehow somewhere that code didn't manage to find a configuration file or there is a bug in the C4::Context code. Would love to hear more about this in case it turns out to be a bug in C4::Context. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.