[Bug 39410] New: Notice display modal should use shadow dom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Bug ID: 39410 Summary: Notice display modal should use shadow dom Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Whilst we improved the notice display modal in bug 30287, it still doesn't fully reflect how a notice appears for the end user. Because we're not using a shadow dom or embedded iframe, we are including all the styles of the parent page within the notice display. (hence it misleads us to think bootstrap styles are available within notices when in fact we do not include the bootstrap sheets in either HTML email or print notice outputs. I propose using shadow dom to rectify that and ensure notice displays match as closely as possible to how they will display to the end user.. be that printed or in their email. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 [Bug 30287] Notices using HTML render differently in notices.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38087 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 [Bug 38087] Ship a default print template for the welcome notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179626&action=edit Bug 39410: Use shadowDOM for notice display modal This patch updates the notice display modal found in the members > notices page to use a shadowDOM to more accurately display notices matching how they should display for patrons in their email clients or when printed. Test plan 1) We can use the 'WELCOME' print notice introduced in bug 38087 as it includes Bootstrap classes for display. 2) Navigate to the 'Henry' user in KTD and use the 'More > Send welcome notice' option to trigger a print notice. 3) Navigate to the 'Notices' tab for the 'Henry' user and click on the notice title to trigger the display modal. 4) Note the well formatted notice with an address block on the right and some sections in bold. 5) Apply this patchset 6) Display the notice again as in step 3 and note that the foratting is now lost. This is showing proper scoping of the CSS in the same way that the notice will be displayed to the end user when printed using batch printing. Note: Whilst this degrades the look of the notice in the staff client, that is actualy highlighting a mistake in the notice template or possible showing that we should be including bootstrap in the print notices template... that is for another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com, | |katrin.fischer@bsz-bw.de, | |me@paulderscheid.xyz, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36780 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179626|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 180065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180065&action=edit Bug 39410: Use shadowDOM for notice display modal This patch updates the notice display modal found in the members > notices page to use a shadowDOM to more accurately display notices matching how they should display for patrons in their email clients or when printed. Test plan 1) We can use the 'WELCOME' print notice introduced in bug 38087 as it includes Bootstrap classes for display. 2) Navigate to the 'Henry' user in KTD and use the 'More > Send welcome notice' option to trigger a print notice. 3) Navigate to the 'Notices' tab for the 'Henry' user and click on the notice title to trigger the display modal. 4) Note the well formatted notice with an address block on the right and some sections in bold. 5) Apply this patchset 6) Display the notice again as in step 3 and note that the foratting is now lost. This is showing proper scoping of the CSS in the same way that the notice will be displayed to the end user when printed using batch printing. Note: Whilst this degrades the look of the notice in the staff client, that is actualy highlighting a mistake in the notice template or possible showing that we should be including bootstrap in the print notices template... that is for another bug. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180065|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180274&action=edit Bug 39410: Use shadowDOM for notice display modal This patch updates the notice display modal found in the members > notices page to use a shadowDOM to more accurately display notices matching how they should display for patrons in their email clients or when printed. Test plan 1) We can use the 'WELCOME' print notice introduced in bug 38087 as it includes Bootstrap classes for display. 2) Navigate to the 'Henry' user in KTD and use the 'More > Send welcome notice' option to trigger a print notice. 3) Navigate to the 'Notices' tab for the 'Henry' user and click on the notice title to trigger the display modal. 4) Note the well formatted notice with an address block on the right and some sections in bold. 5) Apply this patchset 6) Display the notice again as in step 3 and note that the foratting is now lost. This is showing proper scoping of the CSS in the same way that the notice will be displayed to the end user when printed using batch printing. Note: Whilst this degrades the look of the notice in the staff client, that is actualy highlighting a mistake in the notice template or possible showing that we should be including bootstrap in the print notices template... that is for another bug. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | Patch complexity|--- |Small patch CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39638 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39638 [Bug 39638] Notice display modal should respect 'email' message transport type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35267 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Bug 39410 depends on bug 30287, which changed state. Bug 30287 Summary: Notices using HTML render differently in notices.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38087 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41053 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41053 [Bug 41053] Make notice contents searchable on notices tab of patron details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12123 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 [Bug 12123] HTML notices can break the notice viewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|41053 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41053 [Bug 41053] Make notice contents searchable on notices tab of patron details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41053 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41053 [Bug 41053] Make notice contents searchable on notices tab of patron details -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org