[Bug 20000] New: use Modern::Perl in installer perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Bug ID: 20000 Summary: use Modern::Perl in installer perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com use Modern::Perl should be used instead of use strict; use warnings; Relevant in: data/mysql/backfill_statistics.pl data/mysql/labels_upgrade.pl data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl data/mysql/updatedatabase.pl externalmodules.pl html-template-to-template-toolkit.pl install.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Zoe Bennett <zoebennett1308@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #1 from Zoe Bennett <zoebennett1308@gmail.com> --- Created attachment 70648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70648&action=edit Bug 20000: Changing 'use strict: use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use strict; use warnings;' in the following installer perl scripts: data/mysql/backfill_statistics.pl data/mysql/labels_upgrade.pl data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl data/mysql/updatedatabase.pl externalmodules.pl html-template-to-template-toolkit.pl install.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 70648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70648 Bug 20000: Changing 'use strict: use warnings;' to 'use Modern::Perl;' Review of attachment 70648: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20000&attachment=70648) ----------------------------------------------------------------- ::: installer/data/mysql/labels_upgrade.pl @@ +17,4 @@
# You should have received a copy of the GNU General Public License # along with Koha; if not, see <http://www.gnu.org/licenses>.
+use Modern::Perl;
Commented out with '# FIXME - Bug 2505' would make more sense. @@ -17,5 @@
# You should have received a copy of the GNU General Public License # along with Koha; if not, see <http://www.gnu.org/licenses>.
-#use strict; -#use warnings; FIXME - Bug 2505
These are commented out. ::: installer/data/mysql/patroncards_upgrade.pl @@ +17,4 @@
# You should have received a copy of the GNU General Public License # along with Koha; if not, see <http://www.gnu.org/licenses>.
+use Modern::Perl;
not commented? @@ -17,5 @@
# You should have received a copy of the GNU General Public License # along with Koha; if not, see <http://www.gnu.org/licenses>.
-#use strict; -#use warnings; FIXME - Bug 2505
commented. ::: installer/data/mysql/update22to30.pl @@ -11,5 @@
# - Would also be a good idea to offer to do a backup at this time...
# NOTE: If you do something more than once in here, make it table driven. -use strict; -#use warnings; FIXME - Bug 2505
This is a strange case. Do we have anyone really using pre-3.0 still? I thought this script might be pointless by now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Needs Signoff |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks like this is a Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Zoe Bennett <zoebennett1308@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #4 from Zoe Bennett <zoebennett1308@gmail.com> --- Created attachment 70710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70710&action=edit Bug 20000: Fixing problems with the change to 'use strict: use warnings;' to 'use Modern::Perl;' in the follwing installer script data/mysql/labels_upgrade.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #5 from Zoe Bennett <zoebennett1308@gmail.com> --- Created attachment 70711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70711&action=edit Bug 20000: Fixing problems with the change to 'use strict: use warnings;' to 'use Modern::Perl;' in the following installer scripts data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70710|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |zoebennett1308@gmail.com |ity.org | Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70648|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70840&action=edit Bug 20000: Changing 'use strict: use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use strict; use warnings;' in the following installer perl scripts: data/mysql/backfill_statistics.pl data/mysql/labels_upgrade.pl data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl data/mysql/updatedatabase.pl externalmodules.pl html-template-to-template-toolkit.pl install.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70841&action=edit Bug 20000: use Modern::Perl in installer perl scripts Fixing problems with the change to 'use strict: use warnings;' to 'use Modern::Perl;' in the following installer scripts data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70711|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70840|0 |1 is obsolete| | Attachment #70841|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71191&action=edit Bug 20000: use Modern::Perl in installer perl scripts Test Plan: - Check that it now says 'use Modern::Perl' and not 'use strict; use warnings;' in the following installer perl scripts: data/mysql/backfill_statistics.pl data/mysql/labels_upgrade.pl data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl data/mysql/updatedatabase.pl externalmodules.pl html-template-to-template-toolkit.pl install.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Squashed patches as both had the same author and were signed by Owen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The patch adds use strict for scripts that were used in a very old upgrade (3.01). I do not think it is a good idea to update them (or spend time to improve them). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 72297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72297&action=edit Bug 20000: Removing Modern::Perl from old scripts as per Jonathan's comment 10 Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 71191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71191 Bug 20000: use Modern::Perl in installer perl scripts Review of attachment 71191: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20000&attachment=71191) ----------------------------------------------------------------- ::: installer/data/mysql/update22to30.pl @@ +11,5 @@
# - Would also be a good idea to offer to do a backup at this time...
# NOTE: If you do something more than once in here, make it table driven. + +use Modern::Perl;
The warnings is commented. I don't think this substitution is necessarily good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- installer/data/mysql/update22to30.pl Mark, do you mean we should remove the use Modern::Perl from this old script? I'd like to unlock this one, as it's the last blocking bug 2505. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We should not touch these scripts unless they have been tested with the changes (which is quite a lot of work for the gain it will bring). Ok for install.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #14)
We should not touch these scripts unless they have been tested with the changes (which is quite a lot of work for the gain it will bring).
Ok for install.pl
Do you mean the only file in this set we should use Modern::Perl in is install.pl? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #15)
(In reply to Jonathan Druart from comment #14)
We should not touch these scripts unless they have been tested with the changes (which is quite a lot of work for the gain it will bring).
Ok for install.pl
Do you mean the only file in this set we should use Modern::Perl in is install.pl?
Re-reading the patch I'd say we can use Modern::Perl when strict *and* warnings were used before. For others remove the FIXME and the commented lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71191|0 |1 is obsolete| | Attachment #72297|0 |1 is obsolete| | --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 83402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83402&action=edit Bug 20000: Use Modern::Perl in installer scripts To test: Check that we are using Modern::Perl when strict *and* warnings were used before, and commented lines and FIXMEs have been removed from the rest, out of files listed below. data/mysql/backfill_statistics.pl data/mysql/labels_upgrade.pl data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl data/mysql/updatedatabase.pl externalmodules.pl html-template-to-template-toolkit.pl install.pl Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|zoebennett1308@gmail.com |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83402|0 |1 is obsolete| | --- Comment #18 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 83672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83672&action=edit Bug 20000: Use Modern::Perl in installer scripts To test: Check that we are using Modern::Perl when strict *and* warnings were used before, and commented lines and FIXMEs have been removed from the rest, out of files listed below. data/mysql/backfill_statistics.pl data/mysql/labels_upgrade.pl data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl data/mysql/updatedatabase.pl externalmodules.pl html-template-to-template-toolkit.pl install.pl Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83672|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84671&action=edit Bug 20000: Use Modern::Perl in installer scripts To test: Check that we are using Modern::Perl when strict *and* warnings were used before, and commented lines and FIXMEs have been removed from the rest, out of files listed below. data/mysql/backfill_statistics.pl data/mysql/labels_upgrade.pl data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl data/mysql/updatedatabase.pl externalmodules.pl html-template-to-template-toolkit.pl install.pl Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice cleanup here, backporting to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Code cleanup which improves release notes| |the readability, and | |therefore reliability, of | |Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org