[Bug 26323] New: NOT_LOAN is hard-code in templates but many UNIMARC installs are using ETAT as authorized values category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Bug ID: 26323 Summary: NOT_LOAN is hard-code in templates but many UNIMARC installs are using ETAT as authorized values category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: didier.gautheron@biblibre.com Reporter: didier.gautheron@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Templates: intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt intranet-tmpl/prog/en/modules/circ/returns.tt intranet-tmpl/prog/en/modules/reserve/request.tt are assuming items.notforloan authorized values category is NOT_LOAN. It's not always true for UNIMARC. cf.: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt they should use items.notforloan mapping -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Status|NEW |ASSIGNED Assignee|didier.gautheron@biblibre.c |jonathan.druart@bugs.koha-c |om |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org Summary|NOT_LOAN is hard-code in |Not_for_loan, damaged, |templates but many UNIMARC |location and ccode values |installs are using ETAT as |must be retrieved from the |authorized values category |correct AV category --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looks like this is also needed for LOC, DAMAGED, LOC and CCODE. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
From the template we are assuming that items.notforloan is mapped with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109627&action=edit Bug 26323: Retrieve the correct NOT_LOAN value the NOT_LOAN authorised value category, but that is not necessarily the case. We must retrieve the correct AV category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109628&action=edit Bug 26323: Retrieve the correct values for LOC, DAMAGED, LOC and CCODE Same as previously -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This will be tricky to test, that's why I hadn't provided a test plan. You should test some of the modified occurrences and confirmed it displays the correct value. Also read the diff and search for typos! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- All our documentation lists the authorised values, they are used in the default frameworks you are not supposed to change etc. Do we really need to support that they can be anything? I think we would make developer's and support staff's life easier if we kept expecting specific codes. Even with this patch, we will still do that in a lot of other places where there is no mapping table for lookup (TERM, SUGG, etc.) My first thought here would actually be to fix the ETAT ones to be NOT_LOAN instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #5)
All our documentation lists the authorised values, they are used in the default frameworks you are not supposed to change etc. Do we really need to support that they can be anything? I think we would make developer's and support staff's life easier if we kept expecting specific codes. Even with this patch, we will still do that in a lot of other places where there is no mapping table for lookup (TERM, SUGG, etc.)
Yes but TERM, SUGG, etc. are not linked with a DB fields. That's not the same problematic. The UI let you modify it, so I think we should go toward supporting it. And this second patch goes to this direction. Also it seems that we should remove the ability to edit the AV mapping for non default frameworks (but that's definitely out of the scope here).
My first thought here would actually be to fix the ETAT ones to be NOT_LOAN instead.
Ok but the patch is written already :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #7 from didier <didier.gautheron@biblibre.com> --- (In reply to Jonathan Druart from comment #3)
Created attachment 109628 [details] [review] Bug 26323: Retrieve the correct values for LOC, DAMAGED, LOC and CCODE
Same as previously
Hi I'm not sure about the one LOC, CCODE and co aren't hard code in template only they are in perl code too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #3)
Created attachment 109628 [details] [review] Bug 26323: Retrieve the correct values for LOC, DAMAGED, LOC and CCODE
Same as previously
You mean "for LOST, DAMAGED, LOC and CCODE" ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to didier from comment #7)
(In reply to Jonathan Druart from comment #3)
Created attachment 109628 [details] [review] [review] Bug 26323: Retrieve the correct values for LOC, DAMAGED, LOC and CCODE
Same as previously
Hi I'm not sure about the one LOC, CCODE and co aren't hard code in template only they are in perl code too.
As I said previously, it's a move toward the right direction IMO. It does not mean to fix all the occurrences (but does fix all the occurrences in the templates). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109628|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109693&action=edit Bug 26323: Retrieve the correct values for LOST, DAMAGED, LOC and CCODE Same as previously -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26424 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #5)
All our documentation lists the authorised values, they are used in the default frameworks you are not supposed to change etc. Do we really need to support that they can be anything? I think we would make developer's and support staff's life easier if we kept expecting specific codes. Even with this patch, we will still do that in a lot of other places where there is no mapping table for lookup (TERM, SUGG, etc.)
Replacing hardcoded values is normally the right thing to do. But I may understand your point. Think that we can still refer to specific codes as they are the values loaded by the default setup. Someone who changes the authorised values and kohafield mappings, should know what they do. That said, I dont see why we should not move on this path. (Knowing that we will be on the road for some time ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not going to block this - I am still going to discourage libraries to use their own whenever asked tho :) -- You are receiving this mail because: You are watching all bug changes.
From the template we are assuming that items.notforloan is mapped with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109627|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110767&action=edit Bug 26323: Retrieve the correct NOT_LOAN value the NOT_LOAN authorised value category, but that is not necessarily the case. We must retrieve the correct AV category Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109693|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110768&action=edit Bug 26323: Retrieve the correct values for LOST, DAMAGED, LOC and CCODE Same as previously Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110769&action=edit Bug 26323: (follow-up) Add new cases introduced Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as expected to me.. Signing off. Query: Do the hard coded CASE values in intranet-tmpl/prog/en/modules/admin/authorised_values.tt need any handling.. I couldn't make up my mind. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
From the template we are assuming that items.notforloan is mapped with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110767|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110789&action=edit Bug 26323: Retrieve the correct NOT_LOAN value the NOT_LOAN authorised value category, but that is not necessarily the case. We must retrieve the correct AV category Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110768|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110790&action=edit Bug 26323: Retrieve the correct values for LOST, DAMAGED, LOC and CCODE Same as previously Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110769|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110791&action=edit Bug 26323: (follow-up) Add new cases introduced Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110792&action=edit Bug 26323: (QA follow-up) Fix syntax errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21883 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18170 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 [Bug 21883] Show authorized value description for withdrawn in check-in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23912 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- doesnt apply clean to 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27038 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27038 [Bug 27038] Error when viewing a course reserve that has one or more items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22352 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352 [Bug 22352] Items location not shown correctly in email sent lists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org