[Bug 7466] New: Cart notification popup should appear onscreen even when button is offscreen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7466 Bug #: 7466 Summary: Cart notification popup should appear onscreen even when button is offscreen Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: koha.sekjal@gmail.com If one is adding to the cart using links in the search results page it is possible to be adding to the cart when the page has scrolled down so far that the cart button is off screen. The cart notification popup ("This item has been added to your cart"), being fixed to the cart button, will not be visible. Instead the cart notification popup should take the page scroll into account and always appear onscreen. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7466 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2012-01-24 20:52:16 UTC --- Created attachment 7326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7326 Proposed fix This patch compares the scroll position of the window with the page position of the cart button and displays the cart notification popup at the top of the visible page if the cart button has moved offscreen. Includes fix for OPAC and staff client. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7466 Aleksa <aleksa@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7326|0 |1 is obsolete| | Status|Needs Signoff |Signed Off AssignedTo|oleonard@myacpl.org |aleksa@catalyst.net.nz --- Comment #2 from Aleksa <aleksa@catalyst.net.nz> 2012-01-31 03:37:53 UTC --- Created attachment 7397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7397 [SIGNED-OFF] 7326: Proposed fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|aleksa@vujicic.com |oleonard@myacpl.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7466 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-03 16:36:30 UTC --- QA comment: tiny patch, nothing specific to say i've tested scrolling down & up, the popup always appear at the right place -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7466 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org