[Bug 31550] New: WS ILSDI opac description for some item fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Bug ID: 31550 Summary: WS ILSDI opac description for some item fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org It may be useful to get the opac description on the ILSDI web service with a specific suffix for some item fields. In relation to bug 25650, this is to add 'ccode', 'permanent_location', 'notforloan', 'itemlost', 'withdrawn', 'damaged' and 'restricted'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25650 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #1 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 140431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140431&action=edit Bug 31552: Add fields to get opac description on ILSDI web service Test plan 1) Active your ILS-DI syspref 2) Have some authorised values linked to one or more concern fields 3) Choose an item and go to 'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=<itemId>' 4) The XML file contains item fields with some of them the code associated to the authorized values. 5) Apply this patch 6) Repeat step 3 and see the new fields with specific "_description" suffix added and contains opac description from authorized values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #2 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Comment on attachment 140431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140431 Bug 31552: Add fields to get opac description on ILSDI web service
From e618b742c79ba17b4418685c229e27dd1de244c0 Mon Sep 17 00:00:00 2001 From: Thibaud Guillot <thibaud.guillot@biblibre.com> Date: Mon, 12 Sep 2022 11:04:07 +0200 Subject: [PATCH] Bug 31550: Add fields to get opac description on ILSDI web service
Test plan
1) Active your ILS-DI syspref 2) Have some authorised values linked to one or more concern fields 3) Choose an item and go to 'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=<itemId>' 4) The XML file contains item fields with some of them the code associated to the authorized values. 5) Apply this patch 6) Repeat step 3 and see the new fields with specific "_description" suffix added and contains opac description from authorized values
https://bugs.koha-community.org/show_bug.cgi?id=31550 --- C4/ILSDI/Services.pm | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm index f6bf6bcc14..b8e23c4a5b 100644 --- a/C4/ILSDI/Services.pm +++ b/C4/ILSDI/Services.pm @@ -253,10 +253,15 @@ sub GetRecords { $item{'homebranchname'} = $home_library ? $home_library->branchname : ''; $item{'holdingbranchname'} = $holding_library ? $holding_library->branchname : '';
- if ($item->location) { - my $authorised_value = Koha::AuthorisedValues->find_by_koha_field({ kohafield => 'items.location', authorised_value => $item->location }); - if ($authorised_value) { - $item{location_description} = $authorised_value->opac_description; + my @item_fields_description = ( 'location', 'ccode', 'permanent_location', 'notforloan', 'itemlost', 'withdrawn', 'damaged', 'restricted' ); + + foreach (@item_fields_description) { + + if ( $item->$_ ) { + my $authorised_value = Koha::AuthorisedValues->find_by_koha_field( { kohafield => 'items.' . $_, authorised_value => $item->$_ } ); + if ($authorised_value) { + $item{ $_ . _description } = $authorised_value->opac_description; + } } }
-- 2.25.1
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140431|0 |1 is obsolete| | --- Comment #3 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 140432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140432&action=edit Bug 31550: Add fields to get opac description on ILSDI web service Test plan 1) Active your ILS-DI syspref 2) Have some authorised values linked to one or more concern fields 3) Choose an item and go to 'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=<itemId>' 4) The XML file contains item fields with some of them the code associated to the authorized values. 5) Apply this patch 6) Repeat step 3 and see the new fields with specific "_description" suffix added and contains opac description from authorized values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I'm getting this error after applying the patch (using koha-testing-docker - flush_memcached, restart_all, and browser cached cleared after patch applied): Could not compile /kohadevbox/koha/opac/ilsdi.pl: Attempt to reload C4/ILSDI/Services.pm aborted. Compilation failed in require at /kohadevbox/koha/opac/ilsdi.pl line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/opac/ilsdi.pl line 22. at /usr/share/perl5/CGI/Compile.pm line 144 in CGI::Compile::compile at /usr/share/perl5/CGI/Compile.pm line 144 141: my $code = $self->_eval($eval); 142: my $exception = $@; 143: 144: die "Could not compile $script: $exception" if $exception; 145: 146: subname "${package}::$subname", sub { 147: my @args = @_; Show function arguments .... Testing notes: 1. Added OPAC descriptions for CCODE authorised values. 2. Tested with sample data using: http://127.0.0.1:8081/cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=262 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|WS ILSDI opac description |ILSDI: Add OPAC description |for some item fields |for some item fields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILSDI: Add OPAC description |ILS-DI: Add OPAC |for some item fields |description for some item | |fields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #5 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to David Nind from comment #4)
I'm getting this error after applying the patch (using koha-testing-docker - flush_memcached, restart_all, and browser cached cleared after patch applied):
Could not compile /kohadevbox/koha/opac/ilsdi.pl: Attempt to reload C4/ILSDI/Services.pm aborted. Compilation failed in require at /kohadevbox/koha/opac/ilsdi.pl line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/opac/ilsdi.pl line 22. at /usr/share/perl5/CGI/Compile.pm line 144
in CGI::Compile::compile at /usr/share/perl5/CGI/Compile.pm line 144
141: my $code = $self->_eval($eval); 142: my $exception = $@; 143: 144: die "Could not compile $script: $exception" if $exception; 145: 146: subname "${package}::$subname", sub { 147: my @args = @_;
Show function arguments ....
Testing notes: 1. Added OPAC descriptions for CCODE authorised values. 2. Tested with sample data using: http://127.0.0.1:8081/cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=262
Thanks for your feeback, I restart from zero, apply this patch but I can't reproduce the bug.. this apparently comes from the ILS-DI service so I will try later like you in kohadevbox to see if the problem still be. (Thanks for you link but it concern your localhost - 127.0.0.1 so I can see your record) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Anyone get the same error than David ? So I tested right now and it's working for me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #7 from David Nind <david@davidnind.com> --- Hi Thibaud. Apologies for not retesting sooner! I'm getting this error trace message now after applying the patch: Could not compile /kohadevbox/koha/opac/ilsdi.pl: Bareword "_description" not allowed while "strict subs" in use at /kohadevbox/koha/C4/ILSDI/Services.pm line 262. Compilation failed in require at /kohadevbox/koha/opac/ilsdi.pl line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/opac/ilsdi.pl line 22. at /usr/share/perl5/CGI/Compile.pm line 144 ... If I refresh the page again, I get this error trace message: Could not compile /kohadevbox/koha/opac/ilsdi.pl: Attempt to reload C4/ILSDI/Services.pm aborted. Compilation failed in require at /kohadevbox/koha/opac/ilsdi.pl line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/opac/ilsdi.pl line 22. at /usr/share/perl5/CGI/Compile.pm line 144 ... Maybe this is because koha-testing-docker is using strict mode for the database? (I don't know enough about these things to offer an informed opinion....or how to disable struct mode). David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #8 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 144979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144979&action=edit Bug 31550: (follow-up) fix bareword issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #9 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to David Nind from comment #7)
Hi Thibaud.
Apologies for not retesting sooner!
I'm getting this error trace message now after applying the patch:
Could not compile /kohadevbox/koha/opac/ilsdi.pl: Bareword "_description" not allowed while "strict subs" in use at /kohadevbox/koha/C4/ILSDI/Services.pm line 262. Compilation failed in require at /kohadevbox/koha/opac/ilsdi.pl line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/opac/ilsdi.pl line 22. at /usr/share/perl5/CGI/Compile.pm line 144 ...
If I refresh the page again, I get this error trace message:
Could not compile /kohadevbox/koha/opac/ilsdi.pl: Attempt to reload C4/ILSDI/Services.pm aborted. Compilation failed in require at /kohadevbox/koha/opac/ilsdi.pl line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/opac/ilsdi.pl line 22. at /usr/share/perl5/CGI/Compile.pm line 144 ...
Maybe this is because koha-testing-docker is using strict mode for the database? (I don't know enough about these things to offer an informed opinion....or how to disable struct mode).
David
Now it will be better I think ;) Thanks for your feedback again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140432|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 145041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145041&action=edit Bug 31550: Add fields to get opac description on ILSDI web service Test plan 1) Active your ILS-DI syspref 2) Have some authorised values linked to one or more concern fields 3) Choose an item and go to 'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=<itemId>' 4) The XML file contains item fields with some of them the code associated to the authorized values. 5) Apply this patch 6) Repeat step 3 and see the new fields with specific "_description" suffix added and contains opac description from authorized values https://bugs.koha-community.org/show_bug.cgi?id=31550 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144979|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 145042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145042&action=edit Bug 31550: (follow-up) fix bareword issue Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #12 from David Nind <david@davidnind.com> --- (In reply to Thibaud Guillot from comment #9)
Now it will be better I think ;) Thanks for your feedback again
Thanks Thibaud! Now signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please add unit tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145041|0 |1 is obsolete| | Attachment #145042|0 |1 is obsolete| | --- Comment #14 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 154370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154370&action=edit Bug 31550: (follow-up) fix bareword issue Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #15 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 154371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154371&action=edit Bug 31550: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #16 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 154372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154372&action=edit Bug 31550: Add fields to get opac description on ILSDI web service Test plan 1) Active your ILS-DI syspref 2) Have some authorised values linked to one or more concern fields 3) Choose an item and go to 'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=<itemId>' 4) The XML file contains item fields with some of them the code associated to the authorized values. 5) Apply this patch 6) Repeat step 3 and see the new fields with specific "_description" suffix added and contains opac description from authorized values https://bugs.koha-community.org/show_bug.cgi?id=31550 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154370|0 |1 is obsolete| | --- Comment #17 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 154373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154373&action=edit Bug 31550: (follow-up) fix bareword issue Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154371|0 |1 is obsolete| | --- Comment #18 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 154374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154374&action=edit Bug 31550: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154372|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 154858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154858&action=edit Bug 31550: Add fields to get opac description on ILSDI web service Test plan 1) Active your ILS-DI syspref 2) Have some authorised values linked to one or more concern fields 3) Choose an item and go to 'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=<itemId>' 4) The XML file contains item fields with some of them the code associated to the authorized values. 5) Apply this patch 6) Repeat step 3 and see the new fields with specific "_description" suffix added and contains opac description from authorized values https://bugs.koha-community.org/show_bug.cgi?id=31550 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154373|0 |1 is obsolete| | --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 154859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154859&action=edit Bug 31550: (follow-up) fix bareword issue Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154374|0 |1 is obsolete| | --- Comment #21 from David Nind <david@davidnind.com> --- Created attachment 154860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154860&action=edit Bug 31550: Add unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |OPAC descriptions for some | |item fields to the XML | |returned from ILS-DI | |requests. This includes | |these fields: location, | |ccode, permanent_location, | |notforloan, itemlost, | |withdrawn, damaged, and | |restricted. The OPAC | |descriptions have | |_description added to the | |item field name, for | |example: | |<ccode_description>Referenc | |e (OPAC | |description)</ccode_descrip | |tion>. --- Comment #22 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Added OPAC descriptions for CCODE authorised values. 2. Tested with sample data using: http://127.0.0.1:8081/cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=262 3. Before patch, there is only the CCODE in the returned XML, for example: <ccode>REF</ccode>. 4. After the patch, the CCODE OPAC description is also now included in the returned XML, for example: <ccode_description>Reference (OPAC description)</ccode_description> 5. Ran tests and these passed: prove t/db_dependent/AuthorisedValues.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com, | |tomascohen@gmail.com Status|Signed Off |Failed QA --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- I think at a minimum you want to use: get_description_by_koha_field that routine is cached so will avoid extra lookups. Possibly you could use 'strings_map' as the API does to expand the values - pinging RM fro opinion on that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'd use strings_map() as Nick suggests. It is supposed to return a stable data structure with enough information to know where things come from and how to handle it. Plus, it uses the methods Nick mentions are cached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154858|0 |1 is obsolete| | Attachment #154859|0 |1 is obsolete| | Attachment #154860|0 |1 is obsolete| | --- Comment #25 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 188560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188560&action=edit Bug 31550: Add fields to get opac description on ILSDI web service Test plan 1) Active your ILS-DI syspref 2) Have some authorised values linked to one or more concern fields 3) Choose an item and go to 'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=<itemId>' 4) The XML file contains item fields with some of them the code associated to the authorized values. 5) Apply this patch 6) Repeat step 3 and see the new fields with specific "_description" suffix added and contains opac description from authorized values Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #26 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Hello, Thank you for your comments. I rebased the patch and used strings_map. This is a rewrite, so I deleted David's SO to request a new one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188560|0 |1 is obsolete| | --- Comment #27 from David Nind <david@davidnind.com> --- Created attachment 188702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188702&action=edit Bug 31550: Add fields to get opac description on ILSDI web service Test plan 1) Active your ILS-DI syspref 2) Have some authorised values linked to one or more concern fields 3) Choose an item and go to 'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=<itemId>' 4) The XML file contains item fields with some of them the code associated to the authorized values. 5) Apply this patch 6) Repeat step 3 and see the new fields with specific "_description" suffix added and contains opac description from authorized values Sponsored-by: BibLibre Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds the |This enhancement adds the release notes|OPAC descriptions for some |OPAC descriptions for some |item fields to the XML |item fields to the XML |returned from ILS-DI |returned from ILS-DI |requests. This includes |requests. This includes |these fields: location, |these fields: location, |ccode, permanent_location, |ccode, permanent_location, |notforloan, itemlost, |notforloan, itemlost, |withdrawn, damaged, and |withdrawn, damaged, and |restricted. The OPAC |restricted. The OPAC |descriptions have |descriptions have |_description added to the |_description added to the |item field name, for |item field name, for |example: |example: |<ccode_description>Referenc |<ccode_description>Referenc |e (OPAC |e</ccode_description>. |description)</ccode_descrip | |tion>. | --- Comment #28 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. For <itemId> in the request URL, I used the biblionumber. 2. Example URL: http://127.0.0.1:8081/cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=262 (Programming Perl) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |lucas@bywatersolutions.com --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- These files are not tidy: Result: [FAIL] C4/ILSDI/Services.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl C4/ILSDI/Services.pm` [FAIL] t/db_dependent/AuthorisedValues.t FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl t/db_dependent/AuthorisedValues.t` -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org