[Bug 28146] New: admin variable should be replaced by KohaAdminEmailAddress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 Bug ID: 28146 Summary: admin variable should be replaced by KohaAdminEmailAddress Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org "admin" is sent from C4::Output::output_error, we should use Koha.Preference('KohaAdminEmailAddress') from the template instead koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc: [% IF ( admin ) %] koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt: <li>To report a broken link or any other issue, please contact the Koha Administrator. <a href="mailto:[% admin | uri %]">Send email</a></li> koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt: <a href="mailto:[% admin | uri %]">Send email</a>.</li> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt: <li>To report this error, you can email the Koha Administrator.<a href="mailto:[% admin | uri %]">Email</a></li> C4/Output.pm: admin => $admin, errors/400.pl: admin => $admin, errors/401.pl: admin => $admin, errors/402.pl: admin => $admin, errors/403.pl: admin => $admin, errors/404.pl: admin => $admin, errors/500.pl: admin => $admin, opac/errors/400.pl: admin => $admin, opac/errors/401.pl: admin => $admin, opac/errors/402.pl: admin => $admin, opac/errors/403.pl: admin => $admin, opac/errors/404.pl: admin => $admin, opac/errors/500.pl: admin => $admin, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please also prefer ReplyToDefault here with a fallback to KohaAdminEmailAddress. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|admin variable should be |E-mail address used on |replaced by |error pages should respect |KohaAdminEmailAddress |ReplyToDefault --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We now have: my $admin = C4::Context->preference('KohaAdminEmailAddress'); But: In some cases this will be a noreply-address. We should be using inbound_email_address or at least prefer ReplyToDefault. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 187463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187463&action=edit Bug 28146: Respect ReplytoDefault in error pages Test plan: Fill ReplytoDefault. Check an error page on OPAC and intranet. Verify that the send mail link refers to that email address. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Summary|E-mail address used on |E-mail address used on |error pages should respect |error pages should respect |ReplyToDefault |ReplytoDefault -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Templates |and plumbing | Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Trivial patch. Self signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187463|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187654&action=edit Bug 28146: Respect ReplytoDefault in error pages Test plan: Fill ReplytoDefault. Check an error page on OPAC and intranet. Verify that the send mail link refers to that email address. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting Version(s)|25.11.00 |25.11.00, 25.05.x released in| | CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This change has been backported to the 25.05.x branch. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28146 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00, 25.05.x |25.11.00,25.05.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org