https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143178&action=edit Bug 32109: Fix spacing in toolbars containing text links This patch adds a new class to toolbars in certain contexts: Where the toolbar contains only text links (as opposed to Bootstrap-styled controls). This lets us set some comfortable padding on the links. To test, apply the patch and rebuild the staff interface CSS. Test the following pages to confirm that the toolbar of selection links ("Select all," "Clear all," etc.) has legible spacing. - Cataloging -> Batch item modification -> List of submitted barcodes - Cataloging -> Batch item deletion -> List of submitted barcodes - Cataloging -> Batch record modification -> List of submitted records - Cataloging -> Batch record deletion -> List of submitted records - Tools -> Batch extend due dates -> Preview results - Tools -> Batch patron modification -> List of submitted patrons -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I see.. this is another place we're a little inconsistent with how we mark up a 'toolbar'. On 'Opac problem reports' and 'checkout notes' there are similar "toolbars" for filtering the datatable... they have the following marking <fieldset class="action" style="cursor:pointer;"> Should we try to synchronize the markup of those two 'filter bars' too here? Challenge with this is that on those two pages there are also already <div id="toolbar"> blocks on the page too. I feel like an id of toolbar is wrong.. it should likely be a class instead.? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Signing off.. happy to see a follow-up here to make the other two cases I identified match the markup.. or we could submit another bug for that.. I'll defer that decision to the RM/QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I reworked this so that all instances of the "selections-toolbar" class also have the "btn-toolbar" class, and the "toolbar" ID is removed. The intention of this is to reserve the "toolbar" ID for the "main" toolbar on the page, the one containing the action buttons. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143837|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143858&action=edit Bug 32109: Fix spacing in toolbars containing text links This patch adds a new class to toolbars in certain contexts: Where the toolbar contains only text links (as opposed to Bootstrap-styled controls). This lets us set some comfortable padding on the links. To test, apply the patch and rebuild the staff interface CSS. Test the following pages to confirm that the toolbar of selection links ("Select all," "Clear all," etc.) has legible spacing. - Cataloging -> Batch item modification -> List of submitted barcodes - Cataloging -> Batch item deletion -> List of submitted barcodes - Cataloging -> Batch record modification -> List of submitted records - Cataloging -> Batch record deletion -> List of submitted records - Circulation -> Checkout notes - Tools -> Batch extend due dates -> Preview results - Tools -> Batch patron modification -> List of submitted patrons - Tools -> OPAC problem reports Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143858|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143890&action=edit Bug 32109: Fix spacing in toolbars containing text links This patch adds a new class to toolbars in certain contexts: Where the toolbar contains only text links (as opposed to Bootstrap-styled controls). This lets us set some comfortable padding on the links. To test, apply the patch and rebuild the staff interface CSS. Test the following pages to confirm that the toolbar of selection links ("Select all," "Clear all," etc.) has legible spacing. - Cataloging -> Batch item modification -> List of submitted barcodes - Cataloging -> Batch item deletion -> List of submitted barcodes - Cataloging -> Batch record modification -> List of submitted records - Cataloging -> Batch record deletion -> List of submitted records - Circulation -> Checkout notes - Tools -> Batch extend due dates -> Preview results - Tools -> Batch patron modification -> List of submitted patrons - Tools -> OPAC problem reports Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143890|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143957&action=edit Bug 32109: Fix spacing in toolbars containing text links This patch adds a new class to toolbars in certain contexts: Where the toolbar contains only text links (as opposed to Bootstrap-styled controls). This lets us set some comfortable padding on the links. To test, apply the patch and rebuild the staff interface CSS. Test the following pages to confirm that the toolbar of selection links ("Select all," "Clear all," etc.) has legible spacing. - Cataloging -> Batch item modification -> List of submitted barcodes - Cataloging -> Batch item deletion -> List of submitted barcodes - Cataloging -> Batch record modification -> List of submitted records - Cataloging -> Batch record deletion -> List of submitted records - Circulation -> Checkout notes - Tools -> Batch extend due dates -> Preview results - Tools -> Batch patron modification -> List of submitted patrons - Tools -> OPAC problem reports Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.