https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17031 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70421|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 70422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70422&action=edit Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" Bonus fixes: - Basketgroup: there was an unnecessary space. " RRP tax excluded" replaced by "RRP tax excluded" - Late orders: - leading spaces before every line - surrounding spaces for [% orders.size %] Other changes: - quoted "Total orders in late" to no worry about additional spaces - Late orders: additional spaces which shouldn't be a problem because all the fields are enclosed by quotes. Test plan: 1. Set syspref "delimiter" to "#'s" 2. Change the language e.g. FR-fr 3. Create a vendor with minimal info 4. Create a basket with two items 5. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX 6. Close this basket 7. "Export as CSV" 8. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 9. Create a basket group with two baskets (tick the close this basket group check box) 10. Go to the "Closed" tab to see your basket group 11. "Export as CSV" 12. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 13. Go to /cgi-bin/koha/acqui/lateorders.pl 14. Tick two orders. Of the same vendor, otherwise Koha won't let you tick orders of different vendors. 15. "Export as CSV" 16. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 17. Apply this patch 18. Translation stuff 1. cd misc/translator 2. perl translate update YOUR_LANG 3. manually edit the po file, remove the fuzzy tags. And translate the string. You can just copy the original and replace some parts by gibberish. 4. perl translate install YOUR_LANG 19. Re-export the same CSVs and compare with the original version to check that - delimiter syspref is honored - the headers are translatable - there is no whitespace regression (additional newlines or spaces) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- About your patches, it should not be needed but it is the behaviour of other occurrences: you do not default to ';', ',' or '\t' if the pref 'delimiter' does not exist. Maybe ',' is better here as it was the value before your changes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #9 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- "," is now used by default if the syspref is missing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #11 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- (In reply to M. Tompsett from comment #10)

basket.tt and basketgroup.tt aren't [%- delimiter -%]. I believe the hyphens are important to the formatting of the file. Please correct.

I remember removing the post/pre-chomp after having checked that the output was still correct. Is there another caveat? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please check that the translated export still works nicely after this change. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #14)

Please check that the translated export still works nicely after this change.

That's his test plan in comment #8. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #18 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #17)

It's missing steps.

- you need to update the po files after the patch was applied - you have to check that the string got not marked as 'fuzzy' - you have to reinstall the language

Only then the test gives you a correct result.

So in short, the test plan in comment #8 combined with this should work. However, this is still Failed QA for not passing the koha qa test tools. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #20 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Tested also with current master without error. commit 129ffee791da9f8ab4ad85a4473a138fc81ccbef Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Date: Mon Jan 15 10:10:41 2018 -0300 Bug 19968: Add missing use Date::Calc statement -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #22 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Victor Grousset/tuxayo from comment #19)

(In reply to M. Tompsett from comment #13)

...

Failed QA test tools.

It passed for me. Did I make any mistake?

Nope. It would seem I did. It passed after: sudo koha-shell -c bash kohadev ~vagrant/qa-test-tools/koha-qa.pl -v 2 -c 1 But running it from vagrant directly does not exit qa -v 2 -c 1 As for comment #21, I will leave QA to pass or fail it. I'm signing off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70426|0 |1 is obsolete| | --- Comment #23 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 70698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70698&action=edit Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" Bonus fixes: - Basketgroup: there was an unnecessary space. " RRP tax excluded" replaced by "RRP tax excluded" - Late orders: - leading spaces before every line - surrounding spaces for [% orders.size %] Other changes: - quoted "Total orders in late" to no worry about additional spaces - Late orders: additional spaces which shouldn't be a problem because all the fields are enclosed by quotes. Test plan: 1. Set syspref "delimiter" to "#'s" 2. Change the language e.g. FR-fr 3. Create a vendor with minimal info 4. Create a basket with two items 5. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX 6. Close this basket 7. "Export as CSV" 8. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 9. Create a basket group with two baskets (tick the close this basket group check box) 10. Go to the "Closed" tab to see your basket group 11. "Export as CSV" 12. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 13. Go to /cgi-bin/koha/acqui/lateorders.pl 14. Tick two orders. Of the same vendor, otherwise Koha won't let you tick orders of different vendors. 15. "Export as CSV" 16. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 17. Apply this patch 18. Translation stuff 1. cd misc/translator 2. perl translate update YOUR_LANG 3. manually edit the po file, remove the fuzzy tags. And translate the string. You can just copy the original and replace some parts by gibberish. 4. perl translate install YOUR_LANG 19. Re-export the same CSVs and compare with the original version to check that - delimiter syspref is honored - the headers are translatable - there is no whitespace regression (additional newlines or spaces) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |In Discussion --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- This works as advertised, however see bug 19910 If we are going to honor the delimiter pref, I think we need to use it in displaying what format will be downloaded. Want another QA opinion here -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70698|0 |1 is obsolete| | --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70750&action=edit Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" Bonus fixes: - Basketgroup: there was an unnecessary space. " RRP tax excluded" replaced by "RRP tax excluded" - Late orders: - leading spaces before every line - surrounding spaces for [% orders.size %] Other changes: - quoted "Total orders in late" to no worry about additional spaces - Late orders: additional spaces which shouldn't be a problem because all the fields are enclosed by quotes. Test plan: 1. Set syspref "delimiter" to "#'s" 2. Change the language e.g. FR-fr 3. Create a vendor with minimal info 4. Create a basket with two items 5. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX 6. Close this basket 7. "Export as CSV" 8. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 9. Create a basket group with two baskets (tick the close this basket group check box) 10. Go to the "Closed" tab to see your basket group 11. "Export as CSV" 12. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 13. Go to /cgi-bin/koha/acqui/lateorders.pl 14. Tick two orders. Of the same vendor, otherwise Koha won't let you tick orders of different vendors. 15. "Export as CSV" 16. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 17. Apply this patch 18. Translation stuff 1. cd misc/translator 2. perl translate update YOUR_LANG 3. manually edit the po file, remove the fuzzy tags. And translate the string. You can just copy the original and replace some parts by gibberish. 4. perl translate install YOUR_LANG 19. Re-export the same CSVs and compare with the original version to check that - delimiter syspref is honored - the headers are translatable - there is no whitespace regression (additional newlines or spaces) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED QA Contact|nick@bywatersolutions.com |testopia@bugs.koha-communit | |y.org --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #25)

This works as advertised, however see bug 19910

If we are going to honor the delimiter pref, I think we need to use it in displaying what format will be downloaded.

Want another QA opinion here

Agreed, please see the changes made on bug 19910 and add the info here too. You can then switch back to Signed Off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #29 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 71105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71105&action=edit Screenshot of new buttons Here are how the new buttons looks. I choose values of the syspref that lead to the biggest text in the button to see it it's an issue. The strings are translatable, here is how it looks in the .po files. msgid "" "%s %s %s %s %s %s %s pound (#) separated text (.csv) %s comma separated text " "(.csv) %s slash separated text (.csv) %s semicolon separated text (.csv) %s " "backslash separated text (.csv) %s tab separated text (.csv) %s %s %s " msgid "" "%s %s %s %s %s %s %s pound (#) separated text (.csv) %s comma separated text " "(.csv) %s slash separated text (.csv) %s semicolon separated text (.csv) %s " "backslash separated text (.csv) %s tab separated text (.csv) %s %s %s " msgid "" "Export as %s %s pound (#) separated text (.csv) %s comma separated text (." "csv) %s slash separated text (.csv) %s semicolon separated text (.csv) %s " "backslash separated text (.csv) %s tab separated text (.csv) %s " -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen, could you take a look at the screenshots please? Bit worried they might get even longer with translations. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70750|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71271&action=edit Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" Bonus fixes: - Basketgroup: there was an unnecessary space. " RRP tax excluded" replaced by "RRP tax excluded" - Late orders: - leading spaces before every line - surrounding spaces for [% orders.size %] Other changes: - quoted "Total orders in late" to no worry about additional spaces - Late orders: additional spaces which shouldn't be a problem because all the fields are enclosed by quotes. Test plan: 1. Set syspref "delimiter" to "#'s" 2. Change the language e.g. FR-fr 3. Create a vendor with minimal info 4. Create a basket with two items 5. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX 6. Close this basket 7. "Export as CSV" 8. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 9. Create a basket group with two baskets (tick the close this basket group check box) 10. Go to the "Closed" tab to see your basket group 11. "Export as CSV" 12. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 13. Go to /cgi-bin/koha/acqui/lateorders.pl 14. Tick two orders. Of the same vendor, otherwise Koha won't let you tick orders of different vendors. 15. "Export as CSV" 16. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 17. Apply this patch 18. Translation stuff 1. cd misc/translator 2. perl translate update YOUR_LANG 3. manually edit the po file, remove the fuzzy tags. And translate the string. You can just copy the original and replace some parts by gibberish. 4. perl translate install YOUR_LANG 19. Re-export the same CSVs and compare with the original version to check that - delimiter syspref is honored - the headers are translatable - there is no whitespace regression (additional newlines or spaces) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- I think "CSV" is commonly understood to include more than just comma-separated values. Is it really necessary to be so specific? For instance, an application like phpMyAdmin offers export in "CSV" format, but it doesn't limit you to comma-separated output. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for your comment, Owen! My suggestion is to keep the current descriptions then and make sure the delimiter is used properly everywhere :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #37 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- (In reply to Katrin Fischer from comment #31)

The only thing I am not happy about it the length of the buttons I think Victor had similar thoughts on posting the screenshots.

Actually I would be fine with these long descriptive names. (and with short names) But I don't have much experience about UX. (To have a reliable opinion if it's better than shorter but less informative names.) However I'm sure many people won't think such long names are good. Hence the screenshots to not hide the potential issue. It seems that it worked ^^" (In reply to Owen Leonard from comment #34)

I think "CSV" is commonly understood to include more than just comma-separated values. Is it really necessary to be so specific? For instance, an application like phpMyAdmin offers export in "CSV" format, but it doesn't limit you to comma-separated output.

+1 it's not necessary (In reply to Katrin Fischer from comment #35)

My suggestion is to keep the current descriptions then and make sure the delimiter is used properly everywhere :)

Current as in master[1][3] or current are in the current patches[2][4] of this bug? If [2] then bug 19910 must be changed as well. [3] this is consistent with Owen's comment [4] this is consistent with you switching this bug to "Passed QA" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #40 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Thanks for the clarification. Yay this one finishes just in time as can start bug 20171 :D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71105|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.