[Bug 3522] New: Inconsistent behaviour in tools/notices
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3522 Summary: Inconsistent behaviour in tools/notices Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Tools AssignedTo: gmcharlt@gmail.com ReportedBy: colin.campbell@ptfs-europe.com Estimated Hours: 0.0 Change sponsored?: --- When selecting a notice to delete, it is being selected by code so if the code is being used in multiple modules the wrong notice may be selected. Looking at the script there seemed to be some inconsistency in how items from the letter table were being addressed. Patch to follow. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3522 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Priority|P5 |PATCH-Sent --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2009-08-11 16:50:52 --- Patch submitted. Refactored tools/letter.pl to clarify script's logic. Use subroutines to breakup flow for main logic. This also allowed to get rid of the calls to redirect to itself. A chunk of the script is basic db operations on the letter table. Will refactor these out to the appropriate module (where versions exist) in a separate patch. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3522 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> 2009-08-11 22:00:35 --- Pushed patch to HEAD. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3522 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (2)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com -
bugzilla-daemon＠liblime.com