[Bug 39711] New: Migrate C4::Contract to object classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Bug ID: 39711 Summary: Migrate C4::Contract to object classes Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org We should migrate this ahead of the new acquisitions work and because it is a relatively small module to migrate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 [Bug 38010] Migrate vendors to Vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181453&action=edit Bug 39711: Add koha objects for the aqcontract table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181454&action=edit Bug 39711: Update all calls to GetContracts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181455&action=edit Bug 39711: Update all calls to GetContract -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181456&action=edit Bug 39711: Update call to AddContract -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181457&action=edit Bug 39711: Update call to ModContract and improve error handling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181458&action=edit Bug 39711: Update call to DelContract -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181459&action=edit Bug 39711: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181460&action=edit Bug 39711: Delete old C4::Contract code and tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181460|0 |1 is obsolete| | --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181461&action=edit Bug 39711: Delete old C4::Contract code and tests Test plan: 1) prove t/db_dependent/Koha/Acquisition/* 2) Navigate to a vendor record and access the contracts area 3) Test all CRUD elements for the contracts section 4) Navigate to the baskets for the vendor 5) Test the available CRUD options for a basket 6) All pages should work as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181461|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181580&action=edit Bug 39711: Delete old C4::Contract code and tests Test plan: 1) prove t/db_dependent/Koha/Acquisition/* 2) Navigate to a vendor record and access the contracts area 3) Test all CRUD elements for the contracts section 4) Navigate to the baskets for the vendor 5) Test the available CRUD options for a basket 6) All pages should work as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #10)
Created attachment 181580 [details] [review] Bug 39711: Delete old C4::Contract code and tests
Simple rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181581&action=edit Bug 39711: Fix 500 when viewing a basket without contract Can't call method "contractname" on an undefined value at /kohadevbox/koha/acqui/basket.pl line 462. Use Koha::Acq::Basket->contract -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181582&action=edit Bug 39711: Remove ->store It's NOT NULL at the DB level, we don't need to deal with that constraint here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181583&action=edit Bug 39711: Fix 500 when creating a new order for a basket without contract -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181584&action=edit Bug 39711: Use ->contract for basketheader -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Found a bug, that is in main already. You cannot empty a contact when editing a basket. TODO later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Found another bug, in main as well: if you edit a basket that has an inactive contract, it does not appear in the dropdown list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181586&action=edit Bug 39711: (bugfix) Show contract of the basket if inactive If the contract is inactive it should be displayed on the basket edit view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181587&action=edit Bug 39711: Order by contract name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181588&action=edit Bug 39711: (bugfix) Allow to clear basket's contract -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39758, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39759 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #20)
Created attachment 181588 [details] [review] Bug 39711: (bugfix) Allow to clear basket's contract
Opened bug 39758 for stable releases. (In reply to Jonathan Druart from comment #18)
Created attachment 181586 [details] [review] Bug 39711: (bugfix) Show contract of the basket if inactive
If the contract is inactive it should be displayed on the basket edit view.
And bug 39759 for this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181453|0 |1 is obsolete| | --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189393&action=edit Bug 39711: Add koha objects for the aqcontract table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181454|0 |1 is obsolete| | --- Comment #23 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189394&action=edit Bug 39711: Update all calls to GetContracts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181455|0 |1 is obsolete| | --- Comment #24 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189395&action=edit Bug 39711: Update all calls to GetContract -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181456|0 |1 is obsolete| | --- Comment #25 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189396&action=edit Bug 39711: Update call to AddContract -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181457|0 |1 is obsolete| | --- Comment #26 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189397&action=edit Bug 39711: Update call to ModContract and improve error handling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181458|0 |1 is obsolete| | --- Comment #27 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189398&action=edit Bug 39711: Update call to DelContract -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181459|0 |1 is obsolete| | --- Comment #28 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189399&action=edit Bug 39711: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181580|0 |1 is obsolete| | --- Comment #29 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189400&action=edit Bug 39711: Delete old C4::Contract code and tests Test plan: 1) prove t/db_dependent/Koha/Acquisition/* 2) Navigate to a vendor record and access the contracts area 3) Test all CRUD elements for the contracts section 4) Navigate to the baskets for the vendor 5) Test the available CRUD options for a basket 6) All pages should work as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181581|0 |1 is obsolete| | --- Comment #30 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189401&action=edit Bug 39711: Fix 500 when viewing a basket without contract Can't call method "contractname" on an undefined value at /kohadevbox/koha/acqui/basket.pl line 462. Use Koha::Acq::Basket->contract -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181582|0 |1 is obsolete| | --- Comment #31 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189402&action=edit Bug 39711: Remove ->store It's NOT NULL at the DB level, we don't need to deal with that constraint here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181583|0 |1 is obsolete| | --- Comment #32 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189403&action=edit Bug 39711: Fix 500 when creating a new order for a basket without contract -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181584|0 |1 is obsolete| | --- Comment #33 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189404&action=edit Bug 39711: Use ->contract for basketheader -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181586|0 |1 is obsolete| | --- Comment #34 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189405&action=edit Bug 39711: (bugfix) Show contract of the basket if inactive If the contract is inactive it should be displayed on the basket edit view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181587|0 |1 is obsolete| | --- Comment #35 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189406&action=edit Bug 39711: Order by contract name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181588|0 |1 is obsolete| | --- Comment #36 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189407&action=edit Bug 39711: (bugfix) Allow to clear basket's contract -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch set currently no longer applies. I resolved the first conflict, but ran into more. @Matt Should we be moving this forward considering the current state of the Acq Refresh work? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org