https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18965 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18965 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 65161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65161&action=edit Bug 18965 - branch transfer limits pagination save bug In branch transfer limits, tables are paginated with 20 rows by default. The bug is that datatable not only hides rows, they are not in form. So when submitting form, rows not visible are erased. Test plan : Wihout patch : - Create 22 branches, you can hack the creation form by manualling calling URL : /cgi-bin/koha/admin/branches.pl?op=add_validate&branchcode=Bxx&branchname=Bxx - Go to Administration > Library transfer limits - You see table first page : only 20 first rows are shown - You see all checkboxes are checked - Go to second page of this table - Save => You see table first page with all checkboxes unchecked With patch the is no pagination, all checkboxes are shown when you save -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18965 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- On can still use search and when saving erase all rows. But its more difficult to correct. I think this page should be changed to show a big table with itemtype/ccode, branch and checkbox columns. With column filters to allow searching. And when a filter is used, Javascript code must disable the "Save" button. This whould also allow really (un)checking all checkboxes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18965 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Axelle Clarisse <axelle.clarisse@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18965 --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 65175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65175&action=edit Bug 18965 - branch transfer limits pagination save bug In branch transfer limits, tables are paginated with 20 rows by default. The bug is that datatable not only hides rows, they are not in form. So when submitting form, rows not visible are erased. Test plan : Wihout patch : - Create 22 branches, you can hack the creation form by manualling calling URL : /cgi-bin/koha/admin/branches.pl?op=add_validate&branchcode=Bxx&branchname=Bxx - Go to Administration > Library transfer limits - You see table first page : only 20 first rows are shown - You see all checkboxes are checked - Go to second page of this table - Save => You see table first page with all checkboxes unchecked With patch the is no pagination, all checkboxes are shown when you save Signed-off-by: Axelle Clarisse <axelle.clarisse@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18965 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18965 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.11. -- You are receiving this mail because: You are watching all bug changes.