[Bug 39658] New: Allow definition of non-hierarchical linked patron accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Bug ID: 39658 Summary: Allow definition of non-hierarchical linked patron accounts Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In a Koha system containing multiple functionally-autonomous libraries, one patron may have multiple distinct accounts within the same Koha system. These accounts represent distinct cards from distinct libraries and need their circulation rules enforced as such, so they can't be merged into one account. But no one of these accounts is "primary" and they all represent the same person, so guarantor/guarantee relationships are a poor conceptual fit (and may already be in use for their intended purpose). These linked/shared accounts would: - clearly link between each other in the Details of the patron record - optionally reciprocally enforce restrictions and blocks due to fines & fees (when one account is blocked, all are) - optionally allow checkout of on-hold items for shared accounts For that last item, assuming one patron has accounts card1 and card2. They have a hold ready for pickup on their card1 account. If Koha attempts to check the waiting item out to the card2 account, koha should check the item out on the card1 account, mark the hold complete, and give the user a clear on-screen message as to what happened. It should not ask for confirmation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Phillip Berg <phillip.berg@mainlib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phillip.berg@mainlib.org --- Comment #1 from Phillip Berg <phillip.berg@mainlib.org> --- Library patrons may qualify for different levels of library service in multiple library services areas. For example, one might live in one town, own a vacation property elsewhere, and work yet somewhere else. Each of those libraries have certain materials/services that they only allow local card-holders to access, thus why some people receive multiple cards. This is more prevalent in some cooperatives/consortia representing many tax districts, municipalities, and counties via a single instance of the ILS. The guarantee/guarantor function is great for family dynamics, but does not work for individuals who possess two, three, or more total library cards (each at different libraries). Choosing which library card in these situations should be the guarantor is awkward at best and politically charged at worst. We also don't want a situation where a patron tries to game the system by running up huge bills on each account without an auto-block coming into play. Having the ability to simply connect multiple patron accounts together to better manage that person's library privileges, usage, and restrictions is vital to keeping a harmonious relationship between libraries. This change would not remove or force any Koha libraries to abandon the guarantee/guarantor functionality. We just need to add another option. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Assignee|koha-bugs@lists.koha-commun |jacob.omara@openfifth.co.uk |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #2 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193344&action=edit Bug 39658: DB: Add patron_account_links table and sysprefs Patron Account Linking: Test Plan Setup: Enable all 3 sysprefs: EnablePatronAccountLinking = Enable, NoIssuesChargeLinkedAccounts = 10, AllowLinkedAccountHoldPickup = Allow. Linking: 1. Go to Koha's detail page (moremember.pl). Confirm the "Linked accounts" section appears. 2. Click "Add linked account", search for Henry, link him. Confirm Henry appears in the list. 3. Repeat to link Edna. Confirm both Henry and Edna are listed under Koha. 4. Go to Henry's detail page. Confirm Koha and Edna appear as linked accounts. 5. Test "Leave linked group" on Edna — confirm she is removed from all linked accounts. Checkout blocking (NoIssuesChargeLinkedAccounts): 6. Re-link Edna to the group. 7. Add fines across Koha, Henry, and Edna so the combined total exceeds 10. 8. Try checking out an item to any of them — confirm the linked account debt warning/block appears. 9. Reduce fines below 10 — confirm checkout proceeds without warning. Hold pickup (AllowLinkedAccountHoldPickup): 10. Place a hold for Koha on an available item. Check it in so it's waiting. 11. Check out that waiting item to Henry — confirm it succeeds and is issued to Koha automatically. 12. Disable AllowLinkedAccountHoldPickup. Repeat — confirm the redirect does not occur. Adds table and 3 sysprefs for patron account linking feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #3 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193345&action=edit Bug 39658: Add Koha::Patron::AccountLink(s) objects New objects to manage patron account links. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #4 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193346&action=edit Bug 39658: Add linked account methods to Koha::Patron Methods: account_link, linked_accounts, all_linked_borrowernumbers, linked_accounts_debt. Also adds charge limit checking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193347&action=edit Bug 39658: API: Add REST endpoints for patron account links Endpoints: GET/POST/DELETE /patrons/{id}/account_links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #6 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193348&action=edit Bug 39658: Circulation: Add linked account fee/hold checks DEBT_LINKED_ACCOUNTS blocker and LINKED_ACCOUNT_HOLD_PICKUP alert. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #7 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193349&action=edit Bug 39658: Circulation: Add linked account hold pickup redirect Enable linked patrons to pick up each other's holds when allowed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193350&action=edit Bug 39658: Circulation UI: Add linked account fee/hold messages Display warnings for combined debt and linked hold pickup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #9 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193351&action=edit Bug 39658: Patron detail: Pass linked accounts to template Add linked_accounts and link_group data for display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #10 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193352&action=edit Bug 39658: Patron detail UI: Add linked accounts section Display linked patrons with Add/Leave link group buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #11 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193353&action=edit Bug 39658: Admin: Add linked account system preferences UI Add prefs for EnablePatronAccountLinking and related settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #12 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193354&action=edit Bug 39658: Tests: Add unit tests for Koha::Patron::AccountLink Test linking, group management, and linked_accounts methods. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #13 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193355&action=edit Bug 39658: Tests: Add API tests for patron account links endpoints Test GET/POST/DELETE /api/v1/patrons/{id}/account_links. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #14 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193356&action=edit Bug 39658: Add Koha::Exceptions::PatronAccountLink Add typed exceptions for patron account linking: - AlreadyLinked: patrons already in same group - DifferentGroups: patrons in different groups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #15 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193357&action=edit Bug 39658: Add link_to_patron and linked_account_links methods - link_to_patron($other_patron): Links patrons, handles group logic - linked_account_links(): Returns all links in patron's group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #16 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193358&action=edit Bug 39658: DBIC schema - DO NOT PUSH Auto-generated schema for patron_account_links table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #17 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193359&action=edit Bug 39658: Schema: Add Koha object class mappings Map PatronAccountLink to Koha::Patron::AccountLink(s). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193344|0 |1 is obsolete| | --- Comment #18 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193462&action=edit Bug 39658: DB: Add patron_account_links table and sysprefs Adds table and 3 sysprefs for patron account linking feature. Setup: Enable all 3 sysprefs: EnablePatronAccountLinking = Enable, NoIssuesChargeLinkedAccounts = 10, AllowLinkedAccountHoldPickup = Allow. Linking: 1. Go to Koha's detail page (moremember.pl). Confirm the "Linked accounts" section appears. 2. Click "Add linked account", search for Henry, link him. Confirm Henry appears in the list. 3. Repeat to link Edna. Confirm both Henry and Edna are listed under Koha. 4. Go to Henry's detail page. Confirm Koha and Edna appear as linked accounts. 5. Test "Leave linked group" on Edna — confirm she is removed from all linked accounts. Checkout blocking (NoIssuesChargeLinkedAccounts): 6. Re-link Edna to the group. 7. Add fines across Koha, Henry, and Edna so the combined total exceeds 10. 8. Try checking out an item to any of them — confirm the linked account debt warning/block appears. 9. Reduce fines below 10 — confirm checkout proceeds without warning. Hold pickup (AllowLinkedAccountHoldPickup): 10. Place a hold for Koha on an available item. Check it in so it's waiting. 11. Check out that waiting item to Henry — confirm it succeeds and is issued to Koha automatically. 12. Disable AllowLinkedAccountHoldPickup. Repeat — confirm the redirect does not occur. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193345|0 |1 is obsolete| | --- Comment #19 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193463&action=edit Bug 39658: Add Koha::Patron::AccountLink(s) objects New objects to manage patron account links. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193346|0 |1 is obsolete| | --- Comment #20 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193464&action=edit Bug 39658: Add linked account methods to Koha::Patron Methods: account_link, linked_accounts, all_linked_borrowernumbers, linked_accounts_debt. Also adds charge limit checking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193347|0 |1 is obsolete| | --- Comment #21 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193465&action=edit Bug 39658: API: Add REST endpoints for patron account links Endpoints: GET/POST/DELETE /patrons/{id}/account_links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193348|0 |1 is obsolete| | --- Comment #22 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193466&action=edit Bug 39658: Circulation: Add linked account fee/hold checks DEBT_LINKED_ACCOUNTS blocker and LINKED_ACCOUNT_HOLD_PICKUP alert. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193349|0 |1 is obsolete| | --- Comment #23 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193467&action=edit Bug 39658: Circulation: Add linked account hold pickup redirect Enable linked patrons to pick up each other's holds when allowed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193350|0 |1 is obsolete| | --- Comment #24 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193468&action=edit Bug 39658: Circulation UI: Add linked account fee/hold messages Display warnings for combined debt and linked hold pickup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193351|0 |1 is obsolete| | --- Comment #25 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193469&action=edit Bug 39658: Patron detail: Pass linked accounts to template Add linked_accounts and link_group data for display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193352|0 |1 is obsolete| | --- Comment #26 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193470&action=edit Bug 39658: Patron detail UI: Add linked accounts section Display linked patrons with Add/Leave link group buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193353|0 |1 is obsolete| | --- Comment #27 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193471&action=edit Bug 39658: Admin: Add linked account system preferences UI Add prefs for EnablePatronAccountLinking and related settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193354|0 |1 is obsolete| | --- Comment #28 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193472&action=edit Bug 39658: Tests: Add unit tests for Koha::Patron::AccountLink Test linking, group management, and linked_accounts methods. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193355|0 |1 is obsolete| | --- Comment #29 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193473&action=edit Bug 39658: Tests: Add API tests for patron account links endpoints Test GET/POST/DELETE /api/v1/patrons/{id}/account_links. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193356|0 |1 is obsolete| | --- Comment #30 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193474&action=edit Bug 39658: Add Koha::Exceptions::PatronAccountLink Add typed exceptions for patron account linking: - AlreadyLinked: patrons already in same group - DifferentGroups: patrons in different groups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193357|0 |1 is obsolete| | --- Comment #31 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193475&action=edit Bug 39658: Add link_to_patron and linked_account_links methods - link_to_patron($other_patron): Links patrons, handles group logic - linked_account_links(): Returns all links in patron's group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193358|0 |1 is obsolete| | --- Comment #32 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193476&action=edit Bug 39658: DBIC schema - DO NOT PUSH Auto-generated schema for patron_account_links table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193359|0 |1 is obsolete| | --- Comment #33 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193477&action=edit Bug 39658: Schema: Add Koha object class mappings Map PatronAccountLink to Koha::Patron::AccountLink(s). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #34 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193478&action=edit Bug 39658: (follow-up) linked hold pickup all types Linked account hold pickup check now applies to all hold statuses (Reserved, Transferred, Processing), not just Waiting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #35 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193479&action=edit Bug 39658: (follow-up) block checkout when linked accounts over charge limit When AllowFineOverride is disabled and NoIssuesChargeLinkedAccounts is exceeded, hide the barcode field and show 'Cannot check out'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193462|0 |1 is obsolete| | --- Comment #36 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193781&action=edit Bug 39658: DB: Add patron_account_links table and sysprefs Adds table and 3 sysprefs for patron account linking feature. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193463|0 |1 is obsolete| | --- Comment #37 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193782&action=edit Bug 39658: Add Koha::Patron::AccountLink(s) objects New objects to manage patron account links. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193464|0 |1 is obsolete| | --- Comment #38 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193783&action=edit Bug 39658: Add linked account methods to Koha::Patron Methods: account_link, linked_accounts, all_linked_borrowernumbers, linked_accounts_debt. Also adds charge limit checking. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193465|0 |1 is obsolete| | --- Comment #39 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193784&action=edit Bug 39658: API: Add REST endpoints for patron account links Endpoints: GET/POST/DELETE /patrons/{id}/account_links Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193466|0 |1 is obsolete| | --- Comment #40 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193785&action=edit Bug 39658: Circulation: Add linked account fee/hold checks DEBT_LINKED_ACCOUNTS blocker and LINKED_ACCOUNT_HOLD_PICKUP alert. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193467|0 |1 is obsolete| | --- Comment #41 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193786&action=edit Bug 39658: Circulation: Add linked account hold pickup redirect Enable linked patrons to pick up each other's holds when allowed. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193468|0 |1 is obsolete| | --- Comment #42 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193787&action=edit Bug 39658: Circulation UI: Add linked account fee/hold messages Display warnings for combined debt and linked hold pickup. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193469|0 |1 is obsolete| | --- Comment #43 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193788&action=edit Bug 39658: Patron detail: Pass linked accounts to template Add linked_accounts and link_group data for display. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193470|0 |1 is obsolete| | --- Comment #44 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193789&action=edit Bug 39658: Patron detail UI: Add linked accounts section Display linked patrons with Add/Leave link group buttons. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193471|0 |1 is obsolete| | --- Comment #45 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193790&action=edit Bug 39658: Admin: Add linked account system preferences UI Add prefs for EnablePatronAccountLinking and related settings. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193472|0 |1 is obsolete| | --- Comment #46 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193791&action=edit Bug 39658: Tests: Add unit tests for Koha::Patron::AccountLink Test linking, group management, and linked_accounts methods. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193473|0 |1 is obsolete| | --- Comment #47 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193792&action=edit Bug 39658: Tests: Add API tests for patron account links endpoints Test GET/POST/DELETE /api/v1/patrons/{id}/account_links. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193474|0 |1 is obsolete| | --- Comment #48 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193793&action=edit Bug 39658: Add Koha::Exceptions::PatronAccountLink Add typed exceptions for patron account linking: - AlreadyLinked: patrons already in same group - DifferentGroups: patrons in different groups Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193475|0 |1 is obsolete| | --- Comment #49 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193794&action=edit Bug 39658: Add link_to_patron and linked_account_links methods - link_to_patron($other_patron): Links patrons, handles group logic - linked_account_links(): Returns all links in patron's group Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193476|0 |1 is obsolete| | --- Comment #50 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193795&action=edit Bug 39658: DBIC schema - DO NOT PUSH Auto-generated schema for patron_account_links table. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193477|0 |1 is obsolete| | --- Comment #51 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193796&action=edit Bug 39658: Schema: Add Koha object class mappings Map PatronAccountLink to Koha::Patron::AccountLink(s). Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193478|0 |1 is obsolete| | --- Comment #52 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193797&action=edit Bug 39658: (follow-up) linked hold pickup all types Linked account hold pickup check now applies to all hold statuses (Reserved, Transferred, Processing), not just Waiting. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193479|0 |1 is obsolete| | --- Comment #53 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193798&action=edit Bug 39658: (follow-up) block checkout when linked accounts over charge limit When AllowFineOverride is disabled and NoIssuesChargeLinkedAccounts is exceeded, hide the barcode field and show 'Cannot check out'. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193781|0 |1 is obsolete| | --- Comment #54 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193800&action=edit Bug 39658: DB: Add patron_account_links table and sysprefs Adds table and 3 sysprefs for patron account linking feature. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193782|0 |1 is obsolete| | --- Comment #55 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193801&action=edit Bug 39658: Add Koha::Patron::AccountLink(s) objects New objects to manage patron account links. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193783|0 |1 is obsolete| | --- Comment #56 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193802&action=edit Bug 39658: Add linked account methods to Koha::Patron Methods: account_link, linked_accounts, all_linked_borrowernumbers, linked_accounts_debt. Also adds charge limit checking. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193784|0 |1 is obsolete| | --- Comment #57 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193803&action=edit Bug 39658: API: Add REST endpoints for patron account links Endpoints: GET/POST/DELETE /patrons/{id}/account_links Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193785|0 |1 is obsolete| | --- Comment #58 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193804&action=edit Bug 39658: Circulation: Add linked account fee/hold checks DEBT_LINKED_ACCOUNTS blocker and LINKED_ACCOUNT_HOLD_PICKUP alert. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193786|0 |1 is obsolete| | --- Comment #59 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193805&action=edit Bug 39658: Circulation: Add linked account hold pickup redirect Enable linked patrons to pick up each other's holds when allowed. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193787|0 |1 is obsolete| | --- Comment #60 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193806&action=edit Bug 39658: Circulation UI: Add linked account fee/hold messages Display warnings for combined debt and linked hold pickup. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193788|0 |1 is obsolete| | --- Comment #61 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193807&action=edit Bug 39658: Patron detail: Pass linked accounts to template Add linked_accounts and link_group data for display. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193789|0 |1 is obsolete| | --- Comment #62 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193808&action=edit Bug 39658: Patron detail UI: Add linked accounts section Display linked patrons with Add/Leave link group buttons. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193790|0 |1 is obsolete| | --- Comment #63 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193809&action=edit Bug 39658: Admin: Add linked account system preferences UI Add prefs for EnablePatronAccountLinking and related settings. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193791|0 |1 is obsolete| | --- Comment #64 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193810&action=edit Bug 39658: Tests: Add unit tests for Koha::Patron::AccountLink Test linking, group management, and linked_accounts methods. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193792|0 |1 is obsolete| | --- Comment #65 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193811&action=edit Bug 39658: Tests: Add API tests for patron account links endpoints Test GET/POST/DELETE /api/v1/patrons/{id}/account_links. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193793|0 |1 is obsolete| | --- Comment #66 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193812&action=edit Bug 39658: Add Koha::Exceptions::PatronAccountLink Add typed exceptions for patron account linking: - AlreadyLinked: patrons already in same group - DifferentGroups: patrons in different groups Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193794|0 |1 is obsolete| | --- Comment #67 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193813&action=edit Bug 39658: Add link_to_patron and linked_account_links methods - link_to_patron($other_patron): Links patrons, handles group logic - linked_account_links(): Returns all links in patron's group Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193795|0 |1 is obsolete| | --- Comment #68 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193814&action=edit Bug 39658: DBIC schema - DO NOT PUSH Auto-generated schema for patron_account_links table. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193796|0 |1 is obsolete| | --- Comment #69 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193815&action=edit Bug 39658: Schema: Add Koha object class mappings Map PatronAccountLink to Koha::Patron::AccountLink(s). Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193797|0 |1 is obsolete| | --- Comment #70 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193816&action=edit Bug 39658: (follow-up) linked hold pickup all types Linked account hold pickup check now applies to all hold statuses (Reserved, Transferred, Processing), not just Waiting. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Kellie Stephens <kellie.stephens@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193798|0 |1 is obsolete| | --- Comment #71 from Kellie Stephens <kellie.stephens@bywatersolutions.com> --- Created attachment 193817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193817&action=edit Bug 39658: (follow-up) block checkout when linked accounts over charge limit When AllowFineOverride is disabled and NoIssuesChargeLinkedAccounts is exceeded, hide the barcode field and show 'Cannot check out'. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193800|0 |1 is obsolete| | Attachment #193801|0 |1 is obsolete| | Attachment #193802|0 |1 is obsolete| | Attachment #193803|0 |1 is obsolete| | Attachment #193804|0 |1 is obsolete| | Attachment #193805|0 |1 is obsolete| | Attachment #193806|0 |1 is obsolete| | Attachment #193807|0 |1 is obsolete| | Attachment #193808|0 |1 is obsolete| | Attachment #193809|0 |1 is obsolete| | Attachment #193810|0 |1 is obsolete| | Attachment #193811|0 |1 is obsolete| | Attachment #193812|0 |1 is obsolete| | Attachment #193813|0 |1 is obsolete| | Attachment #193814|0 |1 is obsolete| | Attachment #193815|0 |1 is obsolete| | Attachment #193816|0 |1 is obsolete| | Attachment #193817|0 |1 is obsolete| | --- Comment #72 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194910&action=edit Bug 39658: DB: Add patron_account_links table and sysprefs Adds table and 3 sysprefs for patron account linking feature. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #73 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194911&action=edit Bug 39658: Add Koha::Patron::AccountLink(s) objects New objects to manage patron account links. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #74 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194912&action=edit Bug 39658: Add linked account methods to Koha::Patron Methods: account_link, linked_accounts, all_linked_borrowernumbers, linked_accounts_debt. Also adds charge limit checking. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #75 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194913&action=edit Bug 39658: API: Add REST endpoints for patron account links Endpoints: GET/POST/DELETE /patrons/{id}/account_links Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #76 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194914&action=edit Bug 39658: Circulation: Add linked account fee/hold checks DEBT_LINKED_ACCOUNTS blocker and LINKED_ACCOUNT_HOLD_PICKUP alert. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #77 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194915&action=edit Bug 39658: Circulation: Add linked account hold pickup redirect Enable linked patrons to pick up each other's holds when allowed. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #78 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194916&action=edit Bug 39658: Circulation UI: Add linked account fee/hold messages Display warnings for combined debt and linked hold pickup. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #79 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194917&action=edit Bug 39658: Patron detail: Pass linked accounts to template Add linked_accounts and link_group data for display. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #80 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194918&action=edit Bug 39658: Patron detail UI: Add linked accounts section Display linked patrons with Add/Leave link group buttons. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #81 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194919&action=edit Bug 39658: Admin: Add linked account system preferences UI Add prefs for EnablePatronAccountLinking and related settings. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #82 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194920&action=edit Bug 39658: Tests: Add unit tests for Koha::Patron::AccountLink Test linking, group management, and linked_accounts methods. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #83 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194921&action=edit Bug 39658: Tests: Add API tests for patron account links endpoints Test GET/POST/DELETE /api/v1/patrons/{id}/account_links. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #84 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194922&action=edit Bug 39658: Add Koha::Exceptions::PatronAccountLink Add typed exceptions for patron account linking: - AlreadyLinked: patrons already in same group - DifferentGroups: patrons in different groups Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #85 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194923&action=edit Bug 39658: Add link_to_patron and linked_account_links methods - link_to_patron($other_patron): Links patrons, handles group logic - linked_account_links(): Returns all links in patron's group Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #86 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194924&action=edit Bug 39658: DBIC schema - DO NOT PUSH Auto-generated schema for patron_account_links table. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #87 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194925&action=edit Bug 39658: Schema: Add Koha object class mappings Map PatronAccountLink to Koha::Patron::AccountLink(s). Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #88 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194926&action=edit Bug 39658: (follow-up) linked hold pickup all types Linked account hold pickup check now applies to all hold statuses (Reserved, Transferred, Processing), not just Waiting. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #89 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194927&action=edit Bug 39658: (follow-up) block checkout when linked accounts over charge limit When AllowFineOverride is disabled and NoIssuesChargeLinkedAccounts is exceeded, hide the barcode field and show 'Cannot check out'. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | --- Comment #90 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Passing QA, but being verbose ;-) I really would have liked to see this as separate bugs: - add linking - allow hold pickup for linking - implement fine blocking for linked accounts It would have made testing/QA easier, but this is still fairly clean and straightforward Could fix: - If I accidentally click a patron already linked I get an error message that closes the modal, its annoying but not a blocker - Linking a large number of patrons makes it hard to navigate the page - a tab might have been cleaner INSERT INTO patron_account_links (link_group_id,borrowernumber,created_on) SELECT 1,borrowernumber,NOW() FROM borrowers - Not being able to see linked accounts on the checkout page is annoying - if I want to pickup a linked accounts holds during checkout librarians will have to go to details to see who is linked in order to grab the holds from the shelf - When providing the link to a second patron when checking out their hold I think it should open in a new tab Would fix: - The table design would allow for a patron to be part of two separate groups - I can see where I can pickup for my family, or my coworkers, but don't want my coworkers to be able to pickup for my family - future enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 David Kuhn <techservspec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Lillian <l.curanzy@newportlibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |l.curanzy@newportlibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows release notes| |multiple Koha accounts to | |be linked together without | |the implied hierarchy of a | |guarantor/guarantee | |relationship. Account | |linking is enabled with the | |new | |EnablePatronAccountLinking | |system preference. Account | |linkages can only be | |managed in the staff | |interface. Linked accounts | |can be collectively blocked | |from checkout based on | |their shared debit total | |based on the new | |NoIssuesChargeLinkedAccount | |s system preference. If the | |new | |AllowLinkedAccountHoldPicku | |p system preference is | |enabled, an item that is on | |hold for one patron may be | |retrieved by another patron | |with a linked account. When | |the item is entered as a | |checkout on the second | |patron's account, it will | |be automatically checked | |out to the first patron | |instead, thereby fulfilling | |their hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_26_05_candidate, | |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194910|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194911|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194912|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194913|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194914|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194915|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194916|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194917|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194918|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194919|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194920|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194921|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194922|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194923|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194924|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194925|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194926|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194927|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #91 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198421&action=edit Bug 39658: DB: Add patron_account_links table and sysprefs Adds table and 3 sysprefs for patron account linking feature. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #92 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198422&action=edit Bug 39658: Add Koha::Patron::AccountLink(s) objects New objects to manage patron account links. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #93 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198423&action=edit Bug 39658: Add linked account methods to Koha::Patron Methods: account_link, linked_accounts, all_linked_borrowernumbers, linked_accounts_debt. Also adds charge limit checking. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #94 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198424&action=edit Bug 39658: API: Add REST endpoints for patron account links Endpoints: GET/POST/DELETE /patrons/{id}/account_links Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #95 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198425&action=edit Bug 39658: Circulation: Add linked account fee/hold checks DEBT_LINKED_ACCOUNTS blocker and LINKED_ACCOUNT_HOLD_PICKUP alert. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #96 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198426&action=edit Bug 39658: Circulation: Add linked account hold pickup redirect Enable linked patrons to pick up each other's holds when allowed. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #97 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198427&action=edit Bug 39658: Circulation UI: Add linked account fee/hold messages Display warnings for combined debt and linked hold pickup. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #98 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198428&action=edit Bug 39658: Patron detail: Pass linked accounts to template Add linked_accounts and link_group data for display. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #99 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198429&action=edit Bug 39658: Patron detail UI: Add linked accounts section Display linked patrons with Add/Leave link group buttons. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #100 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198430&action=edit Bug 39658: Admin: Add linked account system preferences UI Add prefs for EnablePatronAccountLinking and related settings. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #101 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198431&action=edit Bug 39658: Tests: Add unit tests for Koha::Patron::AccountLink Test linking, group management, and linked_accounts methods. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #102 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198432&action=edit Bug 39658: Tests: Add API tests for patron account links endpoints Test GET/POST/DELETE /api/v1/patrons/{id}/account_links. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #103 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198433&action=edit Bug 39658: Add Koha::Exceptions::PatronAccountLink Add typed exceptions for patron account linking: - AlreadyLinked: patrons already in same group - DifferentGroups: patrons in different groups Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #104 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198434&action=edit Bug 39658: Add link_to_patron and linked_account_links methods - link_to_patron($other_patron): Links patrons, handles group logic - linked_account_links(): Returns all links in patron's group Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #105 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198435&action=edit Bug 39658: DBIC schema - DO NOT PUSH Auto-generated schema for patron_account_links table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #106 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198436&action=edit Bug 39658: Schema: Add Koha object class mappings Map PatronAccountLink to Koha::Patron::AccountLink(s). Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #107 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198437&action=edit Bug 39658: (follow-up) linked hold pickup all types Linked account hold pickup check now applies to all hold statuses (Reserved, Transferred, Processing), not just Waiting. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #108 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 198438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198438&action=edit Bug 39658: (follow-up) block checkout when linked accounts over charge limit When AllowFineOverride is disabled and NoIssuesChargeLinkedAccounts is exceeded, hide the barcode field and show 'Cannot check out'. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Kellie Stephens <kellie.stephens@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #109 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- /kohadevbox/koha/t/db_dependent/Koha/Patron/AccountLink.t (Wstat: 65280 (exited 255) Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 10 tests but ran 2. Files=1, Tests=2, 2 wallclock secs ( 0.02 usr 0.01 sys + 1.53 cusr 0.34 csys = 1.90 CPU) Result: FAIL * Proving /kohadevbox/koha/t/db_dependent/api/v1/patrons_account_links.t FAIL # Failed test '204 No Content' # at /kohadevbox/koha/t/db_dependent/api/v1/patrons_account_links.t line 224. # got: '500' # expected: '204' # Looks like you failed 1 test of 10. # Failed test 'delete() tests' # at /kohadevbox/koha/t/db_dependent/api/v1/patrons_account_links.t line 236. # Looks like you failed 1 test of 5. /kohadevbox/koha/t/db_dependent/api/v1/patrons_account_links.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests Test Summary Report ------------------- /kohadevbox/koha/t/db_dependent/api/v1/patrons_account_links.t (Wstat: 256 (exited 1) Tests: 5 Failed: 1) Failed test: 4 Non-zero exit status: 1 Files=1, Tests=5, 8 wallclock secs ( 0.02 usr 0.00 sys + 6.38 cusr 1.03 csys = 7.43 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #110 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- * Proving /kohadevbox/koha/t/db_dependent/Koha/Patron/AccountLink.t FAIL # Looks like you planned 6 tests but ran 3. # Failed test 'Basic CRUD operations' # at /kohadevbox/koha/t/db_dependent/Koha/Patron/AccountLink.t line 92. Can't locate object method "_new_from_dbic" via package "Koha::PatronAccountLink" (perhaps you forgot to load "Koha::PatronAccountLink"?) at /kohadevbox/koha/Koha/Object.pm line 234. # Looks like your test exited with 255 just after 2. /kohadevbox/koha/t/db_dependent/Koha/Patron/AccountLink.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 9/10 subtests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 --- Comment #111 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- xt/api.t ........................................ 1/8 # Failed test at xt/api.t line 94. # got: '1' # expected: '0' # $VAR1 = [ # { # 'type' => 'parameter', # 'verb' => 'post', # 'route' => '/patrons/{patron_id}/account_links', # 'name' => 'body' # } # ]; # Failed test 'No errors in 400 definitions in the spec' # at xt/api.t line 174. # got: '2' # expected: '0' delete /patrons/{patron_id}/account_links/{account_link_id} -> 'description' does not start with 'Bad request': (Default response.) delete /patrons/{patron_id}/account_links/{account_link_id} -> '$ref' is not '#/definitions/error': (#/definitions/DefaultResponse) # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39658 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org