[Bug 25442] New: Koha history ends in November 2019
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Bug ID: 25442 Summary: Koha history ends in November 2019 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The last entry in the history.txt on master is: 1069 1574336176 November 21 2019 Lisette Scheer becomes the 413th developer to have a patch pushed developer I think it probably needs a bit of updating! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The last line on master is 1084 1589278508>-May 12 2020>Slava Shishkin becomes the 428th developer to have a patch pushed>--developer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- However it's missing the minor releases' dates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha history ends in |Release dates are missing |November 2019 |from the timeline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105523&action=edit Bug 25442: Add release dates from the timeline It also fixes 326th<=>327th and 393rd<=>394th dev positions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The dates are wrong, epoch must come from commit dates, and the date converted in UTC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. I think we need distinct bugs.. one for correcting the epoch date vs display date issue (I've updated bin/get_developers.pl to output a nicely formatted fix for this in the release_tools and can upload a generated patch here or on a new bug) and one to add in all the missing releases.. minor releases are hard to pick out of the commit log as they're each on their own branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am doing that: git log --tags --simplify-by-decoration --pretty="format:%at %d"|grep 'tag: v'|sort -n -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice.. I didn't think about looking at it from the tags perspective. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- get_developers now uses tags for releases.. but tags aren't entirely consistent so some manual cleaning may be required.. I'll work through that and submit a patch here including both set of changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please share the script in the release-tools repo. My code was: my $tags = `git log --tags --simplify-by-decoration --pretty="format:%at %d"|grep 'tag: v'|sort -n`; #2014-01-23 16:08:37 -0300 (tag: v3.12.09, 3.12.X) for my $tag ( split "\n", $tags ) { if ( $tag =~ m|^(?<epoch>\d+)\s+\(tag: v(?<version>\d+\.\d+\.\d+)| ) { my $version = $+{version}; my $epoch = $+{epoch}; $events->{$epoch} = { epoch => $epoch, description => "Koha $version released", tags => 'releases' }; } else { say "$tag DOES NOT MATCH"; } } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105594&action=edit Bug 25442: Use tags to update history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- see alternative patch.. mostly from the updated get_developers with some manual interaction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is the alternative ready for testing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Yes, please take a look at the alternative.. the script used to produce it is available here: https://gitlab.com/koha-community/release-tools/-/blob/master/bin/get_develo... With the relevant code changes in the last two commits, the former of which just uncomments the Time::Moment handling to ensure we use epoch time of the commit for the display line in the history and the latter adds handling to catching versions via git tags. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105523|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Assignee|jonathan.druart@bugs.koha-c |martin.renvoize@ptfs-europe |ommunity.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25700 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 [Bug 25700] Recent Kohacons are missing from the timeline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |magnus@libriotech.no --- Comment #14 from Magnus Enger <magnus@libriotech.no> --- $ git bz apply 25442 Bug 25442 - Release dates are missing from the timeline 105594 - Bug 25442: Use tags to update history Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 25442: Use tags to update history Using index info to reconstruct a base tree... M docs/history.txt Falling back to patching base and 3-way merge... Auto-merging docs/history.txt CONFLICT (content): Merge conflict in docs/history.txt error: Failed to merge in the changes. Patch failed at 0001 Bug 25442: Use tags to update history Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-25442-Use-tags-to-update-history-SuS8Jj.patch The most recent entry in history.txt is now this: 1598907821 August 31 2020 Koha 20.05.03 released releases Not sure if the point of the patch here is to change the format or method of generating history.txt in some way, or just to update it? If it is the latter it seems to have been bypassed by other updates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Has been fixed by bug 26425. *** This bug has been marked as a duplicate of bug 26425 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25700 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 [Bug 25700] Recent Kohacons are missing from the timeline -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org