[Bug 7557] New: Change hardcoded routing list note into a system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Bug #: 7557 Summary: Change hardcoded routing list note into a system preference Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials AssignedTo: katrin.fischer@bsz-bw.de ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha.sekjal@gmail.com Created attachment 7756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7756 hardcoded note on routing list Remove the hardcoded note from the routing list in favor of a new system preference for displaying a note on all routing lists. Notes: Please return this item promptly as others are waiting for it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-19 11:39:29 UTC --- Created attachment 7757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7757 Bug 7557: Change hardcoded routing list note into a system preference Adds a new system preference RoutingListNote under the Serials tab. The note will display above the note from the subscription and replace the current hardcoded note: "Notes: Please return this item promptly as others are waiting for it." The patch adds unique ids to all notes and the note in general, so it can be styled using CSS. Also corrects the routing slip template to follow the HTML4 rule. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2012-02-21 01:58:17 UTC --- Passes valid template tests rorohiko:[git/7557-]:~/git/koha% perl xt/tt_valid.t 1..1 ok 1 - TT syntax: not using TT directive within HTML tag Passes translation tests rorohiko:[git/7557-]:~/git/koha% perl xt/author/translatable-templates.t 1..2 ok 1 - opac templates are translatable ok 2 - intranet templates are translatable Functionality works as described and the note is now editable, signed off patch to follow -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7757|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2012-02-21 01:58:51 UTC --- Created attachment 7780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7780 Bug 7557: Change hardcoded routing list note into a system preference Adds a new system preference RoutingListNote under the Serials tab. The note will display above the note from the subscription and replace the current hardcoded note: "Notes: Please return this item promptly as others are waiting for it." The patch adds unique ids to all notes and the note in general, so it can be styled using CSS. Also corrects the routing slip template to follow the HTML4 rule. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-29 15:01:03 UTC --- HELP: Patch fails to apply! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2012-02-29 15:05:20 UTC --- This is a run of the mill updatedatabase.pl conflict. It should be easy to resolve. I don't think it's necessary to ask the patch submitter to resubmit. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-29 15:39:42 UTC --- Forget my comment: vim created it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|koha.sekjal@gmail.com |m.de.rooy@rijksmuseum.nl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-03-01 11:06:15 UTC --- Asking a dumb question here: The hardcoded note just comes from a template file. So it should be translatable. Why put in a pref? Note that when you switch language, the pref does not change with you. So I do not really understand the advantage of this solution. Please clarify. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-03-01 13:22:06 UTC --- The advantage is, that it's configurable. At the moment the note is hardcoded and it does assume that this is the way routing lists in libraries work. You could always add a note for each routing slip below the hardcoded note - but you could not get rid of the harcoded note or hide it. I thought about removing it, but then on second thought I was thinking that having a note that will appear on all routing lists + an individual note wouuld be nice. As you have noted, there is the problem of translatability. like there is for all things being stored in the database. In my opinion this was that the routing slip would only appear in the "main" language. Here practice is that you print the slip and attach it to the issue so people can note when they got the issue or when they gave it to the next person on list. So I don't see a loss of functionality here. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-03-01 13:32:33 UTC --- As Katrin clarified, there is a need for individual libraries to change this default note. Editing the template is not an option then. Patch looks good. Marked as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain@biblibre.com --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- yikes, big bug, the patch can't be included: => Operator or semicolon missing before &searchfield at installer/data/mysql/updatedatabase.pl line 4731. Ambiguous use of & resolved as operator & at installer/data/mysql/updatedatabase.pl line 4731. Can't modify bitwise and (&) in scalar assignment at installer/data/mysql/updatedatabase.pl line 4732, near "RoutingListNote#jumped">RoutlingListNote</a> system preference.','Define a note to be shown on all routing lists','70|10','Textarea');"); (thx my pre-apply that detected this) => the updatedatabase containt a do("INSERT ... <a href="...">") " of href must be escaped -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Good catch, Paul! Looks good was not is good :-) Hard to see when browsing through the code, but this error should have been seen in the output of the webinstaller when running the update? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- marcel: yes, it should. It probably means the tester installed a new database from scratch, and not did an update (is it me or the "reply" link doesn't copy the original comment anymore ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- And before you ask... I didn't notice because the link was something I put in last minute. I will fix the patch :) QA++ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #12)
(is it me or the "reply" link doesn't copy the original comment anymore ?
I think you have to make sure you're not using a cached copy of a javascript file. I noticed the same thing and a shift-reload fixed it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #14)
(In reply to comment #12)
(is it me or the "reply" link doesn't copy the original comment anymore ? I think you have to make sure you're not using a cached copy of a javascript file. I noticed the same thing and a shift-reload fixed it.
good catch, that's it, as you can see -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7780|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8170&action=edit Bug 7557: Change hardcoded routing list note into a system preference Adds a new system preference RoutingListNote under the Serials tab. The note will display above the note from the subscription and replace the current hardcoded note: "Notes: Please return this item promptly as others are waiting for it." The patch adds unique ids to all notes and the note in general, so it can be styled using CSS. Also corrects the routing slip template to follow the HTML4 rule. Update 2012-03-12: Fixed problem in updatedatebase. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> --- (considering the signed-off is still valid, as this bug already made a full loop and failed QA because of a small typo) QA comment: one of our rule is that a new feature should be introduced without trouble for existing setups. The idea of having To change this note edit RoutlingListNote system preference. into the syspref by default may seem good, but if the user don't spot this, or don't care, it will be written suddenly on printed routing slips. So i've removed this default RoutingListNote Other than this, passed QA, will push -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was torn here. Now the old sentence will no longer be printed out - but putting the english sentence in the system prefernece would not have worked either. I think removing it is ok, but will not advertise the new feature. There is a disadvantage to every solution I could think of. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> ---
I think removing it is ok, but will not advertise the new feature.
=> that's what Release Notes are made for (even if I know many ppl don't read them) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #20 from Nicole C. Engard <nengard@gmail.com> --- This says pushed to master but I don't see it in my admin area - was there a problem with my upgrade? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nicole, I think it was not pushed - i can't see it on git. I reset the status to "Passed QA" so it shows up in Paul's list :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Paul Poulain <paul.poulain@biblibre.com> --- sorry, I pushed the branch, but forgot to push master before closing my computer yesterday ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 --- Comment #23 from Mason James <mtj@kohaaloha.com> --- Created attachment 8498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8498&action=edit Bug 7557 - corrects missing semi-colon ';' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 --- Comment #24 from Mason James <mtj@kohaaloha.com> --- Created attachment 8504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8504&action=edit Bug 7557 - corrects missing semi-colon ';', removes extra '`' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8498|0 |1 is obsolete| | Attachment #8504|0 |1 is obsolete| | --- Comment #25 from Mason James <mtj@kohaaloha.com> --- Created attachment 8505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8505&action=edit Bug 7557 - corrects missing semi-colon ';', removes extra '`' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mason, updatedatabase got fixed - I am closing this bug. Please reopen if I missed something. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org