[Bug 19411] New: opac-shelves.tt : the opaccredits block should be outside of the main <div>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411 Bug ID: 19411 Summary: opac-shelves.tt : the opaccredits block should be outside of the main <div> Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: david.bourgault@inlibro.com QA Contact: testopia@bugs.koha-community.org Created attachment 67614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67614&action=edit HTML structure of opac-shelves.tt as displayed by Chrome dev tools. The opac-shelves.tt template seems to have mismatch tags, resulting in the opaccredits <div> to be placed inside the main <div>. This can break CSS customization. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411 --- Comment #1 from David Bourgault <david.bourgault@inlibro.com> --- Similar issue exists in opac-advsearch.tt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I don't see a different between opac-shelves.tt, opac-advsearch.tt, and opac-main.tt in the placement of opaccredits. Could you double-check? Do you have any custom HTML (opacheader, opacmain, etc.) which might be causing the HTML to be off? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411 --- Comment #3 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 69422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69422&action=edit opac-shelves.tt in Chrome element inspector It might have been my database causing the issue in opac-advsearch.tt, but after clearing all html/css/js from my database, on master branch I could still reproduce the issue for opac-shelves.tt As you can see in the file attached, the comment for closing main is two levels deeper than it should. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69780&action=edit Screenshot of correctly-placed OPAC credits on advanced search page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69781&action=edit Screenshot of correctly-placed OPAC credits on lists page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I still cannot reproduce this problem. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org