https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43293 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203596&action=edit Bug 43293: Add IDs to the Pay/Write off confirm buttons on paycollect.tt The Confirm submit button on the combined pay/writeoff form doesn't have an id, making it hard for local customisations, hardware integrations (e.g. receipt printer triggers), and automated tests to reliably target the pay action versus the writeoff action - both render as the same markup with only the value/hidden op field differing. Add id="paysubmit" and id="writeoffsubmit" to the two branches of the existing type == 'WRITEOFF' conditional, matching the existing op=cud-pay/op=cud-writeoff split right above it. Test plan: 1) Go to a patron's Pay fines page and select multiple charges 2) Choose Pay - confirm the Confirm button has id="paysubmit" 3) Choose Write off - confirm the Confirm button has id="writeoffsubmit" 4) Confirm both flows still submit and behave exactly as before -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43293 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43293 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203596|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43293 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203636&action=edit Bug 43293: (follow-up) Make the same change to two other buttons There are also confirm buttons for pay_individual and writeoff_individual. This patch also makes a minor HTML correction: <div class="action"> should be <fieldset class="action">. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43293 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43293 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 206150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206150&action=edit Bug 43293: Add IDs to the Pay/Write off confirm buttons on paycollect.tt The Confirm submit button on the combined pay/writeoff form doesn't have an id, making it hard for local customisations, hardware integrations (e.g. receipt printer triggers), and automated tests to reliably target the pay action versus the writeoff action - both render as the same markup with only the value/hidden op field differing. Add id="paysubmit" and id="writeoffsubmit" to the two branches of the existing type == 'WRITEOFF' conditional, matching the existing op=cud-pay/op=cud-writeoff split right above it. Test plan: 1) Go to a patron's Pay fines page and select multiple charges 2) Choose Pay - confirm the Confirm button has id="paysubmit" 3) Choose Write off - confirm the Confirm button has id="writeoffsubmit" 4) Confirm both flows still submit and behave exactly as before Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.