[Bug 24109] New: Elasticsearch - Advanced search limit by shelving location uses AND instead of OR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 Bug ID: 24109 Summary: Elasticsearch - Advanced search limit by shelving location uses AND instead of OR Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: mkstephens@lancasterseminary.edu When performing an advanced catalog search, the limits for item type and collection are formed into a query string with OR, while the limits for shelving location are formed into the query string with AND. This prevents searching multiple locations at once and is also confusing since the behavior is different from the other limit tabs and is accompanied by the same instruction, "Limit to any of the following." Steps to replicate: 1. In the advanced catalog search, select two limits on the item types tab. Perform search. Note the search query was constructed with OR. 2. Return to the advanced catalog search and clear fields. Select two limits on the shelving location tab. Perform search. Note the search query was constructed with AND. 3. Return to the advanced catalog search and clear fields. Select two limits on the collections tab. Perform search. Note the search query was constructed with OR. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96623&action=edit Bug 24109: Map 'loc' to 'location' whne building ES queries When building the query we start with mc-loc - then we strip the mc, convert the field, and restore mc- to indicate the searches should be ORed together. We have a mapping for mc-loc to location, but we strip the mc for converting For all other mc indexes there is no issue as they don't need to be mapped (they are the same minus the mc) To test: 0 - Be using Elasticsearch and have AdvancedSearchTypes set to include loc 1 - Perform an advanced search for two shelving locations that have items in the catalog 2 - Note no restuls 3 - Apply patch 4 - Restart all the things 5 - Repeat search 6 - You get results! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch - Advanced |Elasticsearch - Advanced |search limit by shelving |search limit by shelving |location uses AND instead |location is not converted |of OR |to correct index CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96623|0 |1 is obsolete| | --- Comment #2 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Created attachment 96628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96628&action=edit Bug 24109: Map 'loc' to 'location' whne building ES queries When building the query we start with mc-loc - then we strip the mc, convert the field, and restore mc- to indicate the searches should be ORed together. We have a mapping for mc-loc to location, but we strip the mc for converting For all other mc indexes there is no issue as they don't need to be mapped (they are the same minus the mc) To test: 0 - Be using Elasticsearch and have AdvancedSearchTypes set to include loc 1 - Perform an advanced search for two shelving locations that have items in the catalog 2 - Note no restuls 3 - Apply patch 4 - Restart all the things 5 - Repeat search 6 - You get results! Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 --- Comment #3 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Patch works as expected. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22426 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Same issue as on 22426 *** This bug has been marked as a duplicate of bug 22426 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org