[Bug 38841] New: Guarantor does not check non members guarantor while deleting with ChildNeedsGuarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Bug ID: 38841 Summary: Guarantor does not check non members guarantor while deleting with ChildNeedsGuarantor Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Steps to reproduce: 1 - Edit a Child, add a guarantor and a non-member guarantor 2 - Try to remove the guarantor while letting the non-member guarantor -> you cannot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 176200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176200&action=edit Bug 38841: Check non-patron guarantor while deleting patron guarantor When editing a child while Childneedsquarantor active, trying to delete a guarantor while saving a non-patron guarantor will prevent the user from saving. However, if an adult has expired, some librarian would like to remove the account and let some information in non-patron guarantor. TEST PLAN Before applying patch 1 - Open Lisa Charles'page, add Henry Acevedo as Guarantor, also fill Guarantor surname and firstname 2 - Edit the page and try and remove Henry Acevedo, it won't work however there is still one guarantor 3 - Apply patch 4 - Try and remove Henry Acevedo -> it will work 5 - add HA as a guarantor again 6 - try and remove him AND let guarantor firstname and surname empty -> you can't 7 - Add HA and Edna Acosta as guarantor 8 - Remove HA and ler guarantor firstname and surname empty -> you can -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Thibault Keromnès <thibault.keromnes@univ-paris8.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176200|0 |1 is obsolete| | --- Comment #2 from Thibault Keromnès <thibault.keromnes@univ-paris8.fr> --- Created attachment 176500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176500&action=edit Bug 38841: Check non-patron guarantor while deleting patron guarantor When editing a child while Childneedsquarantor active, trying to delete a guarantor while saving a non-patron guarantor will prevent the user from saving. However, if an adult has expired, some librarian would like to remove the account and let some information in non-patron guarantor. TEST PLAN Before applying patch 1 - Open Lisa Charles'page, add Henry Acevedo as Guarantor, also fill Guarantor surname and firstname 2 - Edit the page and try and remove Henry Acevedo, it won't work however there is still one guarantor 3 - Apply patch 4 - Try and remove Henry Acevedo -> it will work 5 - add HA as a guarantor again 6 - try and remove him AND let guarantor firstname and surname empty -> you can't 7 - Add HA and Edna Acosta as guarantor 8 - Remove HA and ler guarantor firstname and surname empty -> you can Signed-off-by: Thibault Keromnes <thibault.keromnes@univ-paris8.fr> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Thibault Keromnès <thibault.keromnes@univ-paris8.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibault.keromnes@univ-pari | |s8.fr Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 --- Comment #3 from mteal@greenvillelibrary.org --- While we're waiting for this fix, does anyone have a workaround? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- You can temporarily disable the syspref ChildNeedsGuarantor before editing a child, or apply temporarily this patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176500|0 |1 is obsolete| | --- Comment #5 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 178868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178868&action=edit Bug 38841: Check non-patron guarantor while deleting patron guarantor When editing a child while Childneedsquarantor active, trying to delete a guarantor while saving a non-patron guarantor will prevent the user from saving. However, if an adult has expired, some librarian would like to remove the account and let some information in non-patron guarantor. Worked as expected! TEST PLAN Before applying patch 1 - Open Lisa Charles'page, add Henry Acevedo as Guarantor, also fill Guarantor surname and firstname 2 - Edit the page and try and remove Henry Acevedo, it won't work however there is still one guarantor 3 - Apply patch 4 - Try and remove Henry Acevedo -> it will work 5 - add HA as a guarantor again 6 - try and remove him AND let guarantor firstname and surname empty -> you can't 7 - Add HA and Edna Acosta as guarantor 8 - Remove HA and ler guarantor firstname and surname empty -> you can Signed-off-by: Thibault Keromnes <thibault.keromnes@univ-paris8.fr> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please add some info to the release notes? Change makes sense, but it will be good to inform. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch allows a release notes| |librarian to replace a | |member guarantor with a | |non-member guarantor. | |Before this patch, saving a | |child's profile with the | |"delete [this guarantor]" | |box checked and the data | |entered in the non-member | |guarantor field resulted in | |an error because koha | |refused to delete the last | |guarantor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38841 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org