[Bug 23955] New: Replace famfamfam icon in OPAC holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Bug ID: 23955 Summary: Replace famfamfam icon in OPAC holds template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The OPAC holds template uses a famfamfam icon image to indicate an item which cannot be put on hold when "a specific item" has been selected. This icon can be replaced with an Font Awesome icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94984&action=edit Bug 23955: Replace famfamfam icon in OPAC holds template This patch modifies the OPAC holds template so that when an item isn't available for an item-level hold a Font Awesome icon is displayed instead of a famfamfam image. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Make sure you have items which can be placed on hold at the item level. - Locate a title with more than one item, at least one of which isn't available to be placed on hold (item is marked withdrawn, for instance). - Start the process of placing a hold on the item. - On the "Confirm holds" scren, click "Show more options" and select "A specific item." - In the table of items, any item which isn't available to be put on hold should be inidicated with a red X. The title attribute of the icon should show "Cannot be put on hold." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94984|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94988&action=edit Bug 23955: Replace famfamfam icon in OPAC holds template This patch modifies the OPAC holds template so that when an item isn't available for an item-level hold a Font Awesome icon is displayed instead of a famfamfam image. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Make sure you have items which can be placed on hold at the item level. - Locate a title with more than one item, at least one of which isn't available to be placed on hold (item is marked withdrawn, for instance). - Start the process of placing a hold on the item. - On the "Confirm holds" scren, click "Show more options" and select "A specific item." - In the table of items, any item which isn't available to be put on hold should be inidicated with a red X. The title attribute of the icon should show "Cannot be put on hold." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tiny change, PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org