[Bug 37250] New: Redesign labels home page to match other module home pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Bug ID: 37250 Summary: Redesign labels home page to match other module home pages Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I propose to update the label creator home page so that it has a grid of links like the circulation or cataloging home pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37222 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 [Bug 37222] Standardize markup for sidebar menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168470&action=edit Bug 37250: Redesign labels home page to match other module home pages This patch changes the labels home page so that it shows the links which previously were buried in a dropdown menu. Generally speaking we shouldn't be using the button toolbar for navigation. To test, apply the patch and go to Cataloging -> Label creator. - You should see links styled like they are on the circulation or cataloging home page. - If you follow any of those links you should see a new menu in the sidebar which has all the navigation items previously in the "Manage" dropdown menu. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I did reset_all after applying the patch and I'm still getting an error when I click on any of the buttons Template process failed: file error - labels-menu.inc: not found at /kohadevbox/koha/C4/Templates.pm line 134 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- (In reply to Caroline Cyr La Rose from comment #2)
I did reset_all after applying the patch and I'm still getting an error when I click on any of the buttons
Template process failed: file error - labels-menu.inc: not found at /kohadevbox/koha/C4/Templates.pm line 134
I get the same. No CSS changes, so no yarn build required. A restart_all was all that I did after applying the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168470|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168563&action=edit Bug 37250: Redesign labels home page to match other module home pages This patch changes the labels home page so that it shows the links which previously were buried in a dropdown menu. Generally speaking we shouldn't be using the button toolbar for navigation. To test, apply the patch and go to Cataloging -> Label creator. - You should see links styled like they are on the circulation or cataloging home page. - If you follow any of those links you should see a new menu in the sidebar which has all the navigation items previously in the "Manage" dropdown menu. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #3)
Template process failed: file error - labels-menu.inc: not found at /kohadevbox/koha/C4/Templates.pm line 134
Sorry, I forgot to commit the new file! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168563|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 168569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168569&action=edit Bug 37250: Redesign labels home page to match other module home pages This patch changes the labels home page so that it shows the links which previously were buried in a dropdown menu. Generally speaking we shouldn't be using the button toolbar for navigation. To test, apply the patch and go to Cataloging -> Label creator. - You should see links styled like they are on the circulation or cataloging home page. - If you follow any of those links you should see a new menu in the sidebar which has all the navigation items previously in the "Manage" dropdown menu. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement changes release notes| |the label creator home page | |(Cataloging > Tools > Label | |creator) so that it shows | |the links which previously | |were buried in a dropdown | |menu. --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #5)
(In reply to David Nind from comment #3)
Template process failed: file error - labels-menu.inc: not found at /kohadevbox/koha/C4/Templates.pm line 134
Sorry, I forgot to commit the new file!
Thanks Owen! I like the updated layout. I have some suggestions, but I think these would probably be better as new bugs: 1. When you are in any of the areas, there is a new sidebar at the top with Label batches, Label layouts, etc: - These are highlighted when you are in that section, but not when you are on the new form for each of them (don't know if it is possible to highlight these in this case) - There is no "Print barcode range" in this new sidebar (see the additional suggestion below) - Should this display when you are just on the label creator page? 2. Dropdown list for +New: change "Layout" to "Label layout" (matches with page heading, and new top sidebar label, and is more consistent with other new items). 3. Print barcode range: as this is not saved, or editable later on, maybe this: - could have it's own button on the label creator home page - could have it's own action button next to +New - I don't think it quite fits under +New 4. Breadcrumbs (and page titles): - New label batches: Label creator > Label batches> New label batch (currently just Batches) - New label layouts: Label creator > Label layouts > New label layouts (currently just Layouts) - New label template: Label creator > Label templates > New label template (currently just Templates) - New printer profile: Label creator > Printer profiles > New printer profiles (currently just Profiles) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 --- Comment #8 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Update the CSS (required for dependent bug): yarn build -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169307&action=edit Bug 37250: (follow-up) More improvements to menus - Add highlighting to new sidebar menu - Make labels more consistent in menus, breadcrumbs, and titles - Add 'Print barcode range' link to the labels home page and sidebar menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37581 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37581 [Bug 37581] Use split button for label creator "new" operations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168569|0 |1 is obsolete| | Attachment #169307|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171067&action=edit Bug 37250: Redesign labels home page to match other module home pages This patch changes the labels home page so that it shows the links which previously were buried in a dropdown menu. Generally speaking we shouldn't be using the button toolbar for navigation. To test, apply the patch and go to Cataloging -> Label creator. - You should see links styled like they are on the circulation or cataloging home page. - If you follow any of those links you should see a new menu in the sidebar which has all the navigation items previously in the "Manage" dropdown menu. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171068&action=edit Bug 37250: (follow-up) More improvements to menus - Add highlighting to new sidebar menu - Make labels more consistent in menus, breadcrumbs, and titles - Add 'Print barcode range' link to the labels home page and sidebar menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Doesn't seem to apply cleanly now. Maybe due due to Bug 37250. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171067|0 |1 is obsolete| | Attachment #171068|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177586&action=edit Bug 37250: Redesign labels home page to match other module home pages This patch changes the labels home page so that it shows the links which previously were buried in a dropdown menu. Generally speaking we shouldn't be using the button toolbar for navigation. To test, apply the patch and go to Cataloging -> Label creator. - You should see links styled like they are on the circulation or cataloging home page. - If you follow any of those links you should see a new menu in the sidebar which has all the navigation items previously in the "Manage" dropdown menu. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177587&action=edit Bug 37250: (follow-up) More improvements to menus - Add highlighting to new sidebar menu - Make labels more consistent in menus, breadcrumbs, and titles - Add 'Print barcode range' link to the labels home page and sidebar menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177586|0 |1 is obsolete| | Attachment #177587|0 |1 is obsolete| | --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179076&action=edit Bug 37250: Redesign labels home page to match other module home pages This patch changes the labels home page so that it shows the links which previously were buried in a dropdown menu. Generally speaking we shouldn't be using the button toolbar for navigation. To test, apply the patch and go to Cataloging -> Label creator. - You should see links styled like they are on the circulation or cataloging home page. - If you follow any of those links you should see a new menu in the sidebar which has all the navigation items previously in the "Manage" dropdown menu. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179077&action=edit Bug 37250: (follow-up) More improvements to menus - Add highlighting to new sidebar menu - Make labels more consistent in menus, breadcrumbs, and titles - Add 'Print barcode range' link to the labels home page and sidebar menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179076|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179112&action=edit Bug 37250: Redesign labels home page to match other module home pages This patch changes the labels home page so that it shows the links which previously were buried in a dropdown menu. Generally speaking we shouldn't be using the button toolbar for navigation. To test, apply the patch and go to Cataloging -> Label creator. - You should see links styled like they are on the circulation or cataloging home page. - If you follow any of those links you should see a new menu in the sidebar which has all the navigation items previously in the "Manage" dropdown menu. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179077|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179113&action=edit Bug 37250: (follow-up) More improvements to menus - Add highlighting to new sidebar menu - Make labels more consistent in menus, breadcrumbs, and titles - Add 'Print barcode range' link to the labels home page and sidebar menu. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Marion Durand contact| | CC| |marion.durand@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37250 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1261 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org