[Bug 37480] New: Make C4::Serials::addroutingmember us Koha::Objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Bug ID: 37480 Summary: Make C4::Serials::addroutingmember us Koha::Objects Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37476 Status|NEW |Needs Signoff --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I initially wrote this as part of bug 37476 then decided to move it to it's own place. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37476 [Bug 37476] RANK is a reserved word in MySQL 8.0.2+ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 169608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169608&action=edit Bug 37480: Make addroutingmember use Koha::Subscription::Routinglists This patch rewriteis the method so it relies on Koha::Object-based classes instead of the old way. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Serials.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Run: $ git grep addroutingmember => SUCCESS: It is only called on a single .pl file which doesn't care about the return value. Neither the tests care. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169608|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 169796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169796&action=edit Bug 37480: Make addroutingmember use Koha::Subscription::Routinglists This patch rewriteis the method so it relies on Koha::Object-based classes instead of the old way. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Serials.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Run: $ git grep addroutingmember => SUCCESS: It is only called on a single .pl file which doesn't care about the return value. Neither the tests care. 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make |Make |C4::Serials::addroutingmemb |C4::Serials::addroutingmemb |er us Koha::Objects |er use Koha::Objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37876 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37876 [Bug 37876] Move C4::Serials code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169796|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171240&action=edit Bug 37480: Make addroutingmember use Koha::Subscription::Routinglists This patch rewriteis the method so it relies on Koha::Object-based classes instead of the old way. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Serials.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Run: $ git grep addroutingmember => SUCCESS: It is only called on a single .pl file which doesn't care about the return value. Neither the tests care. 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- I've tested the feature. This test plan is cheating :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Version|unspecified |Main --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree with Joubu about the cheating with the test plan. *stern look* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #5)
I've tested the feature. This test plan is cheating :D
I forgot about the test plan IMHO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Skipping for release notes as this is quite technical and kind of self-explanatory to developers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Internal architecture, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 Bug 37480 depends on bug 37476, which changed state. Bug 37476 Summary: RANK is a reserved word in MySQL 8.0.2+ https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37476 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org