https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Assignee|jonathan.druart@gmail.com |andrew.auld@openfifth.co.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Sorry for the duff formatting on the test plan: Test Plan: 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement 5) Try to set both licenses to status 'controlling' 6) Note error modal duplicates the error message 'Only one controlling license is allowed' 7) Apply the patch, run yarn js:build and then hard refresh the browser 8) Repeat steps 1 to 5 and enjoy the single error message! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 180491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180491&action=edit Bug 39543: Error modal when trying to add two controlling licences to an agreement duplicates error message If you try to add two licences with the status 'controlling' to an agreement record, the error modal duplicates the error message 'Only one controlling license is allowed'. Test Plan: 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement 5) Try to set both licenses to status 'controlling' 6) Note error modal duplicates the error message 'Only one controlling license is allowed' 7) Apply the patch, run yarn js:build and then hard refresh the browser 8) Repeat steps 1 to 5 and enjoy the single error message! Signed-off-by: Magnus Enger <magnus@libriotech.no> I took the liberty of fixing up the commit message a bit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180490|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180491|0 |1 is obsolete| | --- Comment #4 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 180526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180526&action=edit Bug 39543: Error modal when trying to add two controlling licences to an agreement duplicates error message If you try to add two licences with the status 'controlling' to an agreement record, the error modal duplicates the error message 'Only one controlling license is allowed'. Test Plan: 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement 5) Try to set both licenses to status 'controlling' 6) Note error modal duplicates the error message 'Only one controlling license is allowed' 7) Apply the patch, run yarn js:build and then hard refresh the browser 8) Repeat steps 1 to 5 and enjoy the single error message! Signed-off-by: Magnus Enger <magnus@libriotech.no> I took the liberty of fixing up the commit message a bit. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.05.00 |25.05.00,24.11.10 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.