[Bug 24443] New: Consider NULL as 0 for issues in items search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Bug ID: 24443 Summary: Consider NULL as 0 for issues in items search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In items search, we can filter by items issues count, data coming from items.issues. Most of the time, for an item with no issues this column contains NULL. This enhancement proposes to consider NULL as 0 to allow searching items with no issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 97480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97480&action=edit Bug 24443: Consider NULL as 0 for issues in items search In items search, we can filter by items issues count, data coming from items.issues. Most of the time, for an item with no issues this column contains NULL. This enhancement proposes to consider NULL as 0 to allow searching items with no issues. Test plan: 1) Use SQL to count items with items.issues = NULL : select count(*) from items where issues is null; 2) Go to items search 3) Perform search with filter "Checkout count" = 0 4) Check you get the same number of results as SQL query -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 97481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97481&action=edit Bug 24443: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97480|0 |1 is obsolete| | --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 97482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97482&action=edit Bug 24443: Consider NULL as 0 for issues in items search In items search, we can filter by items issues count, data coming from items.issues. Most of the time, for an item with no issues this column contains NULL. This enhancement proposes to consider NULL as 0 to allow searching items with no issues. Test plan: 1) Use SQL to count items with items.issues = NULL : select count(*) from items where issues is null; 2) Go to items search 3) Perform search with filter "Checkout count" = 0 4) Check you get the same number of results as SQL query -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97481|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 97483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97483&action=edit Bug 24443: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97483|0 |1 is obsolete| | --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 97486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97486&action=edit Bug 24443: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97486|0 |1 is obsolete| | --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 97487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97487&action=edit Bug 24443: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97487|0 |1 is obsolete| | --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 97488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97488&action=edit Bug 24443: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97488|0 |1 is obsolete| | --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 97493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97493&action=edit Bug 24443: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97493|0 |1 is obsolete| | --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 97496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97496&action=edit Bug 24443: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97482|0 |1 is obsolete| | --- Comment #10 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 97559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97559&action=edit Bug 24443: Consider NULL as 0 for issues in items search In items search, we can filter by items issues count, data coming from items.issues. Most of the time, for an item with no issues this column contains NULL. This enhancement proposes to consider NULL as 0 to allow searching items with no issues. Test plan: 1) Use SQL to count items with items.issues = NULL : select count(*) from items where issues is null; 2) Go to items search 3) Perform search with filter "Checkout count" = 0 4) Check you get the same number of results as SQL query Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97496|0 |1 is obsolete| | --- Comment #11 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 97560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97560&action=edit Bug 24443: Unit test Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97559|0 |1 is obsolete| | Attachment #97560|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97801&action=edit Bug 24443: Consider NULL as 0 for issues in items search In items search, we can filter by items issues count, data coming from items.issues. Most of the time, for an item with no issues this column contains NULL. This enhancement proposes to consider NULL as 0 to allow searching items with no issues. Test plan: 1) Use SQL to count items with items.issues = NULL : select count(*) from items where issues is null; 2) Go to items search 3) Perform search with filter "Checkout count" = 0 4) Check you get the same number of results as SQL query Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97802&action=edit Bug 24443: Unit test Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #15 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #17 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23081 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26032 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org