https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- In it's most basic form, this should just be exposed as a delete button for any rota's that have no items attached. Thinking more widely, it would be nice to allow deletion regardless and give options to disassociate items from the rota at deletion time including setting where those items should end up.

From memory, non-cyclical rota's don't clean up after themselves either.. it might be nice to have the option to remove the item to rota link once at item hits it's final destination.

-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confirmed on master with my superlibrarian user: * Enable StockRotation system preference * Tools > Stock rotation > New rota * Enter Name, save. * There is no delete button visible. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Pedro Amorim <pjamorim91@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143144|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pjamorim91@gmail.com> --- Created attachment 143148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143148&action=edit Add delete action to stock rotation rotas To test: 1) Enable StockRotation system preference 2) Tools > Stock rotation > New rota 3) Enter Name, save 4) Verify "Delete" button shows on the right 5) Click "Delete" -> Confirm "Yes" 6) Repeat steps 1-3 and click "Manage"->"Stages" 7) Add a new stage, enter Library and Duration, click "Save" 8) Return to rotas, click "Manage"->"Items" 9) Add item, enter barcode, click "Save" (optional: add more than 1 item) 10) Click "return to rotas" and press "Delete" 11) Verify the warning now shows, because items are attached, with the attached items count 12) Click "Delete" -> Deletion is successful -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Pedro Amorim <pjamorim91@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 --- Comment #6 from David Nind <david@davidnind.com> --- Also, the QA Team will require the patch to be formatted according to the guidelines at https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 145275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145275&action=edit Bug 30869: Stock rotation rotas cannot be deleted 'At the moment, it isn't possible to delete any rotas that have 0 items linked to it. The only way to do it is in MySQL - it would be good if this was possible from the staff client.' This patch implements this, and also implements the possibility of deleting a rota with items linked to it, providing a warning that the item(s) currently in rotation will remain at its/their current stage library. Test plan: 1) Enable StockRotation system preference 2) Cataloging > Stock rotation > New rota 3) Enter Name, save 4) Verify 'Delete' button shows on the right 5) Click 'Delete' -> Confirm 'Yes' 6) Repeat steps 1-3 and click 'Manage'->'Stages' 7) Add a new stage, enter Library and Duration, click 'Save' 8) Return to rotas, click 'Manage'->'Items' 9) Add item, enter barcode, click 'Save' (optional: add more than 1 item) 10) Optional: Click 'Move to next stage' and verify that item is now in different branch 11) Click 'return to rotas' and press 'Delete' 12) Verify the warning now shows, because items are attached, with the attached items count 13) Click 'Delete' -> Deletion is successful 14) If you did step 10, verify the item is still in the branch that it was at the time the rota was deleted Sponsored-by: PTFS-Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi David. Can you please check now that the patch applies and/or if the test plan goes accordingly. Thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 --- Comment #9 from David Nind <david@davidnind.com> --- (In reply to Pedro Amorim from comment #8)

Can you please check now that the patch applies and/or if the test plan goes accordingly.

Thanks Pedro! The patch now applies, sign off shortly. David -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145275|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 145323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145323&action=edit Bug 30869: Stock rotation rotas cannot be deleted 'At the moment, it isn't possible to delete any rotas that have 0 items linked to it. The only way to do it is in MySQL - it would be good if this was possible from the staff client.' This patch implements this, and also implements the possibility of deleting a rota with items linked to it, providing a warning that the item(s) currently in rotation will remain at its/their current stage library. Test plan: 1) Enable StockRotation system preference 2) Cataloging > Stock rotation > New rota 3) Enter Name, save 4) Verify 'Delete' button shows on the right 5) Click 'Delete' -> Confirm 'Yes' 6) Repeat steps 1-3 and click 'Manage'->'Stages' 7) Add a new stage, enter Library and Duration, click 'Save' 8) Return to rotas, click 'Manage'->'Items' 9) Add item, enter barcode, click 'Save' (optional: add more than 1 item) 10) Optional: Click 'Move to next stage' and verify that item is now in different branch 11) Click 'return to rotas' and press 'Delete' 12) Verify the warning now shows, because items are attached, with the attached items count 13) Click 'Delete' -> Deletion is successful 14) If you did step 10, verify the item is still in the branch that it was at the time the rota was deleted Sponsored-by: PTFS-Europe Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Fixed commit author, had originally been submitted as John Doe. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145353|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147251&action=edit Bug 30869: Add the ability to delete stock rotation rotas 'At the moment, it isn't possible to delete any rotas that have 0 items linked to it. The only way to do it is in MySQL - it would be good if this was possible from the staff client.' This patch implements this, and also implements the possibility of deleting a rota with items linked to it, providing a warning that the item(s) currently in rotation will remain at its/their current stage library. Test plan: 1) Enable StockRotation system preference 2) Cataloging > Stock rotation > New rota 3) Enter Name, save 4) Verify 'Delete' button shows on the right 5) Click 'Delete' -> Confirm 'Yes' 6) Repeat steps 1-3 and click 'Manage'->'Stages' 7) Add a new stage, enter Library and Duration, click 'Save' 8) Return to rotas, click 'Manage'->'Items' 9) Add item, enter barcode, click 'Save' (optional: add more than 1 item) 10) Optional: Click 'Move to next stage' and verify that item is now in different branch 11) Click 'return to rotas' and press 'Delete' 12) Verify the warning now shows, because items are attached, with the attached items count 13) Click 'Delete' -> Deletion is successful 14) If you did step 10, verify the item is still in the branch that it was at the time the rota was deleted Sponsored-by: PTFS-Europe Signed-off-by: David Nind <david@davidnind.com> JD Amended patch: * Fix QA failures FAIL forbidden patterns forbidden pattern: tab char (line 150) forbidden pattern: tab char (line 151) * Adjust commit message to describe what the patch does Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- Does not apply clean to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/871 -- You are receiving this mail because: You are watching all bug changes.