[Bug 13132] New: Confirm report delete?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Bug ID: 13132 Summary: Confirm report delete? Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: hbraum@nekls.org QA Contact: testopia@bugs.koha-community.org In most other places in Koha, you get a confirm delete message when clicking a delete button, but in saved reports you do not have this option; you choose to delete a single report, and don't get a confirmation message -- the report is immediately deleted. It would be nice if saved reports had a confirm delete button, just to catch accidental deletes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Heather I can reproduce this bug in 3.14.05 but not in master or the latest 3.16.x. I think this has been fixed and should work correctly after your next upgrade. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #2 from Heather Braum <hbraum@nekls.org> --- Owen, We are on 3.16.4 (which I thought was the latest version of 3.16 when I reported this issue), and I am still not seeing a confirm delete message on Mac and PC versions of Firefox and Chrome... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW Version|3.16 |master Summary|Confirm report delete? |Report deletion | |confirmation doesn't always | |work with reports tabs Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Report deletion |Report deletion |confirmation doesn't always |confirmation doesn't work |work with reports tabs |with DataTables pagination -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 33203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33203&action=edit Bug 13132 - Report deletion confirmation doesn't work with DataTables pagination This patch fixes a problem with save report deletion confirmation which appears when the user tries to delete a report found on a DataTables page > 1. This patch alters the trigger to accommodate links which are not initially shown. A small addition has been made to automatically close the menu when the delete link is clicked. To test you must have, at the very least, greater than 10 saved reports. - If necessary change the number of entries shown so that there is a "next" page of results. - Navigate to a subsequent page, click the "Action" menu, and choose "Delete" for one of your saved reports. - A confirmation message should appear. -- Clicking "OK" should complete the deletion. -- Clicking "Cancel" should cancel the deletion. - Confirm that deletion confirmations work from the first page and from other tabs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Heather Braum <hbraum@nekls.org> --- This patch fixes a problem with save report deletion confirmation which appears when the user tries to delete a report found on a DataTables page > 1. This patch alters the trigger to accommodate links which are not initially shown. A small addition has been made to automatically close the menu when the delete link is clicked. Test Plan: To test you must have, at the very least, greater than 10 saved reports. - If necessary change the number of entries shown so that there is a "next" page of results. - Navigate to a subsequent page, click the "Action" menu, and choose "Delete" for one of your saved reports. - A confirmation message should appear. -- Clicking "OK" should complete the deletion. -- Clicking "Cancel" should cancel the deletion. - Confirm that deletion confirmations work from the first page and from other tabs. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but I am not able to see the problem on current master. I tried with 11 reports, set the page to 10, went on the second page. Tried the menu and the checkbox + button below the table. I always got the confirmation dialog. I tried from the all tab and form the acqusitions tab. What is missing? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu --- Comment #6 from Tom Misilo <misilot@fit.edu> --- I can reproduce this 3.19.00.016. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org