[Bug 15230] New: Remove unused file circ/stats.pl from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Bug ID: 15230 Summary: Remove unused file circ/stats.pl from system Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org circ/stats.pl and koha-tmpl/intranet-tmpl/prog/en/modules/circ/stats.tt seem not to be used. To verify: git grep '/stats.pl' koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt:<!-- <li> <a href="/cgi-bin/koha/circ/stats.pl?time=yesterday">Daily koha-tmpl/intranet-tmpl/prog/en/modules/circ/stats.tt: <li><a href="/cgi-bin/koha/circ/stats.pl?time=yesterday">yesterday</a></l koha-tmpl/intranet-tmpl/prog/en/modules/circ/stats.tt: <li><a href="/cgi-bin/koha/circ/stats.pl?time=today">today</a></li> The reference to stats.pl in circulation-home.tt is commented out. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 45069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45069&action=edit Bug 15230: Remove unused file circ/stats.pl and stats.tt from system This patch removes stats.pl and stats.tt from system. To test: - Verify that both files are not used and that the only reference in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt is commented out. - Apply patch - Verify that the files are deleted and the reference is removed. - git grep 'stats.pl', verify that there are no more references to this file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45069|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45123&action=edit [SIGNED-OFF] Bug 15230: Remove unused file circ/stats.pl and stats.tt from system This patch removes stats.pl and stats.tt from system. To test: - Verify that both files are not used and that the only reference in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt is commented out. - Apply patch - Verify that the files are deleted and the reference is removed. - git grep 'stats.pl', verify that there are no more references to this file. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45123|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45148&action=edit Bug 15230: Remove unused file circ/stats.pl and stats.tt from system This patch removes stats.pl and stats.tt from system. To test: - Verify that both files are not used and that the only reference in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt is commented out. - Apply patch - Verify that the files are deleted and the reference is removed. - git grep 'stats.pl', verify that there are no more references to this file. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> See the following commit for more info on this script: commit 60105bd692a07639f275543365acfca4f464c1a2 Date: Tue Jul 8 20:02:34 2008 -0500 fix for 2008: Daily reconciliation report broken -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2008 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master! Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org