[Bug 15469] New: The authority header search is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Bug ID: 15469 Summary: The authority header search is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 15381 Introduced by bug 15381. The logs contain plenty of "detail.pl: No method value!" and the dropwdown list is not correctly populated (no value for options). Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46248&action=edit Bug 15469: Fix authority header search Introduced by bug 15381. The logs contain plenty of "detail.pl: No method value!" and the dropwdown list is not correctly populated (no value for options) Test plan: Go to the authority module and have a look at the auth type codes dropdown list. Without this patch, the values of the options are empty. With this patch, the values are correctly filled. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46248|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 46249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46249&action=edit Bug 15469: Fix authority header search Introduced by bug 15381. The logs contain plenty of "detail.pl: No method value!" and the dropwdown list is not correctly populated (no value for options) Test plan: Go to the authority module and have a look at the auth type codes dropdown list. Without this patch, the values of the options are empty. With this patch, the values are correctly filled. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I confirm this patch silence noise in log file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- I was just about to file a new bug for this. I confirm that the patch solves the issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46249|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 46344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46344&action=edit Bug 15469: Fix authority header search Introduced by bug 15381. The logs contain plenty of "detail.pl: No method value!" and the dropwdown list is not correctly populated (no value for options) Test plan: Go to the authority module and have a look at the auth type codes dropdown list. Without this patch, the values of the options are empty. With this patch, the values are correctly filled. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I confirm this patch silence noise in log file. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The authority header search |Authority header search is |is broken |broken CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, this is not quite working for me. I see the same with and without the patch: MARC21 installation. Staff > Authorities Switching tabs in the search bar: Search entire record - pull down remains empty All other tabs - pull down is filled -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46383&action=edit Bug 15469: Same fix for the "entire record" tab -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Almost there - just one small inconsistency - the last tab shows the 'chronological term' preselected, while all others show 'default'. Can you take a quick look if that's an easy fix? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #7)
Almost there - just one small inconsistency - the last tab shows the 'chronological term' preselected, while all others show 'default'. Can you take a quick look if that's an easy fix?
I have Default preselected for the 4 tabs. Are you sure it comes from this patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm not sure what else it could, but will retest. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like you are right - it was wrong before! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 46468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46468&action=edit [PASSED QA] Bug 15469: Fix authority header search Introduced by bug 15381. The logs contain plenty of "detail.pl: No method value!" and the dropwdown list is not correctly populated (no value for options) Test plan: Go to the authority module and have a look at the auth type codes dropdown list. Without this patch, the values of the options are empty. With this patch, the values are correctly filled. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I confirm this patch silence noise in log file. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 46469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46469&action=edit [PASSED QA] Bug 15469: Same fix for the "entire record" tab Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Attachment #46344|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46383|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Does not concern stable versions, changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org