[Bug 32283] New: Capitalization: opac users of this domain to login with this identity provider
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 Bug ID: 32283 Summary: Capitalization: opac users of this domain to login with this identity provider Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org opac is an abbreviation and needs to be written in capitals: OPAC koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt:261 opac users of this domain to login with this identity provider -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com Assignee|oleonard@myacpl.org |andrew.auld@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144158&action=edit Bug 32283: Correct capitalisation of opac > OPAC Test plan Step 1: Navigate to admin>Identity Providers Step 2: Add new domain Step 3: For 'Allow opac' setting, verify that opac is lower case in both label and description Step 4: Apply patch Step 5: Navigate to admin>Identity Providers Step 6: Add new domain Step 7: For 'Allow OPAC' setting, verify that OPAC is upper case in both label and description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another one coming in via github pull request and then transferred via my systems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 --- Comment #3 from Andrew Auld <andrew.auld@ptfs-europe.com> --- I actually fixed a label on this as well as the description. See test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@informaticsgloba | |l.com, | |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144158|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 144180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144180&action=edit Bug 32283: Correct capitalisation of opac > OPAC Test plan Step 1: Navigate to admin>Identity Providers Step 2: Add new domain Step 3: For 'Allow opac' setting, verify that opac is lower case in both label and description Step 4: Apply patch Step 5: Navigate to admin>Identity Providers Step 6: Add new domain Step 7: For 'Allow OPAC' setting, verify that OPAC is upper case in both label and description Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144180|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 144181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144181&action=edit Bug 32283: Correct capitalisation of opac > OPAC Test plan Step 1: Navigate to admin>Identity Providers Step 2: Add new domain Step 3: For 'Allow opac' setting, verify that opac is lower case in both label and description Step 4: Apply patch Step 5: Navigate to admin>Identity Providers Step 6: Add new domain Step 7: For 'Allow OPAC' setting, verify that OPAC is upper case in both label and description Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 144182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144182&action=edit Bug 32283: (follow-up) Fix in two other places Fix two other occurences where the capitalization of OPAC is incorrect: - Identity provider email domains table column heading - 'New email domain' form label Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- I added a follow-up after signing off, I hope that is OK! Two fixes were required: - Identity provider email domains table column heading: should also be 'Allow OPAC'. - 'New email domain' form: the hint text is right, but the label is in lower case and should also be 'Allow OPAC'. Testing notes: 1. Go to Administration > Additional parameters > Identity providers. 2. Add a 'New identity provider' 3. Once added, select the 'Manage Domains' action for the identity provider. 4. Edit the existing "Identity provider email domains" entry: ==> after the patch is applied, OPAC is now in upper case for the 'Allow OPAC' label and hint text. 5. Note that for the "Identity provider email domains" table, the column heading is 'Allow opac' instead of 'Allow OPAC'. 6. Add a 'New email domain' got the identity provider, note that the label is 'Allow opac' (the hint text is correct). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 --- Comment #8 from David Nind <david@davidnind.com> --- I also noted that for the forms in koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt, the '<label for="allow_opac">' is used for the 'Allow staff' form field on lines 158 and 264. I don't know enough about these forms, but should that be '<label for="allow_staff">' instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 --- Comment #9 from Andrew Auld <andrew.auld@ptfs-europe.com> --- I can fix those too. Should I do that under this bug? @David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 --- Comment #10 from David Nind <david@davidnind.com> --- (In reply to Andrew Auld from comment #9)
I can fix those too. Should I do that under this bug? @David
Maybe better as a separate bug I think - as it is different from fixing the capitalisation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144181|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144423&action=edit Bug 32283: Correct capitalisation of opac > OPAC Test plan Step 1: Navigate to admin>Identity Providers Step 2: Add new domain Step 3: For 'Allow opac' setting, verify that opac is lower case in both label and description Step 4: Apply patch Step 5: Navigate to admin>Identity Providers Step 6: Add new domain Step 7: For 'Allow OPAC' setting, verify that OPAC is upper case in both label and description Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144182|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144424&action=edit Bug 32283: (follow-up) Fix in two other places Fix two other occurences where the capitalization of OPAC is incorrect: - Identity provider email domains table column heading - 'New email domain' form label Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 --- Comment #14 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.00 |23.05.00,22.11.01 released in| | CC| |jacob.omara@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org