http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #7)

(In reply to comment #6)

...

We can have a cronjob that runs nightly to remove any expired debarments, and reset the borrowers.debarment field to 0 if the borrower no longer has any active debarments.

If we're relying on a cron job to remove debarments, then I wonder why we bother with the extra table? Why not run a cron job which checks for borrowers with no overdues for whom borrowers.debarred = '9999-12-31' ? This would exclude patrons which were restricted under a suspension in days rule.

If we're trying to exclude patrons for whom borrowers.debarred was set manually, maybe we need to instead create a new flag for manual restriction?

I guess my idea is to have a more flexible and extensible system. Having multiple debarment fields in the borrowers table seems kludgy to me. What if a borrower is debarred for different reasons at different branches? With my proposed design, we could allow patrons to be debarred at only specific libraries if we add a branch code to the debarments table. I guess I'm just making the case that it would be better to in the long run to develop a separate table rather than keep adding more fields to the borrowers table. If plack ever becomes the primary way to run Koha, we wouldn't even need a 'quick' flag in the borrowers table, as the result could be cached. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.