[Bug 12576] New: search links need style id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Bug ID: 12576 Summary: search links need style id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 29687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29687&action=edit link color hard to read When on the advanced search the links next to the search box need a class or ID so that they can be styled. For example, the link color in the attached image would be better white, but there is no ID to grab on to like this is on the moresearches box at the top. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Sean Hamlin <seanh@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |seanh@catalyst.net.nz Assignee|oleonard@myacpl.org |seanh@catalyst.net.nz --- Comment #1 from Sean Hamlin <seanh@catalyst.net.nz> --- Created attachment 30065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30065&action=edit proposed patch I have added bootstrap classes to the links, and made them 'btn-default' which means they will appear grey (and less prominent than "Search". I have re-compiled the LESS, and have that in the patch too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 --- Comment #2 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 30489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30489&action=edit Attachment to Bug 12576 - search links need style id [SIGNED OFF] Bug 12576: Make the more/fewer options and "new search" links on the advanced search page look better. How to test: 1/ Visit /cgi-bin/koha/opac-search.pl 2/ Assert the "More/Fewer options" buttons look like bootstrap default buttons 3/ Assert the "New search" button looks like a bootstrap default button 4/ Assert the visited colour of the buttons remains #333 (light grey) 5/ Assert the buttons still function as expected Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30065|0 |1 is obsolete| | CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Nick Clemens <nick@quecheelibrary.org> --- All worked as expected and looks great -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30489|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31071&action=edit Bug 12576: Make the more/fewer options and "new search" links on the advanced search page look better. How to test: 1/ Visit /cgi-bin/koha/opac-search.pl 2/ Assert the "More/Fewer options" buttons look like bootstrap default buttons 3/ Assert the "New search" button looks like a bootstrap default button 4/ Assert the visited colour of the buttons remains #333 (light grey) 5/ Assert the buttons still function as expected Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31072&action=edit Bug 12576: Update opac.css file This file had a conflict. I prefer to put the changes in a specific commit. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31072|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31073&action=edit Bug 12576: Update opac.css file This file had a conflict. I prefer to put the changes in a specific commit. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #5)
Created attachment 31072 [details] [review]
I forgot the --compress flag -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Sean! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org