[Bug 17583] New: Use Koha::Patron->is_expired from circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Bug ID: 17583 Summary: Use Koha::Patron->is_expired from circulation.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 17579 Bug 17579 introduces a Koha::Patron->is_expired method. We should use it from the circulation page Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 [Bug 17579] Add the Koha::Patron->is_expired method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57329&action=edit Bug 17583: Use Koha::Patron->is_expired from the circulation page Bug 17579 introduces a Koha::Patron->is_expired method. Let's use it from this script. Test plan: Confirm that you see the message on the interface from the circulation page for an expired patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57330&action=edit Bug 17583: Add the Koha::Patron->is_going_to_expired method In order to be consistent, we need to create this method as well. Test plan: Make sure the pref NotifyBorrowerDeparture works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57330|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57334&action=edit Bug 17583: Add the Koha::Patron->is_going_to_expired method In order to be consistent, we need to create this method as well. Test plan: Make sure the pref NotifyBorrowerDeparture works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17585 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 [Bug 17585] Add the Koha::Patron->get_account_lines method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57364&action=edit Bug 17583: Add test for is_going_to _expired to be true -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- I think you should substract, not add the number of days from NotifyBorrowerDeparture syspref in is_going_to_expired method. I tried to share a test to highlight it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57380&action=edit Bug 17583: Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Thanks Jonathan, but there is another issue as I discovered now, let me describe it: It looks like Koha used to "think" that when dateexpiry = today, than membership has expired... That's bug from my point of view... Your code continue to behave the same way - that's the reason why 2 tests of subtest 'is_going_to_expired' are failing - at least on my machine... We just need to decide: Is it a bug? Should we fix it on this report or open the new bug report (probably better, but we'd have failing Patrons test on master...) What do you think? Sorry for complicating things... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57380|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57384&action=edit Bug 17583: Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes I have seen that. The current behavior is: If dateexpiry = today => not going to expired If pref is 0 => not going to expired If dateexpiry - pref = today => not going to expired. I am not sure this is the correct behavior, but I want to keep this behavior after this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is something wrong again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57387&action=edit Bug 17583: Make sure we are comparing 2 dates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- This doesn't works for me, the test returns: # Failed test 'Patron should not be considered going to expire if dateexpiry is today' # at t/db_dependent/Koha/Patrons.t line 195. # got: '1' # expected: '0' # Looks like you failed 1 test of 9. It's this test: 195 is( $patron->is_going_to_expired, 0, 'Patron should not be considered going to expire if dateexpiry is today'); Testing on top of Bug 17594 and Bug 17579 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57488&action=edit Bug 17583: Mock the pref before tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57329|0 |1 is obsolete| | Attachment #57334|0 |1 is obsolete| | Attachment #57364|0 |1 is obsolete| | Attachment #57384|0 |1 is obsolete| | Attachment #57387|0 |1 is obsolete| | Attachment #57488|0 |1 is obsolete| | --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57523&action=edit [SIGNED-OFF] Bug 17583: Use Koha::Patron->is_expired from the circulation page Bug 17579 introduces a Koha::Patron->is_expired method. Let's use it from this script. Test plan: Confirm that you see the message on the interface from the circulation page for an expired patron Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57524&action=edit [SIGNED-OFF] Bug 17583: Add the Koha::Patron->is_going_to_expired method In order to be consistent, we need to create this method as well. Test plan: Make sure the pref NotifyBorrowerDeparture works as expected Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57525&action=edit [SIGNED-OFF] Bug 17583: Add test for is_going_to _expired to be true Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57526&action=edit [SIGNED-OFF] Bug 17583: Fix tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57527&action=edit [SIGNED-OFF] Bug 17583: Make sure we are comparing 2 dates Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57528&action=edit [SIGNED-OFF] Bug 17583: Mock the pref before tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Applying: Bug 17583: Add the Koha::Patron->is_going_to_expired method fatal: sha1 information is lacking or useless (Koha/Patron.pm). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57888&action=edit Bug 17583: Use Koha::Patron->is_expired from the circulation page Bug 17579 introduces a Koha::Patron->is_expired method. Let's use it from this script. Test plan: Confirm that you see the message on the interface from the circulation page for an expired patron Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57889&action=edit Bug 17583: Add the Koha::Patron->is_going_to_expired method In order to be consistent, we need to create this method as well. Test plan: Make sure the pref NotifyBorrowerDeparture works as expected Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57890&action=edit Bug 17583: Add test for is_going_to _expired to be true Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57891&action=edit Bug 17583: Fix tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57892&action=edit Bug 17583: Make sure we are comparing 2 dates Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57893&action=edit Bug 17583: Mock the pref before tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57523|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57524|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57525|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57526|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57527|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57528|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57888|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57914&action=edit Bug 17583: Use Koha::Patron->is_expired from the circulation page Bug 17579 introduces a Koha::Patron->is_expired method. Let's use it from this script. Test plan: Confirm that you see the message on the interface from the circulation page for an expired patron Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57889|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57915&action=edit Bug 17583: Add the Koha::Patron->is_going_to_expired method In order to be consistent, we need to create this method as well. Test plan: Make sure the pref NotifyBorrowerDeparture works as expected Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57890|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57916&action=edit Bug 17583: Add test for is_going_to _expired to be true Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57891|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57917&action=edit Bug 17583: Fix tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57892|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57918&action=edit Bug 17583: Make sure we are comparing 2 dates Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57893|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57919&action=edit Bug 17583: Mock the pref before tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57920&action=edit Bug 17583: [QA Follow-up] Final polishing Number of tests in Patrons.t corrected. Method is_going_to_expired (no english!) renamed to is_going_to_expire. Adding a negative duration replaced by a subtract. Reads easier. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17,05, thanks Jonathan, Josef, Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org