[Bug 40602] New: Broken HTML showing in Alert 'subscriptions' tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Bug ID: 40602 Summary: Broken HTML showing in Alert 'subscriptions' tab Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org In the "Alert subscriptions" tab in the OPAC there is broken HTML showing on the page, maybe from a merge conflict, because it doesn't actually make sense, to display the name in that spot. To test: * Add a serial subscription and set a notification template * Go to the OPAC and subscribe to the email notification for this subscription (you must be logged in to see the button on the subscriptions tab) * Go to the patron account > tab alert subscriptions * Verify in the last column something like this shows: Frau Karin Mustermann"> X Unsubscribe from email alerts The "Frau Karin Mustermann">" should not be there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In order to reproduce this: Make sure you are testing with a user, that has a salutation, surname and firstname set. The problem is patroninfo creating HTML tags even with the no_html flag set it looks like: <form action="/cgi-bin/koha/opac-alert-subscribe.pl" method="post" class="unsubscribe" data-title="[% sub.biblio.title | html %] [% sub.biblio.subtitle | html %]" data-patron="[% INCLUDE 'patron-title.inc' no_html=1 patron=logged_in_user%]"> Generates: <form action="/cgi-bin/koha/opac-alert-subscribe.pl" method="post" class="unsubscribe" data-title="Kölner Zeitschrift für Soziologie und Sozialpsychologie, " data-patron=" <span class="patron-title">Frau</span> Karin Mustermann"> ... Which is invalid because of the "" and also there should be NO HTML tags. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, OK; there is no no_html flag for patron_title.inc in the OPAC: https://git.koha-community.org/Koha-community/Koha/src/commit/5832521086b06c... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've temporarily switched to [% logged_in_user.firstname %] [% logged_in_user.surname %] which seems to avoid the issue for now. Just switching the " for ' leaves a broken confirmation message. I think we need to implement a no_html flag for patron_title.inc in the OPAC to properly fix this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185746&action=edit Bug 40602: Broken HTML showing in Alert 'subscriptions' tab This patch adds handling of the "no-html" flag to patron-title.inc. The OPAC alert subscriptions page passes the "no-html" flag but the include file wasn't written to include it. To test, apply the patch and log in to the OPAC as a user who has a title (salutation). - Add a serial subscription and set a notification template - Go to the OPAC and subscribe to the email notification for this subscription - Go to the patron account > Alert subscriptions tab - Verify that the last column shows an "Unsubscribe from email alerts" button. - There should be no errant HTML. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Noah <noah.tremblay@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185746|0 |1 is obsolete| | --- Comment #5 from Noah <noah.tremblay@inlibro.com> --- Created attachment 186169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186169&action=edit Bug 40602: Broken HTML showing in Alert 'subscriptions' tab This patch adds handling of the "no-html" flag to patron-title.inc. The OPAC alert subscriptions page passes the "no-html" flag but the include file wasn't written to include it. To test, apply the patch and log in to the OPAC as a user who has a title (salutation). - Add a serial subscription and set a notification template - Go to the OPAC and subscribe to the email notification for this subscription - Go to the patron account > Alert subscriptions tab - Verify that the last column shows an "Unsubscribe from email alerts" button. - There should be no errant HTML. Sponsored-by: Athens County Public Libraries Signed-off-by: noah <noah@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Ludovic <ludovic.julien@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |ludovic.julien@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Noah, I notice that your sign-off line is: Signed-off-by: noah <noah@inlibro.com> For the dashboard and the release notes we can do a mail map to your full name, but you might also consider to change your git setting to have it in the patches themselves. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186169|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 186372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186372&action=edit Bug 40602: Broken HTML showing in Alert 'subscriptions' tab This patch adds handling of the "no-html" flag to patron-title.inc. The OPAC alert subscriptions page passes the "no-html" flag but the include file wasn't written to include it. To test, apply the patch and log in to the OPAC as a user who has a title (salutation). - Add a serial subscription and set a notification template - Go to the OPAC and subscribe to the email notification for this subscription - Go to the patron account > Alert subscriptions tab - Verify that the last column shows an "Unsubscribe from email alerts" button. - There should be no errant HTML. Sponsored-by: Athens County Public Libraries Signed-off-by: noah <noah@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks a lot Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Noah Tremblay <noah.tremblay@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noah.tremblay@inlibro.com --- Comment #9 from Noah Tremblay <noah.tremblay@inlibro.com> --- Hi Catherine, Sorry about that — I’ve updated my Git settings so my future sign-off lines will have my full name. Thanks for pointing it out! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186372|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186433&action=edit Bug 40602: Broken HTML showing in Alert 'subscriptions' tab This patch adds handling of the "no-html" flag to patron-title.inc. The OPAC alert subscriptions page passes the "no-html" flag but the include file wasn't written to include it. To test, apply the patch and log in to the OPAC as a user who has a title (salutation). - Add a serial subscription and set a notification template - Go to the OPAC and subscribe to the email notification for this subscription - Go to the patron account > Alert subscriptions tab - Verify that the last column shows an "Unsubscribe from email alerts" button. - There should be no errant HTML. Sponsored-by: Athens County Public Libraries Signed-off-by: Noah Tremblay <noah.tremblay@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Keywords| |additional_work_needed --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Heuuu The line : - <span class="patron-title">[% patron.title | html %]</span> Becomes : + <span class="patron-title"></span> So there is no content. I bet this is not what we want. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Yeah, this really looks weird. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.12 released in| | Status|Pushed to stable |Pushed to oldstable CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #15 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.12 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |ASSIGNED Version(s)|25.11.00,25.05.04,24.11.12 |25.11.00,25.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 --- Comment #16 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Still not pushed, additional work needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41810 [Bug 41810] Missing patron.title from Bug 40602 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #16)
Still not pushed, additional work needed
Since this is in released versions I think we should do the follow-up here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41810 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192938&action=edit Bug 40602: [25.05.x] Broken HTML showing in Alert 'subscriptions' tab This patch adds handling of the "no-html" flag to patron-title.inc. The OPAC alert subscriptions page passes the "no-html" flag but the include file wasn't written to include it. To test, apply the patch and log in to the OPAC as a user who has a title (salutation). - Add a serial subscription and set a notification template - Go to the OPAC and subscribe to the email notification for this subscription - Go to the patron account > Alert subscriptions tab - Verify that the last column shows an "Unsubscribe from email alerts" button. - There should be no errant HTML. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Patch for 25.05.x looks OK since different from patch for main. But current commit looks KO : https://git.koha-community.org/Koha-community/Koha/commit/1a1fc99f36440ee18e... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.14 released in| | --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Commit on 24.11.x : https://git.koha-community.org/Koha-community/Koha/commit/188161385acafd5837... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40602 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org