[Bug 41249] New: ILL batches should be compatible with AutoILLBackendPriority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Bug ID: 41249 Summary: ILL batches should be compatible with AutoILLBackendPriority Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, pedro.amorim@openfifth.co.uk, tomascohen@gmail.com AutoILLBackendPriority suggests the top most available backend in priority when creating a new ILL request. This should also work the same when creating requests through the ILL batches functionality. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edith.speller@ukhsa.gov.uk, | |jeremy.evans@ukhsa.gov.uk, | |richard.bridgen@nhs.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41247 [Bug 41247] ILL batches modal does not reset correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189619&action=edit Bug 41249: Preparation Move confirmauto logic to earlier in controller This is in order to be able to have a have_batch_auto_backends_json which contains all backends that are compatible with both: A) AutoILLBackendPriority sys pref and B) ILL batches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189620&action=edit Bug 41249: Update toolbar batches button logic Same behaviour as regular 'new ILL request' button, i.e. if AutoILLBackendPriorty sys pref is being used, do not present the backend options upon clicking 'new batch' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189621&action=edit Bug 41249: Auto backend batch modal column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189622&action=edit Bug 41249: Add cypress tests cypress run --spec t/cypress/integration/ILL/Batches_spec.ts Test plan: 1) Enable ILLModule 2) Install a backend compatible with ILL batches + AutoILLBackendPriority sys pref: https://github.com/openfifth/koha-ill-backend-plugin/releases/tag/v2.0.8 3) Install a metadata enrichment plugin (required for ILL batches): https://github.com/openfifth/koha-plugin-api-pubmed/releases/tag/1.1.1 4) Enable AutoILLBackendPriority sys pref by checking 'PluginBackend' 5) Visit the ILL module: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 6) Notice the 'New ILL requests batch' shows. Click that. 7) Enter any name, '42' for cardnumber and any library. Click 'Continue'. 8) On t'he textarea that shows enter the following pubmed IDs (separated by new line) 123 321 456 9) Notice that PluginBackend will sometimes be red, sometimes be yellow and sometimes be green. This is a test backend and that will happen randomly. Repeat step 8) for more test result samples. 10) Notice that, when green, PluginBackend will be pre-selected. When yellow, it'll allow you to select it but not pre-select it and when red doesnt allow it to be selected at all. 11) Play around with the selection of backends and click 'Add items to batch' and verify that each request was created in the respective selected backend. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 195489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195489&action=edit Bug 41249: (QA follow-up): Enlarge modal width Because we now have more columns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #6 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196999&action=edit Bug 41249: (QA follow-up): Update tableContent.data based on selected backend Patch from commit 45ee426 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197000&action=edit Bug 41249: (QA follow-up): Simplify picking the correct backend Now that it is stored in tableContent.data we no longer need to query the DOM directly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #8 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197004&action=edit Bug 41249: (QA follow-up) Accessibility improvements This change makes components more spaced and utilizes more appropriate icons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #9 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197089&action=edit Bug 41249: (QA follow-up): Fix editing batches Ensure the cardnumber is correctly filled when editing an existing batch. To test: 1) Edit an existing batch 2) Verify the 'cardnumber' input contains the patron cardnumber 3) Add some DOIs or PubmedIDs 4) Click 'Add items to batch' and confirm that the requests are created correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #10 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197090&action=edit Bug 41249: (QA follow-up): Trim input To skip error complains if there happens to be a new line at the end of the identifiers list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189619|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189620|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189621|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189622|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195489|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196999|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197000|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197004|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197089|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197090|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #11 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197143&action=edit Bug 41249: Preparation Move confirmauto logic to earlier in controller This is in order to be able to have a have_batch_auto_backends_json which contains all backends that are compatible with both: A) AutoILLBackendPriority sys pref and B) ILL batches Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #12 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197144&action=edit Bug 41249: Update toolbar batches button logic Same behaviour as regular 'new ILL request' button, i.e. if AutoILLBackendPriorty sys pref is being used, do not present the backend options upon clicking 'new batch' Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #13 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197145&action=edit Bug 41249: Auto backend batch modal column Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #14 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197146&action=edit Bug 41249: Add cypress tests cypress run --spec t/cypress/integration/ILL/Batches_spec.ts Test plan: 1) Enable ILLModule 2) Install a backend compatible with ILL batches + AutoILLBackendPriority sys pref: https://github.com/openfifth/koha-ill-backend-plugin/releases/tag/v2.0.8 3) Install a metadata enrichment plugin (required for ILL batches): https://github.com/openfifth/koha-plugin-api-pubmed/releases/tag/1.1.1 4) Enable AutoILLBackendPriority sys pref by checking 'PluginBackend' 5) Visit the ILL module: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 6) Notice the 'New ILL requests batch' shows. Click that. 7) Enter any name, '42' for cardnumber and any library. Click 'Continue'. 8) On t'he textarea that shows enter the following pubmed IDs (separated by new line) 123 321 456 9) Notice that PluginBackend will sometimes be red, sometimes be yellow and sometimes be green. This is a test backend and that will happen randomly. Repeat step 8) for more test result samples. 10) Notice that, when green, PluginBackend will be pre-selected. When yellow, it'll allow you to select it but not pre-select it and when red doesnt allow it to be selected at all. 11) Play around with the selection of backends and click 'Add items to batch' and verify that each request was created in the respective selected backend. Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #15 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197147&action=edit Bug 41249: (QA follow-up): Enlarge modal width Because we now have more columns Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #16 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197148&action=edit Bug 41249: (QA follow-up): Update tableContent.data based on selected backend Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #17 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197149&action=edit Bug 41249: (QA follow-up): Simplify picking the correct backend Now that it is stored in tableContent.data we no longer need to query the DOM directly Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #18 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197150&action=edit Bug 41249: (QA follow-up) Accessibility improvements This change makes components more spaced and utilizes more appropriate icons Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #19 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197151&action=edit Bug 41249: (QA follow-up): Fix editing batches Ensure the cardnumber is correctly filled when editing an existing batch. To test: 1) Edit an existing batch 2) Verify the 'cardnumber' input contains the patron cardnumber 3) Add some DOIs or PubmedIDs 4) Click 'Add items to batch' and confirm that the requests are created correctly Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #20 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197152&action=edit Bug 41249: (QA follow-up): Trim input To skip error complains if there happens to be a new line at the end of the identifiers list Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42980 [Bug 42980] ILL Batches: Have a 'select for all' option when using AutoILLBackendPriority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #21 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 201429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201429&action=edit Bug 41249: Update cypress tests Remove obsolete XML task calls from Batches_spec.ts and fix "Koha administration" readXmlElementValue and modifyXmlElement no longer exist as Cypress tasks. The plugins_restricted guard they provided is unnecessary since KTD always runs with plugins_restricted=0. cypress run --spec t/cypress/integration/ILL/Batches_spec.ts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 --- Comment #22 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 207284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207284&action=edit Bug 41249: (follow-up) Fix TypeError when auto backends are unavailable row.auto_backends stays {} when AutoILLBackendPriority yields no batch backends, so .find throws. Guard with Array.isArray. Test plan: 1) Clear AutoILLBackendPriority, add items to a new ILL batch 2) Note TypeError, apply patch, repeat, requests are created Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org