[Bug 36151] New: Update leaflet.js to current version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Bug ID: 36151 Summary: Update leaflet.js to current version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: domm@plix.at QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Koha comes with leaflet.js 1.0.3 which is quite old. We need a current leaflet for Bug 31652, so we propose to upgrade to the current version 1.9.4 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 [Bug 31652] Add geo-search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #1 from Thomas Klausner <domm@plix.at> --- The patch is too big for bugzilla, please find it here: https://github.com/domm/Koha/commit/baa24a31d61e2435dc287c0f39646cf7dc2ad49e Bug 36151: Update leaflet.js Koha currently comes with leaflet.js 1.0.3 which is quite old (2017). For GeoSearch (Bug 31652) we need a more current leaflet.js, so this patch updates leaflet.js to the current version 1.9.4 Test plan: * Go to staff /cgi-bin/koha/admin/usage_statistics.pl where you see a map and can set the location of the library by clicking on the map. * Apply the patch * Again, go to staff /cgi-bin/koha/admin/usage_statistics.pl * Do a complete reload of the page * It should still work: * Display the location as a pin * Set a new location There was no code change necessary besides downloading the current version of leaflet.js Sponsored-by: Geosphere Austria -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Thomas Klausner from comment #1)
There was no code change necessary besides downloading the current version of leaflet.js
The about page will need an update to change the number where it says "Leaflet JavaScript library v1.0.3." I have tried where possible to link the license information for that particular release, e.g. https://github.com/Leaflet/Leaflet/blob/v1.9.4/LICENSE, since it's possible licenses could change. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |domm@plix.at |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 --- Comment #3 from Thomas Klausner <domm@plix.at> --- New patch including an update About-page (new version, link to current LICENSE) is available here: https://github.com/domm/Koha/commit/dfa518981fd8327e4ec07ad726496267018b140b Bug 36151: Update leaflet.js Koha currently comes with leaflet.js 1.0.3 which is quite old (2017). For GeoSearch (Bug 31652) we need a more current leaflet.js, so this patch updates leaflet.js to the current version 1.9.4 Test plan: * Go to staff /cgi-bin/koha/admin/usage_statistics.pl where you see a map and can set the location of the library by clicking on the map. * Apply the patch * Again, go to staff /cgi-bin/koha/admin/usage_statistics.pl * Do a complete reload of the page * It should still work: * Display the location as a pin * Set a new location There was no code change necessary besides downloading the current version of leaflet.js and updating the about-page Sponsored-by: Geosphere Austria -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lucas@bywatersolutions.com --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- This works without issue, signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Status|Signed Off |Patch doesn't apply --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- The about.tt change needs a rebase after bug 32693 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/domm/Koh | |a/commit/dfa518981fd8327e4e | |c07ad726496267018b140b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I notice that this uses: Sponsored-by: Geosphere Austria But bug 31652 uses: Geosphere - https://www.geosphere.at/ This will require mappings to make it look nice in Release notes. Please stick to one spelling :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I rebased this, it's quite easy: just kick out the changes in about .pl and re-do them: it's just changing the version number. But of course it's still too large for bugzilla and I currently have no public repo I can push it to and not sure I should use our main repository for this ;) Could someone else take over here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #8)
Could someone else take over here?
https://gitlab.com/koha-dev/koha-dev/-/commits/bug_36151 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Branch with SO's pushed to https://gitlab.com/mrenvoize/Koha/-/commits/bug_36151 All passing QA scripts, works as intended with no regressions I can see. Restored authorship to Thomas. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff interface |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #14 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Module(?) change, nothing to add/edit in the Koha manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org