[Bug 34836] New: OPAC ISBD or MARC view blows up with error 500
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Bug ID: 34836 Summary: OPAC ISBD or MARC view blows up with error 500 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 34694 added check on $patron var for opac-detail.pl Since Bug 30846 also impacts ISBD and MARC views, same check should be made. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34694 [Bug 34694] OPAC bib record blows up with error 500 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|34694 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34694 [Bug 34694] OPAC bib record blows up with error 500 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34694 [Bug 34694] OPAC bib record blows up with error 500 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- I confirm in KTD with test plan of Bug 34694 => Kaboum -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 [Bug 30846] "If any unavailable" doesn't consider negative notforloan values as unavailable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34886 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 156146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156146&action=edit Bug 34836: Add patron check to isbd and marc detail pages Test plan: - Go to circulation rules and set On shelf holds allowed to If all unavailable - Log out - Visit a MARC detail or ISBD detail bib record on OPAC: http://localhost:8080/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=76 http://localhost:8080/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=76 - Notice it blows up with error 500, on both occasions - Apply patch. Repeat. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Only now catching up on bug 34886. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- If what I submitted in bug 34886 makes sense and gets pushed (move the patron check onto C4/Reserves.pm), I think there's nothing to be done here as the issue should be fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156146|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156146|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34886 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I've restored my patch since this is critical and bug 34886 is revealing itself to be a bigger can of worms than originally anticipated. I'm setting bug 34886 as dependent on this one. This is to keep things seperate. This current bug 34836 is to prevent error 500 on the opac marc-detail and isbd-detail when On shelf holds allowed = "If all unavailable". Bug 34886 is to restore "Place hold" link for unauthenticated users. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886 [Bug 34886] Regression in when hold button appears -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I think this should at least be considered for the releases this month. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156146|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 156303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156303&action=edit Bug 34836: Add patron check to isbd and marc detail pages Test plan: - Go to circulation rules and set On shelf holds allowed to If all unavailable - Log out - Visit a MARC detail or ISBD detail bib record on OPAC: http://localhost:8080/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=76 http://localhost:8080/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=76 - Notice it blows up with error 500, on both occasions - Apply patch. Repeat. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an error that release notes| |occurs when viewing the | |MARC and ISBD views of a | |record in the OPAC (when | |not logged in) - the detail | |pages cannot be viewed and | |there is an error trace | |displayed. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Shouldn't this be fixed exactly the same as bug 34886? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #8)
Shouldn't this be fixed exactly the same as bug 34886?
This was my original thinking, hence submitting the patches there originally. But rethinking it, in my current opinion, no. The regression mentioned in bug 34886 was actually caused by bug 30846. It's just that bug 30846 caused the 500 error on the record page (normal, marc and isbd) for the unauthenticated user before the "place hold" link could be even be assessed. Bug 34694 fixed the 500 error for the normal record page (forgetting about marc+isbd), but didn't address the "place hold" link issue, since the "place hold" issue was not detectable before - the page blew up. The fixing of the "place hold" link should be a follow-up to the fixing of the 500 error, hence making the "place hold" bug 34886 now depend on this one. Does this make sense? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156303|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156361&action=edit Bug 34836: Add patron check to isbd and marc detail pages Test plan: - Go to circulation rules and set On shelf holds allowed to If all unavailable - Log out - Visit a MARC detail or ISBD detail bib record on OPAC: http://localhost:8080/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=76 http://localhost:8080/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=76 - Notice it blows up with error 500, on both occasions - Apply patch. Repeat. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |pedro.amorim@ptfs-europe.co | |m QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com --- Comment #13 from Laura O'Neil <laura@bywatersolutions.com> --- Could this also be pushed to 22.11.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Dani Elder <danielle.elder@law.utexas.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle.elder@law.utexas.e | |du -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Claudio Costales <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc@gmail.com --- Comment #14 from Claudio Costales <costalc@gmail.com> --- (In reply to Laura O'Neil from comment #13)
Could this also be pushed to 22.11.x?
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 --- Comment #15 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34836 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rudolfbyker@gmail.com --- Comment #16 from Liz Rea <wizzyrea@gmail.com> --- *** Bug 24574 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org