[Bug 18562] New: There should be a koha-sip script to handle SIP daemons for instances
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Bug ID: 18562 Summary: There should be a koha-sip script to handle SIP daemons for instances Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18114 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114 [Bug 18114] koha-start-* and koha-stop-* should be replaced with the new command style -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84511&action=edit Bug 18562: Add koha-sip maintenance script This patch introduces a single script to handle all actions on SIP servers for Koha instances. It is intended to be a replacement for: - koha-start-sip - koha-stop-sip - koha-enable-sip It adds a function called is_sip_running to koha-functions.sh. To test: - Apply this patch - Run: $ misc4dev/cp_debian_files.pl $ sudo koha-sip --enable kohadev $ sudo koha-sip --start kohadev $ sudo koha-sip --status kohadev => SUCCESS: The SIP server is running for kohadev - Run: $ sudo koha-sip --restart --verbose kohadev $ sudo koha-sip --status kohadev => SUCCESS: The SIP server is running for kohadev - Run: $ sudo koha-sip --stop kohadev $ sudo koha-sip --status kohadev => SUCCESS: The SIP server is not running for kohadev - Play with other combinations like enabling an already enabled instance, etc. Remember you need to remove the /etc/koha/sites/kohadev/SIPconfig.xml file so it is considered disabled. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84512&action=edit Bug 18562: Add manpage for koha-sip This patch adds the manpage for koha-sip. To test: - Apply this patch - Run: $ kshell k$ prove xt/verify-debian-docbook.t => SUCCESS: Tests pass! - Run: $ misc4dev/cp_debian_files.pl $ man koha-sip => SUCCESS: The man page shows correctly. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84513&action=edit Bug 18562: Tab completion in bash This patch adds the fancy tab completion in bash. To test: - Run: $ source debian/koha-common.bash-completion $ sudo koha-sip <tab> - Play with all the options => SUCCESS: The combinations make sense (e.g. only SIP-enabled instances are completed for --start, --stop, --restart, -v and --verbose are not offered if the other one is already in there, --enable only applies to SIP-disabled instances, etc). - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|There should be a koha-sip |Add koha-sip script to |script to handle SIP |handle SIP servers for |daemons for instances |instances -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |magnus@libriotech.no, | |mirko@abunchofthings.net Text to go in the| |To ease multi-tenant sites release notes| |maintenance, several handy | |scripts were introduced. | |For handling SIP servers, 3 | |scripts were introduced: | |koha-start-sip, | |koha-stop-sip and | |koha-enable-sip. | |This patch | |introduces a new script, | |koha-sip, that unifies | |those actions regarding SIP | |servers on a per instance | |base, through the use of | |option switches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22235 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22235 [Bug 22235] Make maintenance scripts use koha-sip instead of koha-*-sip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84511|0 |1 is obsolete| | Attachment #84512|0 |1 is obsolete| | Attachment #84513|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84521&action=edit Bug 18562: Add koha-sip maintenance script This patch introduces a single script to handle all actions on SIP servers for Koha instances. It is intended to be a replacement for: - koha-start-sip - koha-stop-sip - koha-enable-sip It adds a function called is_sip_running to koha-functions.sh. To test: - Apply this patch - Run: $ misc4dev/cp_debian_files.pl $ sudo koha-sip --enable kohadev $ sudo koha-sip --start kohadev $ sudo koha-sip --status kohadev => SUCCESS: The SIP server is running for kohadev - Run: $ sudo koha-sip --restart --verbose kohadev $ sudo koha-sip --status kohadev => SUCCESS: The SIP server is running for kohadev - Run: $ sudo koha-sip --stop kohadev $ sudo koha-sip --status kohadev => SUCCESS: The SIP server is not running for kohadev - Play with other combinations like enabling an already enabled instance, etc. Remember you need to remove the /etc/koha/sites/kohadev/SIPconfig.xml file so it is considered disabled. - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84522&action=edit Bug 18562: Add manpage for koha-sip This patch adds the manpage for koha-sip. To test: - Apply this patch - Run: $ kshell k$ prove xt/verify-debian-docbook.t => SUCCESS: Tests pass! - Run: $ misc4dev/cp_debian_files.pl $ man koha-sip => SUCCESS: The man page shows correctly. - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84523&action=edit Bug 18562: Tab completion in bash This patch adds the fancy tab completion in bash. To test: - Run: $ source debian/koha-common.bash-completion $ sudo koha-sip <tab> - Play with all the options => SUCCESS: The combinations make sense (e.g. only SIP-enabled instances are completed for --start, --stop, --restart, -v and --verbose are not offered if the other one is already in there, --enable only applies to SIP-disabled instances, etc). - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84521|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84951&action=edit Bug 18562: Add koha-sip maintenance script This patch introduces a single script to handle all actions on SIP servers for Koha instances. It is intended to be a replacement for: - koha-start-sip - koha-stop-sip - koha-enable-sip It adds a function called is_sip_running to koha-functions.sh. To test: - Apply this patch - Run: $ misc4dev/cp_debian_files.pl $ sudo koha-sip --enable kohadev $ sudo koha-sip --start kohadev $ sudo koha-sip --status kohadev => SUCCESS: The SIP server is running for kohadev - Run: $ sudo koha-sip --restart --verbose kohadev $ sudo koha-sip --status kohadev => SUCCESS: The SIP server is running for kohadev - Run: $ sudo koha-sip --stop kohadev $ sudo koha-sip --status kohadev => SUCCESS: The SIP server is not running for kohadev - Play with other combinations like enabling an already enabled instance, etc. Remember you need to remove the /etc/koha/sites/kohadev/SIPconfig.xml file so it is considered disabled. - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84522|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84952&action=edit Bug 18562: Add manpage for koha-sip This patch adds the manpage for koha-sip. To test: - Apply this patch - Run: $ kshell k$ prove xt/verify-debian-docbook.t => SUCCESS: Tests pass! - Run: $ misc4dev/cp_debian_files.pl $ man koha-sip => SUCCESS: The man page shows correctly. - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84523|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84953&action=edit Bug 18562: Tab completion in bash This patch adds the fancy tab completion in bash. To test: - Run: $ source debian/koha-common.bash-completion $ sudo koha-sip <tab> - Play with all the options => SUCCESS: The combinations make sense (e.g. only SIP-enabled instances are completed for --start, --stop, --restart, -v and --verbose are not offered if the other one is already in there, --enable only applies to SIP-disabled instances, etc). - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice complete patch which brings consistency. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|To ease multi-tenant sites |To ease multi-tenant sites release notes|maintenance, several handy |maintenance, several handy |scripts were introduced. |scripts were introduced. |For handling SIP servers, 3 |For handling SIP servers, 3 |scripts were introduced: |scripts were introduced: |koha-start-sip, |koha-start-sip, |koha-stop-sip and |koha-stop-sip and |koha-enable-sip. |koha-enable-sip. |This patch |This patch |introduces a new script, |introduces a new script, |koha-sip, that unifies |koha-sip, that unifies |those actions regarding SIP |those actions regarding SIP |servers on a per instance |servers on a per instance |base, through the use of |base, through the use of |option switches. |option switches. | | | |18.11 | |Note: The introduction of | |this script does NOT remove | |the koha-*-sip versions at | |this time and the scripts | |can be used interchangeably | |until one upgrades to 19.05 | |where the koha-*-sip | |versions are officially | |removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement, wont backport to 18.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- sudo koha-sip --start --verbose kohadev [ ok ] Starting Koha Zebra daemon for kohadev:. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also, is that correct? % sudo koha-sip --restart --verbose kohadev Stopping SIP server for kohadev:. Warning: SIP server already running for kohadev:. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22397 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22397 [Bug 22397] Wrong message in koha-sip --start -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22397 | --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #15)
Also, is that correct?
% sudo koha-sip --restart --verbose kohadev Stopping SIP server for kohadev:. Warning: SIP server already running for kohadev:.
Dealt with on bug 22396. Thanks! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22397 [Bug 22397] Wrong message in koha-sip --start -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22397 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22397 [Bug 22397] Wrong message in koha-sip --start -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 [Bug 22396] koha-sip script does not start the server correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #14)
sudo koha-sip --start --verbose kohadev [ ok ] Starting Koha Zebra daemon for kohadev:.
Dealt with on bug 22397. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pongtawat@punsarn.asia --- Comment #18 from Magnus Enger <magnus@libriotech.no> --- *** Bug 19962 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|To ease multi-tenant sites |To ease multi-tenant sites release notes|maintenance, several handy |maintenance, several handy |scripts were introduced. |scripts were introduced. |For handling SIP servers, 3 |For handling SIP servers, 3 |scripts were introduced: |scripts were introduced: |koha-start-sip, |koha-start-sip, |koha-stop-sip and |koha-stop-sip and |koha-enable-sip. |koha-enable-sip. |This patch |This patch |introduces a new script, |introduces a new script, |koha-sip, that unifies |koha-sip, that unifies |those actions regarding SIP |those actions regarding SIP |servers on a per instance |servers on a per instance |base, through the use of |base, through the use of |option switches. |option switches. | | |18.11 | |Note: The introduction of | |this script does NOT remove | |the koha-*-sip versions at | |this time and the scripts | |can be used interchangeably | |until one upgrades to 19.05 | |where the koha-*-sip | |versions are officially | |removed. | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org