[Bug 29093] New: Article requests: Checkbox for table of contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Bug ID: 29093 Summary: Article requests: Checkbox for table of contents Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If you allow copying or scanning parts of books, a very common question is: I would like to receive a copy/scan of the table of contents. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch set adds a new release notes| |article request column for | |a request to copy or scan | |table of contents. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125190&action=edit Bug 29093: Database revision for article_requests.toc_request Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125191&action=edit Bug 29093: {DO NOT PUSH] DBIx schema changes Note: Pending table changes in PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125192&action=edit Bug 29093: Interface changes Show the TOC checkbox on OPAC and staff. Test plan: Add new article request on OPAC or staff. Tick checkbox. Verify if TOC is Yes on opac-user or staff patron details. Check the list view on circ/article-requests.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125190|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 125288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125288&action=edit Bug 29093: Database revision for article_requests.toc_request Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125191|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 125289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125289&action=edit Bug 29093: {DO NOT PUSH] DBIx schema changes Note: Pending table changes in PQA. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125192|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 125290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125290&action=edit Bug 29093: Interface changes Show the TOC checkbox on OPAC and staff. Test plan: Add new article request on OPAC or staff. Tick checkbox. Verify if TOC is Yes on opac-user or staff patron details. Check the list view on circ/article-requests.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #6)
Signed-off-by: David Nind <david@davidnind.com>
Thx David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125288|0 |1 is obsolete| | Attachment #125290|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125448&action=edit Bug 29093: Database revision for article_requests.toc_request Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125449&action=edit Bug 29093: Interface changes Show the TOC checkbox on OPAC and staff. Test plan: Add new article request on OPAC or staff. Tick checkbox. Verify if TOC is Yes on opac-user or staff patron details. Check the list view on circ/article-requests.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- A few things to mention, not blockers: 1 - The DBIC patch includes changes from other bugs, I had to generate my own for testing 2 - Why TINYINT(4) - it seems to be treated as a TINYINT(1) / Boolean? 3 - While it makes display easier, is TOC friendly for translations? It would be nice to have a hover text with the full 'Table of Contents' at least -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #10) Thanks !
A few things to mention, not blockers: 1 - The DBIC patch includes changes from other bugs, I had to generate my own for testing Yes, sorry for that. But the RM will disregard it anyway and do a fresh DBIx update.
2 - Why TINYINT(4) - it seems to be treated as a TINYINT(1) / Boolean? Tinyint is just a byte. The four positions is display width and actually irrelevant for our templates. But theoretically, you are right :)
3 - While it makes display easier, is TOC friendly for translations? It would be nice to have a hover text with the full 'Table of Contents' at least
Good point. Will have a look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125450&action=edit Bug 29093: (QA follow-up) Adding two hover texts See QA request. Adding TOC hover text to: - OPAC user page, tab Article requests - Patron details page, Check out, tab Article requests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125289|0 |1 is obsolete| | Attachment #125448|0 |1 is obsolete| | Attachment #125449|0 |1 is obsolete| | Attachment #125450|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125772&action=edit Bug 29093: Database revision for article_requests.toc_request Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125773&action=edit Bug 29093: Interface changes Show the TOC checkbox on OPAC and staff. Test plan: Add new article request on OPAC or staff. Tick checkbox. Verify if TOC is Yes on opac-user or staff patron details. Check the list view on circ/article-requests.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125774&action=edit Bug 29093: (QA follow-up) Adding two hover texts See QA request. Adding TOC hover text to: - OPAC user page, tab Article requests - Patron details page, Check out, tab Article requests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125775&action=edit [DO NOT PUSH] DBIx schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased on top of current master including the three pushed AR patch sets of this morning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- One moment please, still having a small issue here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29182 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29182 [Bug 29182] ArticleRequest status changing methods calling SUPER::store -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125772|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125787&action=edit Bug 29093: Database revision for article_requests.toc_request Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125773|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125788&action=edit Bug 29093: Interface changes Show the TOC checkbox on OPAC and staff. Test plan: Add new article request on OPAC or staff. Tick checkbox. Verify if TOC is Yes on opac-user or staff patron details. Check the list view on circ/article-requests.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125774|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125789&action=edit Bug 29093: (QA follow-up) Adding two hover texts See QA request. Adding TOC hover text to: - OPAC user page, tab Article requests - Patron details page, Check out, tab Article requests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125790&action=edit Bug 29093: (follow-up) Fix the all fields empty-warning We should allow checking the TOC box only. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125791&action=edit Bug 29093: (QA follow-up) Rebasing issue Bug 27944 added another block for the new stage introduced. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 125792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125792&action=edit DBIx schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Bug 29093 depends on bug 29182, which changed state. Bug 29182 Summary: ArticleRequest status changing methods calling SUPER::store https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29182 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30290 [Bug 30290] Article requests: Specify TOC on AR notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This bug introduced a database comment inconsistency on toc_request. Will address that on bug 34843 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34843 [Bug 34843] Koha/Database/Commenter.t is failing if the DB has been upgraded -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org