[Bug 21869] New: Bad update statement loses values for MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Bug ID: 21869 Summary: Bad update statement loses values for MarkLostItemsAsReturned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org bug 19287 added a new option to MarkLostItemsAsReturned it accidentally set an incorrect value for the preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 82640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82640&action=edit Bug 21869: Fix incorrect value setting in DB update To test: 1 - Set some value for MarkLostAsReturned syspref 2 - Set your db version to 17.12.00.035 (or load an older db) 3 - updatedatabase 4 - Note your values are lost and db is incorrectly set 5 - Apply patch 6 - Reset values 7 - Reset DB version 8 - Run updatedatabase 9 - Original values are retained -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- We can't restore any lost values, but this should allow us to prevent any further damage during upgrades -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Needs Signoff |BLOCKED --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- For me now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- What about the dbrev .35 in front: UPDATE systempreferences SET type="multiple", options="batchmod|moredetail|cronjob|additem", value="batchmod,moredetail,cronjob,additem" WHERE variable="MarkLostItemsAsReturned" Type is multiple so more values are allowed. But options are separated with | and values are separated with , comma Needs more attention -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- IRC <kidclamp> marcelr: yeah, the original db update did that, this was a followup adding a new option to the list [14:45] <kidclamp> so the values shouldn't be changed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82640|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82647&action=edit Bug 21869: Fix incorrect value setting in DB update To test: 1 - Set some value for MarkLostAsReturned syspref 2 - Set your db version to 17.12.00.035 (or load an older db) 3 - updatedatabase 4 - Note your values are lost and db is incorrectly set 5 - Apply patch 6 - Reset values 7 - Reset DB version 8 - Run updatedatabase 9 - Original values are retained Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- oops two SOs: one for signoff, one for qa :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Jesse Maseto <jesse@bywatersolutions.com> --- Pushed to stable for 18.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21869 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 19287 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org