[Bug 30989] New: Tags with some special characters are not encoded right
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 Bug ID: 30989 Summary: Tags with some special characters are not encoded right Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Turn on: TagsEnabled. 2. Log in to the OPAC and create a tag like "LGBTQ+" 3. Add that record to a list 3. Now try clicking on that tag from detail, results, and lists page. 4. If you click on the link for the "LGBTQ+" you will get a 'no results found page'. 5. The '+' needs to be encoded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 136303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136303&action=edit Bug 30989: Use uri filter where tag links are displayed TO test: 1. Turn on: TagsEnabled. 2. Log in to the OPAC and create a tag like "LGBTQ+" 3. Add that record to a list 3. Now try clicking on that tag from detail, results, and lists page. 4. If you click on the link for the "LGBTQ+" you will get a 'no results found page'. 5. Apply patch 6. Try clicking on each of the tags in detail, results, and lists. They should work now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136303|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 136311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136311&action=edit Bug 30989: Use uri filter where tag links are displayed TO test: 1. Turn on: TagsEnabled. 2. Log in to the OPAC and create a tag like "LGBTQ+" 3. Add that record to a list 3. Now try clicking on that tag from detail, results, and lists page. 4. If you click on the link for the "LGBTQ+" you will get a 'no results found page'. 5. Apply patch 6. Try clicking on each of the tags in detail, results, and lists. They should work now. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): - This patch is only for the OPAC, clicking on the tag in the staff interface (from the record details page) returns no results. The tag is not shown in the search results or lists in the staff interface). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136311|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136313&action=edit Bug 30989: Use uri filter where tag links are displayed TO test: 1. Turn on: TagsEnabled. 2. Log in to the OPAC and create a tag like "LGBTQ+" 3. Add that record to a list 3. Now try clicking on that tag from detail, results, and lists page. 4. If you click on the link for the "LGBTQ+" you will get a 'no results found page'. 5. Apply patch 6. Try clicking on each of the tags in detail, results, and lists. They should work now. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136314&action=edit Bug 30989: (QA follow-up) Use uri filter on staff detail page This applies the same fix as the first patch but to the staff interface detail page. With this fix, a tag like +++ can be clicked and the tagged records will show. To test: - Tag some records in the staff interface with something like +++ - Go to the detail page of one of those recods - Click on the tag - Verify nothing is found - Apply patch - Repeat - all tagged records will show Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes tags with release notes| |special characters (such as | |+) so that the searching | |returns results when the | |tag is selected (from the | |record detail view in the | |OPAC and staff interface, | |and from the search results | |page and lists in the | |OPAC). --- Comment #6 from David Nind <david@davidnind.com> --- Thanks Katrin for the follow-up so that this works in the staff interface! I think this also needs to work from the tag cloud page in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136317&action=edit Bug 30989:(QA follow-up) Use uri filter on OPAC tag cloud page This fixes 2 links on the page: * The tag within the 'all tags' cloud * The tag shown in the 'your tags' table Test plan as before: Test with a tag like +++ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes tags with |This fixes tags with release notes|special characters (such as |special characters (such as |+) so that the searching |+) so that the searching |returns results when the |returns results when the |tag is selected (from the |tag is selected (from the |record detail view in the |record detail view in the |OPAC and staff interface, |OPAC and staff interface, |and from the search results |and from the search |page and lists in the |results, tag cloud, and |OPAC). |list pages in the OPAC). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com Version(s)|22.11.00, 22.05.03 |22.11.00, 22.05.03, released in| |21.11.11 --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- backported to 21.11.x for 21.11.11, thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org