https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36414 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36414 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 163786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163786&action=edit Bug 36414: OPAC - Skip csrf_token Skip csrf_token field if it already exists and is coming from a previous workflow stage form submission, as it's already included at the start of the form. The test plan requires EDS credentials in order to be followed. I'm available to help others through this test plan if required. Otherwise, I believe the code is simple enough to understand and follow what it's fixing without testing. Test plan: 1) Install an ILL availabililty plugin, e.g.: https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds 3) Configure the plugin and add EDS credentials 4) Enable ILLCheckAvailability sys pref 5) Enable ILLModuleDisclaimerByType by copying the example YAML block in the sys pref description 6) Create a new ILL request of type 'Book' and add a DOI 7) You should now be on the availabililty stage, click 'Continue adding your request' 8) You should now be on the type disclaimer stage, click 'Create' 9) Notice 'Wrong CSRF token' error. This happens because the type disclaimer stage is adding its own CSRF token in addition to the CSRF token coming from the previous availabililty stage 10) Apply patch. Repeat. No error -> Request is created as expected. 11) Do the same test plan on both Staff UI and OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36414 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |lucas@bywatersolutions.com, | |nugged@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36414 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36414 --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166726&action=edit Bug 36414: OPAC - Skip csrf_token Skip csrf_token field if it already exists and is coming from a previous workflow stage form submission, as it's already included at the start of the form. The test plan requires EDS credentials in order to be followed. I'm available to help others through this test plan if required. Otherwise, I believe the code is simple enough to understand and follow what it's fixing without testing. Test plan: 1) Install an ILL availabililty plugin, e.g.: https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds 3) Configure the plugin and add EDS credentials 4) Enable ILLCheckAvailability sys pref 5) Enable ILLModuleDisclaimerByType by copying the example YAML block in the sys pref description 6) Create a new ILL request of type 'Book' and add a DOI 7) You should now be on the availabililty stage, click 'Continue adding your request' 8) You should now be on the type disclaimer stage, click 'Create' 9) Notice 'Wrong CSRF token' error. This happens because the type disclaimer stage is adding its own CSRF token in addition to the CSRF token coming from the previous availabililty stage 10) Apply patch. Repeat. No error -> Request is created as expected. 11) Do the same test plan on both Staff UI and OPAC Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36414 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens (kidclamp) from comment #5)

Untested, makes sense, simple patch, passing QA

... I'd be more confident with another SO or without that note ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36414 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36414 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.