[Bug 17963] New: TT syntax for notices - Prove that AR_* are compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Bug ID: 17963 Summary: TT syntax for notices - Prove that AR_* are compatible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17962, 17959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959 [Bug 17959] Add the Koha::Notice::Message[s] packages (message_queue table) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59433&action=edit Bug 17963: TT syntax for notices - Prove that AR_* are compatible Nothing new here since bug 17962, the AR_* notice messages are quite simple. They send the article_request, patron, biblio, biblioitem, item and library linked to the article request. All the fields from these 6 tables should still be accessible using the TT syntax. Test plan: Define TT notice templates for AR_PENDING, AR_PROCESSING, AR_COMPLETED or AR_CANCELED. You should manage to create a template to generate the same result as the historical syntax. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59433|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59434&action=edit Bug 17963: TT syntax for notices - Prove that AR_* are compatible Nothing new here since bug 17962, the AR_* notice messages are quite simple. They send the article_request, patron, biblio, biblioitem, item and library linked to the article request. All the fields from these 6 tables should still be accessible using the TT syntax. Test plan: Define TT notice templates for AR_PENDING, AR_PROCESSING, AR_COMPLETED or AR_CANCELED. You should manage to create a template to generate the same result as the historical syntax. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59434|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59440&action=edit Bug 17963: TT syntax for notices - Prove that AR_* are compatible Nothing new here since bug 17962, the AR_* notice messages are quite simple. They send the article_request, patron, biblio, biblioitem, item and library linked to the article request. All the fields from these 6 tables should still be accessible using the TT syntax. Test plan: Define TT notice templates for AR_PENDING, AR_PROCESSING, AR_COMPLETED or AR_CANCELED. You should manage to create a template to generate the same result as the historical syntax. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Needs Signoff |Failed QA --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- I think there is missing article_requests table definition in C4::Letters, I am getting the notice generated without any information from article_requests table... but test is passing... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59440|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59539&action=edit Bug 17963: TT syntax for notices - Prove that AR_* are compatible Nothing new here since bug 17962, the AR_* notice messages are quite simple. They send the article_request, patron, biblio, biblioitem, item and library linked to the article request. All the fields from these 6 tables should still be accessible using the TT syntax. Test plan: Define TT notice templates for AR_PENDING, AR_PROCESSING, AR_COMPLETED or AR_CANCELED. You should manage to create a template to generate the same result as the historical syntax. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #4)
I think there is missing article_requests table definition in C4::Letters, I am getting the notice generated without any information from article_requests table... but test is passing...
Yes indeed, the test was completely wrong! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59539|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60402&action=edit Bug 17963: TT syntax for notices - Prove that AR_* are compatible Nothing new here since bug 17962, the AR_* notice messages are quite simple. They send the article_request, patron, biblio, biblioitem, item and library linked to the article request. All the fields from these 6 tables should still be accessible using the TT syntax. Test plan: Define TT notice templates for AR_PENDING, AR_PROCESSING, AR_COMPLETED or AR_CANCELED. You should manage to create a template to generate the same result as the historical syntax. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Bug 17963 depends on bug 17962, which changed state. Bug 17962 Summary: TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Bug 17963 depends on bug 17959, which changed state. Bug 17959 Summary: Add the Koha::Notice::Message[s] packages (message_queue table) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60402|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 61594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61594&action=edit Bug 17963: TT syntax for notices - Prove that AR_* are compatible Nothing new here since bug 17962, the AR_* notice messages are quite simple. They send the article_request, patron, biblio, biblioitem, item and library linked to the article request. All the fields from these 6 tables should still be accessible using the TT syntax. Test plan: Define TT notice templates for AR_PENDING, AR_PROCESSING, AR_COMPLETED or AR_CANCELED. You should manage to create a template to generate the same result as the historical syntax. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Dependencies are not in 16.11.x, so this is not needed there. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org