[Bug 22515] New: OPACViewOthersSuggestions if set to Show will only show when patron has made a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Bug ID: 22515 Summary: OPACViewOthersSuggestions if set to Show will only show when patron has made a suggestion Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- If a library is allowing Purchase Suggestions and they also have the system preference OPACViewOthersSuggestions set to show- a patron can only see other patron's purchase suggestions if they have submitted a purchase suggestion of their own. If that patron has not submitted a purchase suggestion, then the opac-suggestion.pl page is blank and does not provide a way to see other suggestions. This defeats the purpose of this system preference. If a library has this set to show, they would like other patrons to see that the newest book by James Patterson has been suggested by another patron and to not create a second purchase suggestion when it is not needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|18.05 |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I don't see this behaviour on master. I can access all suggestions from the navigation for my logged in user and logged out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103797&action=edit Bug 22515: Improve logic determining how to show OPAC suggestions This patch makes changes to the OPAC suggestions view so that the logic around logged in users and the OPACViewOthersSuggestions preference is more specific. To reproduce the bug you should have pending purchase susggestions in your system from more than one patron. 1. Set the OPACViewOthersSuggestions preference to "Show." 2. Log in to the OPAC as a user who has not submitted any suggestions. 3. Follow the link to the purchase suggestions page from the menu under the search bar. 4. The page will say that there are no purchase suggestions. 5. Add "?suggested_by_anyone=1" to the end of the page URL. 6. You should see suggestions from other users. To test, apply the patch and repeat steps 2-3 above. The suggestions page should show other patrons' suggestions. Test with different combinations of factors: - Logged in user, OPACViewOthersSuggestions off - No logged in user, OPACViewOthersSuggestions on - No logged in user, OPACViewOthersSuggestions off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103797|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 103799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103799&action=edit Bug 22515: Improve logic determining how to show OPAC suggestions This patch makes changes to the OPAC suggestions view so that the logic around logged in users and the OPACViewOthersSuggestions preference is more specific. To reproduce the bug you should have pending purchase susggestions in your system from more than one patron. 1. Set the OPACViewOthersSuggestions preference to "Show." 2. Log in to the OPAC as a user who has not submitted any suggestions. 3. Follow the link to the purchase suggestions page from the menu under the search bar. 4. The page will say that there are no purchase suggestions. 5. Add "?suggested_by_anyone=1" to the end of the page URL. 6. You should see suggestions from other users. To test, apply the patch and repeat steps 2-3 above. The suggestions page should show other patrons' suggestions. Test with different combinations of factors: - Logged in user, OPACViewOthersSuggestions off - No logged in user, OPACViewOthersSuggestions on - No logged in user, OPACViewOthersSuggestions off Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103799|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104206&action=edit Bug 22515: Improve logic determining how to show OPAC suggestions This patch makes changes to the OPAC suggestions view so that the logic around logged in users and the OPACViewOthersSuggestions preference is more specific. To reproduce the bug you should have pending purchase susggestions in your system from more than one patron. 1. Set the OPACViewOthersSuggestions preference to "Show." 2. Log in to the OPAC as a user who has not submitted any suggestions. 3. Follow the link to the purchase suggestions page from the menu under the search bar. 4. The page will say that there are no purchase suggestions. 5. Add "?suggested_by_anyone=1" to the end of the page URL. 6. You should see suggestions from other users. To test, apply the patch and repeat steps 2-3 above. The suggestions page should show other patrons' suggestions. Test with different combinations of factors: - Logged in user, OPACViewOthersSuggestions off - No logged in user, OPACViewOthersSuggestions on - No logged in user, OPACViewOthersSuggestions off Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | CC| |joy@bywatersolutions.com --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org