[Bug 9091] New: Error in logic CheckBorrowerDebarred
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9091 Bug ID: 9091 Summary: Error in logic CheckBorrowerDebarred Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jdeca@smfpl.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In Overdues.pm subroutine CheckBorrowerDebarred. As far as I can tell debarred is 0 or 1 what is the purpose of testing against NOW()? sub CheckBorrowerDebarred { my ($borrowernumber) = @_; my $dbh = C4::Context->dbh; my $query = qq| SELECT debarred FROM borrowers WHERE borrowernumber=? AND debarred > NOW() <==========?? |; my $sth = $dbh->prepare($query); $sth->execute($borrowernumber); my $debarredstatus = $sth->fetchrow; return $debarredstatus; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9091 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- debarred is now a date field in the database (connected to the fines in days feature) - which version are you looking at? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9091 Fred P <fred.pierre@smfpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fred.pierre@smfpl.org --- Comment #2 from Fred P <fred.pierre@smfpl.org> --- I believe this is a legacy data issue. New patrons are given a debarred date of 12-31-9999, debarred patrons are assigned a specific debarred date, while legacy patrons retain a [NULL] for debarred status in the borrowers table. Custom scripts will need to address these three possibilities. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9091 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9091 --- Comment #3 from Jorge de Cardenas <jdeca@smfpl.org> --- (In reply to comment #1)
debarred is now a date field in the database (connected to the fines in days feature) - which version are you looking at?
I have to systems running a test system which is 3.09.00.029 at a system I'm preparing to migrate our data into which is 3.09.00.059. On the .029 the database is still a tinyint for that field. It could have been that the database conversion failed. The .059 system has the correct datatype. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org