[Bug 18672] New: Creation Date and Modification Date are the same for a list in the Lists Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Bug ID: 18672 Summary: Creation Date and Modification Date are the same for a list in the Lists Module Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: karen@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 63720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63720&action=edit Creation Date and Modification Date are the same for a list in the Lists Module In the Lists Module the creation date and the modification date show the same date for each list. The expected behavior is that the creation date would be the date that the list was created and the modification date would be the last date that any changes were made. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Version|16.11 |master --- Comment #1 from Marc Véron <veron@veron.ch> --- Confirmed on current master. The error occurs when a list is edited. To reproduce: - In staff client, create a new list (if you have not already one) - In db, update virtualshelves and set field created_on to an earlier date, something like: update virtualshelves set created_on = '2017-04-01 02:09:12' where shelfnumber = 1; - Go to Home > Lists > Your lists - Verify that the modified creation date for this list appears in staff client - Edit list in staff client, save - Verify that creation date is overwritten by modification date (wrong) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 63781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63781&action=edit Bug 18672 - Fix overwriting creation date with modification date when editing list To reproduce: - In staff client, create a new list (if you have not already one) - In db, update virtualshelves and set field created_on to an earlier date, something like: update virtualshelves set created_on = '2017-04-01 02:09:12' where shelfnumber = 1; - Go to Home > Lists > Your lists - Verify that the modified creation date for this list appears in staff client - Edit list in staff client, save - Verify that creation date is overwritten by modification date (wrong) To test: - Apply patch - Repeat steps above, verify that creation date no longer is overwritten by modification date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 63782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63782&action=edit Bug 18672: Test for fixing overwriting creation date Use this test to highlight issue: prove -v t/db_dependent/Virtualshelves.t After applying patch for Koha/Virtualshelf.pm it should turn green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldjamison@marywood.edu --- Comment #4 from Lee Jamison <ldjamison@marywood.edu> --- Marc, while testing, QA tools passes without a problem but I've tried repeated unit tests against your patch but they all seem to fail with the following: t/XSLT.t ............................ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/10 subtests t/dummy.t ........................... ok Test Summary Report ------------------- t/XSLT.t (Wstat: 256 Tests: 10 Failed: 1) Failed test: 10 Non-zero exit status: 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 --- Comment #5 from Lee Jamison <ldjamison@marywood.edu> --- The XSLT turned out to be a problem on my machine regarding singleBranchMode. Everything looks good now so will sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63781|0 |1 is obsolete| | Attachment #63782|0 |1 is obsolete| | --- Comment #6 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64063&action=edit [SIGNED OFF] Bug 18672 Use this test to highlight issue: prove -v t/db_dependent/Virtualshelves.t After applying patch for Koha/Virtualshelf.pm it should turn green Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Works correctly according to test case. Passes QA Tools and the indicated t/db_dependent/Virtualshelves.t unit test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63781|1 |0 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 63781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63781 Bug 18672 - Fix overwriting creation date with modification date when editing list Incorrectly obsoleted as it seems -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63781|0 |1 is obsolete| | Attachment #64063|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64585&action=edit Bug 18672: Fix overwriting creation date with modification date when editing list To reproduce: - In staff client, create a new list (if you have not already one) - In db, update virtualshelves and set field created_on to an earlier date, something like: update virtualshelves set created_on = '2017-04-01 02:09:12' where shelfnumber = 1; - Go to Home > Lists > Your lists - Verify that the modified creation date for this list appears in staff client - Edit list in staff client, save - Verify that creation date is overwritten by modification date (wrong) To test: - Apply patch - Repeat steps above, verify that creation date no longer is overwritten by modification date Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64586&action=edit Bug 18672: Test for fixing overwriting creation date Use this test to highlight issue: prove -v t/db_dependent/Virtualshelves.t After applying patch for Koha/Virtualshelf.pm it should turn green Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Works correctly according to test case. Passes QA Tools and the indicated t/db_dependent/Virtualshelves.t unit test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64587&action=edit Bug 18672: [QA Follow-up] Simplify without sleep Set the creation date one hour back, store and check again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Patch doesn't apply --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please rebase on top of bug 18228. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64585|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64994&action=edit Bug 18672: Fix overwriting creation date with modification date when editing list To reproduce: - In staff client, create a new list (if you have not already one) - In db, update virtualshelves and set field created_on to an earlier date, something like: update virtualshelves set created_on = '2017-04-01 02:09:12' where shelfnumber = 1; - Go to Home > Lists > Your lists - Verify that the modified creation date for this list appears in staff client - Edit list in staff client, save - Verify that creation date is overwritten by modification date (wrong) To test: - Apply patch - Repeat steps above, verify that creation date no longer is overwritten by modification date Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64586|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64995&action=edit Bug 18672: Test for fixing overwriting creation date Use this test to highlight issue: prove -v t/db_dependent/Virtualshelves.t After applying patch for Koha/Virtualshelf.pm it should turn green Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Works correctly according to test case. Passes QA Tools and the indicated t/db_dependent/Virtualshelves.t unit test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64587|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64996&action=edit Bug 18672: [QA Follow-up] Simplify without sleep Set the creation date one hour back, store and check again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org